New issue
Advanced search Search tips

Issue 606669 link

Starred by 0 users

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

8.3% improvement in webrtc_perf_tests at 12471:12471

Project Member Reported by peah@chromium.org, Apr 26 2016

Issue description

There is a regression in the ramp-up-media-sent/AbsSendTimeSimulcast webrtc_perf_tes
 

Comment 1 by peah@chromium.org, Apr 26 2016

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=606669

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgpMCBrAoM


Bot(s) for this bug's original alert(s):

webrtc-win-large-tests

Comment 2 by peah@chromium.org, Apr 26 2016

Cc: peah@chromium.org
Owner: nisse@chromium.org
@nisse: Could you please take a look to see whether your CL https://codereview.webrtc.org/1875713002 could have caused this?

Comment 3 by nisse@chromium.org, Apr 27 2016

Could you give me a little background on what's measured for this graph? 

The only thing done in the cl in question is adding a testcase P2PTestConductor.ForwardVideoOnlyStream, included in webrtc's build target peerconnection_unittests. To me it looks like an unlikely source of the step on the graph.

Comment 4 by peah@chromium.org, Apr 28 2016

The graph shows a metric which is produced by the AbsSendTimeSimulcast test in WebRTC/webrtc-win-large-tests/webrtc_perf_tests/ramp-up-media-sent/ but apart from seeing that it has seemed to change I have no idea of what it measures.

Looking at your CL, it indeed looks unlikely that your CL caused the issue.

Comment 5 by peah@chromium.org, Apr 28 2016

Cc: nisse@chromium.org
Owner: holmer@chromium.org
Reassigning to @holmer.

@holmer: Do you think this could be caused by the CL https://codereview.webrtc.org/1908893003?

Comment 6 by holmer@chromium.org, Apr 28 2016

Status: WontFix (was: Assigned)
Probably. Let's assume it's caused by that. Closing since it's an improvement and somewhat expected.

Sign in to add a comment