New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 606661 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Blank sub list is seen unless you hover on it in wrenchmenu

Project Member Reported by sc00335...@techmahindra.com, Apr 26 2016

Issue description

Version: 52.0.2717.0 dev
OS: Ubuntu 14.04

What steps will reproduce the problem?
(1) Launch chrome >> Click on wrench menu >> Now hover on any menu which has sublist[Ex: History/Bookmarks/More tools/Help] and observe for sublist

Expected: Sublist should be visible even without hovering on list items
Actual: Instead transparent menu sublist is seen. It appears only on hovering.

This is a regression issue broken in M52. Issue is not seen in windows.

Good Build: 52.0.2716.0 dev
Bad Build: 52.0.2717.0 dev
 
Actual_blank overlay.ogv
1.2 MB Download
Expected_blank overlay.ogv
1.0 MB Download

Comment 1 by pdr@chromium.org, Apr 26 2016

Components: -Blink>Paint UI>Browser
Owner: bruthig@chromium.org
Status: Assigned (was: Unconfirmed)
Unlikely to be blink paint related since this is in browser UI. Possibly https://chromium.googlesource.com/chromium/src/+/b1068403be34a565e8be1aafe2fc7a2f0ba3f3eb?

@bruthig, I'm not very familiar with the browser UI code. If this isn't your patch, could you help triage this?

https://chromium.googlesource.com/chromium/src/+log/52.0.2716.0..52.0.2717.0?pretty=fuller&n=10000
Cc: bruthig@chromium.org
Labels: -Needs-Bisect hasbisect ReleaseBlock-Beta
Owner: e...@chromium.org
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/f28b4a3b736320395a2862b4dde8f9218073d9b0..3d73e44f7177fe1dbb6e868120b985a6c9fb8a30

Suspecting https://codereview.chromium.org/1896363004 from changelog.

@erg: Please help in re-assigning if it is not related to your change.

Attaching chrome://gpu information.

Issue is not seen with 52.0.2717.0 dev in ubuntu 12.04.
chrome___gpu.pdf
140 KB Download

Comment 3 by ajha@chromium.org, Apr 26 2016

Cc: ligim...@chromium.org
Able to reproduce this on Linux Ubuntu 14.04, chrome version:52.0.2717.0, with the attached gpu.

**Worked fine on the same chrome version with 'NVIDIA/Quadro 600/PCle/SSE2' driver on Ubuntu 14.04.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64a7c6401449a843118d9fc208798674a5a8c7ea

commit 64a7c6401449a843118d9fc208798674a5a8c7ea
Author: erg <erg@chromium.org>
Date: Wed Apr 27 18:59:46 2016

Revert of x11: Don't wait on a MapNotify on override-redirect windows. (patchset #3 id:40001 of https://codereview.chromium.org/1896363004/ )

Reason for revert:
Patch suspected to cause blank sublist on menus.

BUG= 606661 

Original issue's description:
> x11: Don't wait on a MapNotify on override-redirect windows.
>
> Some window managers do not send MapNotify on override-redirect
> windows. Enlightenment doesn't send one, XFCE does, and I don't know
> which behaviour is more common.
>
> This makes mapping resilient against whether we would have received a
> MapNotify message on override-redirect window. On override-redirect
> windows, we immediately trigger the code that would run in the future
> MapNotify handler, and ignore it in the future MapNotify message if it
> is already run.
>
> BUG= 381732 
>
> Committed: https://crrev.com/28bb70402ddc4e68963f536388730c63598f8d65
> Cr-Commit-Position: refs/heads/master@{#389572}

TBR=danakj@chromium.org,thomasanderson@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 381732 

Review-Url: https://codereview.chromium.org/1931583002
Cr-Commit-Position: refs/heads/master@{#390140}

[modify] https://crrev.com/64a7c6401449a843118d9fc208798674a5a8c7ea/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
[modify] https://crrev.com/64a7c6401449a843118d9fc208798674a5a8c7ea/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h

Comment 5 by e...@chromium.org, Apr 27 2016

Status: Fixed (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a23e0eae44653ab9f132d454ac6488c8c8005479

commit a23e0eae44653ab9f132d454ac6488c8c8005479
Author: erg <erg@chromium.org>
Date: Fri Apr 29 21:51:13 2016

[reland] x11: Don't wait on a MapNotify on override-redirect windows.

[This reland should theoretically fix a case where timing issues on
AMD drivers appear to cause a blank window by forcing a redraw when
we are an override-redirect window and receive a MapNotify.]

Some window managers do not send MapNotify on override-redirect
windows. Enlightenment doesn't send one, XFCE does, and I don't know
which behaviour is more common.

This makes mapping resilient against whether we would have received a
MapNotify message on override-redirect window. On override-redirect
windows, we immediately trigger the code that would run in the future
MapNotify handler, and ignore it in the future MapNotify message if it
is already run.

BUG= 381732 , 606661 
First Review URL: https://codereview.chromium.org/1896363004

Review-Url: https://codereview.chromium.org/1933923002
Cr-Commit-Position: refs/heads/master@{#390773}

[modify] https://crrev.com/a23e0eae44653ab9f132d454ac6488c8c8005479/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
[modify] https://crrev.com/a23e0eae44653ab9f132d454ac6488c8c8005479/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h

Status: Assigned (was: Fixed)
NOTE: Issue is not seen in 52.0.2720.0 dev,Ubuntu 14.04 but issue is seen in 52.0.2722.0 dev Ubuntu 14.04.i.e Blank sublist is seen in wrench menu.

@erg: Please confirm the issue.

Attaching video for reference.
Actual_606661.ogv
896 KB Download
Project Member

Comment 8 by bugdroid1@chromium.org, May 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6184cdf538895d1ca804d1c2abb2474ec1abd54

commit e6184cdf538895d1ca804d1c2abb2474ec1abd54
Author: erg <erg@chromium.org>
Date: Mon May 02 17:55:36 2016

Revert of x11: Don't wait on a MapNotify on override-redirect windows. (patchset #3 id:40001 of https://codereview.chromium.org/1933923002/ )

Reason for revert:
Forcing a draw didn't actually fix the blank submenu issue.

Original issue's description:
> [reland] x11: Don't wait on a MapNotify on override-redirect windows.
>
> [This reland should theoretically fix a case where timing issues on
> AMD drivers appear to cause a blank window by forcing a redraw when
> we are an override-redirect window and receive a MapNotify.]
>
> Some window managers do not send MapNotify on override-redirect
> windows. Enlightenment doesn't send one, XFCE does, and I don't know
> which behaviour is more common.
>
> This makes mapping resilient against whether we would have received a
> MapNotify message on override-redirect window. On override-redirect
> windows, we immediately trigger the code that would run in the future
> MapNotify handler, and ignore it in the future MapNotify message if it
> is already run.
>
> BUG= 381732 , 606661 
> First Review URL: https://codereview.chromium.org/1896363004
>
> Committed: https://crrev.com/a23e0eae44653ab9f132d454ac6488c8c8005479
> Cr-Commit-Position: refs/heads/master@{#390773}

TBR=danakj@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 381732 , 606661 

Review-Url: https://codereview.chromium.org/1934413002
Cr-Commit-Position: refs/heads/master@{#390989}

[modify] https://crrev.com/e6184cdf538895d1ca804d1c2abb2474ec1abd54/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
[modify] https://crrev.com/e6184cdf538895d1ca804d1c2abb2474ec1abd54/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h

Comment 9 by ajha@chromium.org, May 5 2016

Revert seems to have worked and Issue is working fine on the latest M-52(52.0.2725.0) on Linux Ubuntu 14.04 on the system with the gpu as attached in C#2.

Comment 10 by e...@chromium.org, May 11 2016

Status: Fixed (was: Assigned)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-52; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-52 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD
[Bulk edit]

Our blockerbot script was offline; it was recently brought back online, and thus labeled many old issues (including this one) erroneously.  Removing Merge-TBD label since all milestones for this issue are already completed; no further work should be done.

Sign in to add a comment