New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 606657 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

runAccessibilityAudit is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Apr 26 2016

Issue description

"OptionsWebUITest.EnableAndDisableDoNotTrack" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNgsSBUZsYWtlIitPcHRpb25zV2ViVUlUZXN0LkVuYWJsZUFuZERpc2FibGVEb05vdFRyYWNrDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by mgiuca@chromium.org, Apr 26 2016

Cc: mgiuca@chromium.org
 Issue 606658  has been merged into this issue.

Comment 2 by mgiuca@chromium.org, Apr 26 2016

Components: -Tests>Flaky UI>Accessibility
Labels: -Sheriff-Chromium Hotlist-Accessibility
Owner: aboxhall@chromium.org
Status: Assigned (was: Untriaged)
Summary: runAccessibilityAudit is flaky (was: "OptionsWebUITest.EnableAndDisableDoNotTrack" is flaky)
This is affecting many WebUI tests (gathered from a few of the recent flakes):

AdvancedSettingsWebUITest.testAdvancedSettingsShown
AutofillOptionsWebUITest.testOpenAutofillOptions
BrowserOptionsFrameWebUITest.testAdvancedSettingsHiddenByDefault
EditDictionaryWebUITest.testAddNotification (x2)
EditDictionaryWebUITest.testNoCloseOnSearchEnter
FontSettingsWebUITest.testAdvancedFontSettingsLink
FontSettingsWebUITest.testOpenFontSettings (x2)
LanguageOptionsWebUITest.testOpenLanguageOptions (x2)
LanguagesOptionsDictionaryDownloadWebUITest.testdictionaryDownloadRetry
OptionsWebUITest.EnableAndDisableDoNotTrack (x3)
OptionsWebUITest.EnableDoNotTrackAndConfirmInterstitial
SettingsFormatWebUITest.RadioButtonNameValueCheck (x2)
SettingsFormatWebUITest.RadioCheckboxStyleCheck (x2)

All of them are the same, which is accessibility check is failing. Here is a typical output:

*** Begin accessibility audit results ***
An accessibility audit found
Errors:
Error: AX_ARIA_08 (Elements with ARIA roles must ensure required owned elements are present) failed on the following elements (1 - 2 of 2):
#default-search-engine-list
#other-search-engine-list
See https://github.com/GoogleChrome/accessibility-developer-tools/wiki/Audit-Rules#ax_aria_08 for more information.


*** End accessibility audit results ***
    at Object.runAccessibilityAudit (test_api.js:371:17)
    at Object.runAccessibilityAudit (test_api.js:501:22)
    at test_api.js:995:20
    at testDone (test_api.js:783:31)
    at runTest (test_api.js:1042:7)
    at <anonymous>:1:1
gen/chrome/browser/ui/webui/options/settings_format_browsertest-gen.cc:53: Failure
Value of: RunJavascriptTestF( false, "SettingsFormatWebUITest", "RadioButtonNameValueCheck")
  Actual: false
Expected: true

These tests are possibly broken but I think the accessibility audit code should not be flaky. Assigning to aboxhall to investigate. If necessary, we can re-assign onto the individual test owners but I think good to take a look at the accessibility audit system first.

Comment 3 by creis@chromium.org, Apr 26 2016

There's more failures in  issue 605689 , which I'll dupe into this one.

Comment 4 by creis@chromium.org, Apr 26 2016

Cc: dbeam@chromium.org dmazz...@chromium.org
 Issue 605689  has been merged into this issue.

Comment 5 by dbeam@chromium.org, Apr 26 2016

aboxhall@: can we disable the crazy .focus() storm during tearDown() to see if this reduces flakiness?
Cc: apaci...@chromium.org michae...@chromium.org dschuyler@chromium.org
 Issue 611233  has been merged into this issue.
Project Member

Comment 8 by bugdroid1@chromium.org, May 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b04fffc834429a96ddc89a32113b429aa52025b0

commit b04fffc834429a96ddc89a32113b429aa52025b0
Author: tapted <tapted@chromium.org>
Date: Thu May 12 04:27:10 2016

Disable failing accessibility audit in OptionsWebUITest tests.

Causes OptionsWebUITest.testDefaultZoomFactor to flake.

TBR=dbeam@chromium.org
BUG= 611233 , 606657

Review-Url: https://codereview.chromium.org/1973823002
Cr-Commit-Position: refs/heads/master@{#393181}

[modify] https://crrev.com/b04fffc834429a96ddc89a32113b429aa52025b0/chrome/browser/ui/webui/options/options_browsertest.js

Labels: NewComponent-Accessibility-DevTools NewComponent-Accessibility
Components: Platform>Apps>DevTools>Accessibility
Components: -UI>Accessibility
Labels: -newcomponent-accessibility-devtools -newcomponent-accessibility
Cc: hcarmona@chromium.org quacht@google.com
Labels: a11y-secondary
Some more info on the a11y testing framework we built over the summer.
Been working on getting better documentation for it going forward.
Feel free to ping me for more details where the doc is lacking :-)

https://www.chromium.org/developers/accessibility/testing/axe-core

Sign in to add a comment