New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 606649 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"fast/dom/gc-dom-tree-lifetime.html" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Apr 26 2016

Issue description

"fast/dom/gc-dom-tree-lifetime.html" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLQsSBUZsYWtlIiJmYXN0L2RvbS9nYy1kb20tdHJlZS1saWZldGltZS5odG1sDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by mgiuca@chromium.org, Apr 26 2016

Cc: mgiuca@chromium.org
Components: -Tests>Flaky Blink>MemoryAllocator>GarbageCollection
Labels: -Sheriff-Chromium
Owner: hayato@chromium.org
Status: Started (was: Untriaged)
Test fails due to Timeout (seemingly more often than not). Disabling (marking as [ Pass Timeout ]).

https://codereview.chromium.org/1917073003/

Assigning to hayato@ because of recent changes to fast/dom directory. Feel free to redirect.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3278c01ab0232931981b0b52d84b1cd0653b6519

commit 3278c01ab0232931981b0b52d84b1cd0653b6519
Author: mgiuca <mgiuca@chromium.org>
Date: Tue Apr 26 07:03:00 2016

Mark fast/dom/gc-dom-tree-lifetime.html as flaky (timeout).

TBR=hayato@chromium.org
BUG= 606649 

Review URL: https://codereview.chromium.org/1917073003

Cr-Commit-Position: refs/heads/master@{#389713}

[modify] https://crrev.com/3278c01ab0232931981b0b52d84b1cd0653b6519/third_party/WebKit/LayoutTests/TestExpectations

Cc: kouhei@chromium.org haraken@chromium.org
 Issue 356828  has been merged into this issue.

Comment 4 by hayato@chromium.org, May 30 2016

Cc: hayato@chromium.org
Owner: kouhei@chromium.org
Status: Assigned (was: Started)
kouhei@, haraken@,

Could you own this bug?

Comment 5 by kouhei@chromium.org, May 31 2016

Status: Fixed (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, May 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4584158cf0a8f5370832cb775aae08dd99560a09

commit 4584158cf0a8f5370832cb775aae08dd99560a09
Author: kouhei <kouhei@chromium.org>
Date: Tue May 31 03:21:14 2016

Remove node count checks from fast/dom/gc-dom-tree-lifetime.html

Before this CL, the test result depended on synchronous gc() call
which was non-determistic after Oilpan.
This CL removes the node count check to make the test runs deterministic.

This change is safe, as the leak checks are now ensured by Blink Leak Detector,
which supports Oilpan.

BUG= 606649 

Review-Url: https://codereview.chromium.org/2025773002
Cr-Commit-Position: refs/heads/master@{#396774}

[modify] https://crrev.com/4584158cf0a8f5370832cb775aae08dd99560a09/third_party/WebKit/LayoutTests/fast/dom/gc-dom-tree-lifetime-expected.txt
[modify] https://crrev.com/4584158cf0a8f5370832cb775aae08dd99560a09/third_party/WebKit/LayoutTests/fast/dom/gc-dom-tree-lifetime.html

Sign in to add a comment