New issue
Advanced search Search tips

Issue 606643 link

Starred by 1 user
Status: Fixed
Owner:
nedngu...@google.com
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Update all the callsites of telemetry.page_test in chromium src to reference telemetry.legacy_page_test

Project Member Reported by nedngu...@google.com, Apr 26 2016 
TBMV2 (https://docs.google.com/document/d/1LJbh9iF7e18jNEDwD_tYt5WtiOoMJdV12Z9GxdTLJUo/edit#) is the way to write new performance benchmark in telemetry. We would want to rename telemetry.page_test to telemetry.legacy_page_test to make it clear for our users that page_test is obsolete.

https://codereview.chromium.org/1921633003/ is for renaming telemetry.page_test  to  telemetry.legacy_page_test.

This bug is to track the effort of updating the callsites of telemetry.page_test in chromium src to reference telemetry.legacy_page_test
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9321b1b00d13ce8833d5a434f5c1f3f675576fa

commit e9321b1b00d13ce8833d5a434f5c1f3f675576fa
Author: nednguyen <nednguyen@google.com>
Date: Wed Apr 27 20:47:10 2016

[tools/perf] Reference legacy_page_test module instead of page_test

BUG= 606643 

Review-Url: https://codereview.chromium.org/1917393002
Cr-Commit-Position: refs/heads/master@{#390176}

[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/benchmarks/blink_perf.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/benchmarks/dromaeo.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/benchmarks/dummy_benchmark.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/benchmarks/indexeddb_perf.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/benchmarks/jetstream.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/benchmarks/kraken.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/benchmarks/media.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/benchmarks/octane.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/benchmarks/oortonline.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/benchmarks/robohornet_pro.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/benchmarks/service_worker.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/benchmarks/spaceport.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/benchmarks/speedometer.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/benchmarks/sunspider.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/measurements/blink_style.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/measurements/draw_properties.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/measurements/image_decoding.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/measurements/measurement_smoke_test.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/measurements/media.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/measurements/memory.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/measurements/no_op.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/measurements/oilpan_gc_times.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/measurements/page_cycler.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/measurements/power.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/measurements/rasterize_and_record_micro.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/measurements/rasterize_and_record_micro_unittest.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/measurements/skpicture_printer.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/measurements/smoothness.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/measurements/startup.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/measurements/tab_switching.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/measurements/task_execution_time.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/measurements/thread_times.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/measurements/timeline_controller.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/measurements/v8_detached_context_age_in_gc.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/measurements/v8_gc_times.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/measurements/webrtc.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/page_sets/blob_workshop.py
[modify] https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa/tools/perf/page_sets/repaint_helpers.py
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 2 2016

Labels: Hotlist-Google
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b92d2891c2e7488162b59244ae1689be96f5374

commit 2b92d2891c2e7488162b59244ae1689be96f5374
Author: nednguyen <nednguyen@google.com>
Date: Fri Dec 02 00:53:04 2016

Update reference to page_test module to use legacy_page_test module

BUG= 606643 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2539973004
Cr-Commit-Position: refs/heads/master@{#435798}

[modify] https://crrev.com/2b92d2891c2e7488162b59244ae1689be96f5374/chrome/test/media_router/telemetry/benchmarks/media_router_measurements.py
[modify] https://crrev.com/2b92d2891c2e7488162b59244ae1689be96f5374/content/test/gpu/gpu_tests/cloud_storage_test_base.py
[modify] https://crrev.com/2b92d2891c2e7488162b59244ae1689be96f5374/content/test/gpu/gpu_tests/gpu_process.py
[modify] https://crrev.com/2b92d2891c2e7488162b59244ae1689be96f5374/content/test/gpu/gpu_tests/gpu_rasterization.py
[modify] https://crrev.com/2b92d2891c2e7488162b59244ae1689be96f5374/content/test/gpu/gpu_tests/gpu_test_base.py
[modify] https://crrev.com/2b92d2891c2e7488162b59244ae1689be96f5374/content/test/gpu/gpu_tests/hardware_accelerated_feature.py
[modify] https://crrev.com/2b92d2891c2e7488162b59244ae1689be96f5374/content/test/gpu/gpu_tests/maps.py
[modify] https://crrev.com/2b92d2891c2e7488162b59244ae1689be96f5374/content/test/gpu/gpu_tests/screenshot_sync.py
[modify] https://crrev.com/2b92d2891c2e7488162b59244ae1689be96f5374/content/test/gpu/gpu_tests/trace_test.py
[modify] https://crrev.com/2b92d2891c2e7488162b59244ae1689be96f5374/content/test/gpu/page_sets/gpu_process_tests.py
[modify] https://crrev.com/2b92d2891c2e7488162b59244ae1689be96f5374/tools/chrome_proxy/common/chrome_proxy_measurements.py
[modify] https://crrev.com/2b92d2891c2e7488162b59244ae1689be96f5374/tools/chrome_proxy/common/chrome_proxy_metrics.py
[modify] https://crrev.com/2b92d2891c2e7488162b59244ae1689be96f5374/tools/chrome_proxy/common/network_metrics.py
[modify] https://crrev.com/2b92d2891c2e7488162b59244ae1689be96f5374/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py
[modify] https://crrev.com/2b92d2891c2e7488162b59244ae1689be96f5374/tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py
[modify] https://crrev.com/2b92d2891c2e7488162b59244ae1689be96f5374/tools/chrome_proxy/live_tests/chrome_proxy_measurements.py
[modify] https://crrev.com/2b92d2891c2e7488162b59244ae1689be96f5374/tools/chrome_proxy/live_tests/chrome_proxy_metrics.py
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/575e9daba072ce58d33e291d34d1b405884761f3

commit 575e9daba072ce58d33e291d34d1b405884761f3
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Fri Dec 02 17:06:33 2016

Roll src/third_party/catapult/ e4611d299..b4479b33c (1 commit).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e4611d2994c2..b4479b33ca52

$ git log e4611d299..b4479b33c --date=short --no-merges --format='%ad %ae %s'
2016-12-02 nednguyen [Telemetry] Remove page_test module

BUG= 606643 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2545073002
Cr-Commit-Position: refs/heads/master@{#435959}

[modify] https://crrev.com/575e9daba072ce58d33e291d34d1b405884761f3/DEPS

Comment 5 by nedngu...@google.com, Dec 2 2016

Status: Fixed (was: Started)
►

Sign in to add a comment