New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 606632 link

Starred by 1 user
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: Apr 2016
Cc:
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 593989



Sign in to add a comment

[MD settings] side nav expands basic and advanced settings

Project Member Reported by dschuyler@chromium.org, Apr 26 2016 
In chrome://md-settings, click on the Basic and Advanced sections
in the side nav. See that sometimes both are expanded.

Only one (either Basic or Advanced) should be expanded at a time.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e46c22835a225bc3c6361a45fa3558400eb7b5dd

commit e46c22835a225bc3c6361a45fa3558400eb7b5dd
Author: dschuyler <dschuyler@chromium.org>
Date: Fri Apr 29 23:32:19 2016

[MD settings] side nav routing to page sections

This CL makes the side nav show the correct settings
section when selecting a page in the menu. Several
routes have been added for top-level pages
(non-subpages). A SettingsRoute closure type has been
defined.

BUG= 604942 ,  593989 ,  584478 ,  606632 

Review-Url: https://codereview.chromium.org/1916323002
Cr-Commit-Position: refs/heads/master@{#390802}

[modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/browser/resources/settings/advanced_page/advanced_page.html
[modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/browser/resources/settings/advanced_page/advanced_page.js
[modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/browser/resources/settings/advanced_page/compiled_resources2.gyp
[modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/browser/resources/settings/basic_page/basic_page.html
[modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/browser/resources/settings/basic_page/basic_page.js
[modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/browser/resources/settings/basic_page/compiled_resources2.gyp
[modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/browser/resources/settings/settings_menu/settings_menu.html
[modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/browser/resources/settings/settings_menu/settings_menu.js
[modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/browser/resources/settings/settings_page/main_page_behavior.js
[modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/browser/resources/settings/settings_page/settings_animated_pages.js
[modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/browser/resources/settings/settings_page/settings_router.js
[modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/test/data/webui/settings/people_page_test.js

Comment 2 by dschuyler@chromium.org, Apr 29 2016

Status: Fixed (was: Started)
►

Sign in to add a comment