New issue
Advanced search Search tips

Issue 606611 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Snooze does nothing if not logged in

Project Member Reported by mgiuca@chromium.org, Apr 26 2016

Issue description

Problem with Sheriff-o-Matic:
https://sheriff-o-matic.appspot.com/chromium

I click the Snooze button. It shows an ink drop but nothing else happens.
 
Labels: -Infra-Monitoring Infra-DX
Redirecting to the correct queue (mgiuca: not your fault, we should update the link on SoM)
Cc: martiniss@chromium.org
are you logged in?
If the user isn't logged in, nothing will happen; they won't even get an error message. We should probably fix that :( 

Is there a standard way you show error messages in polymer?
Ok that's probably why nothing happened for mgiuca (most users don't think to log into SoM, we should fix that :). 

Lazy fix: just don't render those buttons for logged-out users :)

Better fix: prompt the user to log in whenever the attempt to do something that requires auth and they're currently logged out. Could be a modal dialog, paper-toast, or something else in between those two "annoying roadblock" and "barely noticed it" extremes.

Stretch fix: automatically execute that action on successful login redirect (more difficult in this circumstance because there is no direct link to "Snooze This Alert" - it's all handled in-page).


Comment 5 by mgiuca@chromium.org, Apr 26 2016

Summary: Snooze does nothing if not logged in (was: Snooze does nothing)
I wasn't logged in. Now I am and Snooze works.

(Last time I was sheriff there was no log-in and Snooze was a global thing. I guess it's changed now.)
Owner: martiniss@chromium.org
Status: Started (was: Untriaged)
Yeah, it's a new thing I landed last week. I sent out an email to chromium-dev; there isn't an email list for sheriffs that I know of :(

I've uploaded https://codereview.chromium.org/1922983002 which is the better fix mentioned in #4

Comment 7 by aga...@chromium.org, Apr 27 2016

Components: Infra>SheriffOMatic
Labels: -SheriffOMatic
Status: Fixed (was: Started)
Current behavior is fixed. Not sure if we want logging in to be required for adding annotations though.... Default of requiring is ok for now I think, but I'd be ok with opening it up to not have login. Sheriffs will need to be logged in in the future, to access internal alerts.

Sign in to add a comment