Snooze does nothing if not logged in |
||||||
Issue descriptionProblem with Sheriff-o-Matic: https://sheriff-o-matic.appspot.com/chromium I click the Snooze button. It shows an ink drop but nothing else happens.
,
Apr 26 2016
are you logged in?
,
Apr 26 2016
If the user isn't logged in, nothing will happen; they won't even get an error message. We should probably fix that :( Is there a standard way you show error messages in polymer?
,
Apr 26 2016
Ok that's probably why nothing happened for mgiuca (most users don't think to log into SoM, we should fix that :). Lazy fix: just don't render those buttons for logged-out users :) Better fix: prompt the user to log in whenever the attempt to do something that requires auth and they're currently logged out. Could be a modal dialog, paper-toast, or something else in between those two "annoying roadblock" and "barely noticed it" extremes. Stretch fix: automatically execute that action on successful login redirect (more difficult in this circumstance because there is no direct link to "Snooze This Alert" - it's all handled in-page).
,
Apr 26 2016
I wasn't logged in. Now I am and Snooze works. (Last time I was sheriff there was no log-in and Snooze was a global thing. I guess it's changed now.)
,
Apr 26 2016
Yeah, it's a new thing I landed last week. I sent out an email to chromium-dev; there isn't an email list for sheriffs that I know of :( I've uploaded https://codereview.chromium.org/1922983002 which is the better fix mentioned in #4
,
Apr 27 2016
,
Apr 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/aa64dd6b521a466a8a5ab68a982703ee13bf9c25 commit aa64dd6b521a466a8a5ab68a982703ee13bf9c25 Author: martiniss <martiniss@chromium.org> Date: Wed Apr 27 17:51:52 2016 sheriff_o_matic: Add error if ajax request fails. BUG= 606611 Review-Url: https://codereview.chromium.org/1922983002 [modify] https://crrev.com/aa64dd6b521a466a8a5ab68a982703ee13bf9c25/appengine/sheriff_o_matic/model/ct-failure-group.html [modify] https://crrev.com/aa64dd6b521a466a8a5ab68a982703ee13bf9c25/appengine/sheriff_o_matic/ui/ct-failure-card-buttons.html
,
May 2 2016
Current behavior is fixed. Not sure if we want logging in to be required for adding annotations though.... Default of requiring is ok for now I think, but I'd be ok with opening it up to not have login. Sheriffs will need to be logged in in the future, to access internal alerts. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by pgervais@chromium.org
, Apr 26 2016