Implement a mechanism to signal that an origin has reached a certain amount of Karma |
||||
Issue descriptionFor add to homescreen banners, it would be nice to be able to trigger the banner as soon as a site has accumulated sufficient Karma, rather than on a navigation or otherwise. If it can be done without too much overhead, we should implement some sort of callback mechanism that allows clients to register a callback and an engagement (score/level) for that callback to be triggered at.
,
Jun 8 2016
,
Jun 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1dc78e80fe37a7afc9b68f07d53ec09a2179e2f9 commit 1dc78e80fe37a7afc9b68f07d53ec09a2179e2f9 Author: dominickn <dominickn@chromium.org> Date: Wed Jun 22 04:17:45 2016 Implement an observer interface for the site engagement service. This CL adds the ability for site engagement service clients to register an observer on the site engagement service. The observer's OnEngagementIncreased method is called every time engagement is increased for a URL. The WebContents from which the increase was triggered and the visible/hidden state of that WebContents is also passed through to the observer. BUG= 606590 Review-Url: https://codereview.chromium.org/1986033002 Cr-Commit-Position: refs/heads/master@{#401206} [add] https://crrev.com/1dc78e80fe37a7afc9b68f07d53ec09a2179e2f9/chrome/browser/engagement/site_engagement_observer.cc [add] https://crrev.com/1dc78e80fe37a7afc9b68f07d53ec09a2179e2f9/chrome/browser/engagement/site_engagement_observer.h [modify] https://crrev.com/1dc78e80fe37a7afc9b68f07d53ec09a2179e2f9/chrome/browser/engagement/site_engagement_score.h [modify] https://crrev.com/1dc78e80fe37a7afc9b68f07d53ec09a2179e2f9/chrome/browser/engagement/site_engagement_service.cc [modify] https://crrev.com/1dc78e80fe37a7afc9b68f07d53ec09a2179e2f9/chrome/browser/engagement/site_engagement_service.h [modify] https://crrev.com/1dc78e80fe37a7afc9b68f07d53ec09a2179e2f9/chrome/browser/engagement/site_engagement_service_unittest.cc [modify] https://crrev.com/1dc78e80fe37a7afc9b68f07d53ec09a2179e2f9/chrome/chrome_browser.gypi
,
Jun 29 2016
,
Dec 9 2016
Security>UX component is deprecated in favor of the Team-Security-UX label |
||||
►
Sign in to add a comment |
||||
Comment 1 by dominickn@chromium.org
, Jun 1 2016