Build warnings: ninja: warning: multiple rules generate [*v8*] |
|||||||
Issue descriptionI'm at tip-of-tree (19089564c7e5bb74ebb60c624e45d94d7f0aefbc) and building on OSX10.11.4 with goma. I'm seeing a bunch of console spam when building: Example: ninja: warning: multiple rules generate obj/v8/src/x64/v8_base.builtins-x64.o. builds involving this target will not be correct; continuing anyway [-w dupbuild=warn] ninja: warning: multiple rules generate obj/v8/src/x64/v8_base.code-stubs-x64.o. builds involving this target will not be correct; continuing anyway [-w dupbuild=warn] ninja: warning: multiple rules generate obj/v8/src/x64/v8_base.codegen-x64.o. builds involving this target will not be correct; continuing anyway [-w dupbuild=warn] ninja: warning: multiple rules generate obj/v8/src/x64/v8_base.cpu-x64.o. builds involving this target will not be correct; continuing anyway [-w dupbuild=warn] ninja: warning: multiple rules generate obj/v8/src/x64/v8_base.deoptimizer-x64.o. builds involving this target will not be correct; continuing anyway [-w dupbuild=warn] ninja: warning: multiple rules generate obj/v8/src/x64/v8_base.disasm-x64.o. builds involving this target will not be correct; continuing anyway [-w dupbuild=warn] ninja: warning: multiple rules generate obj/v8/src/x64/v8_base.frames-x64.o. builds involving this target will not be correct; continuing anyway [-w dupbuild=warn] Esprehn is also seeing this, so it's not local to me. I have re-run gclient sync and have removed my out directory without much luck. I think we pushed a bad config for v8. I've cc'ed folks who might have an idea about what's going on.
,
Apr 25 2016
Yup, I think we should at least revert the roll into chromium.
,
Apr 26 2016
We have to move a gyp file in V8 to prepare for gn. The embedder configs still point to the old file while somehow indirectly they seem to also include the new one. I think the warning is benign because the two gyp files are equal. Since you didn't revert, I'd go ahead and rewire the embedder configs to the new file.
,
Apr 26 2016
,
Apr 26 2016
The new v8.gyp file is referenced only by d8.gyp and fuzzer.gyp.
,
Apr 26 2016
And of course FYI: You should only see these warnings if you build with gyp not gn.
,
Apr 26 2016
Chrome depends on d8, so I guess that's where the duplication is introduced
,
Apr 26 2016
I'll prep two CLs for chromium and for pdfium to update to the new locations to fix this.
,
Apr 26 2016
The following revision refers to this bug: https://pdfium.googlesource.com/pdfium.git/+/3081cc07898dd19a0a00d406ac3555c111940dce commit 3081cc07898dd19a0a00d406ac3555c111940dce Author: machenbach <machenbach@chromium.org> Date: Tue Apr 26 10:12:36 2016 Roll v8 to 0ff89ea7 and update gyp references Contents: https://chromium.googlesource.com/v8/v8/+log/47bcec78..0ff89ea75 BUG= chromium:606547 Review URL: https://codereview.chromium.org/1920863003 [modify] https://crrev.com/3081cc07898dd19a0a00d406ac3555c111940dce/DEPS [modify] https://crrev.com/3081cc07898dd19a0a00d406ac3555c111940dce/pdfium.gyp [modify] https://crrev.com/3081cc07898dd19a0a00d406ac3555c111940dce/samples/samples.gyp [modify] https://crrev.com/3081cc07898dd19a0a00d406ac3555c111940dce/xfa.gyp
,
Apr 26 2016
,
Apr 26 2016
CC'ing today's chromium tree sheriffs. The fix for this is comprised of the following two CLs: https://codereview.chromium.org/1923453003/ https://codereview.chromium.org/1923493002/ The warnings will go away once both have landed. In case v8 needs to be reverted beyond 5.2.126 aka https://chromium.googlesource.com/v8/v8/+/d90dcc50937359946914b3493f8e03b87cd75fdc, those two CLs must be reverted too. Right now v8 is already at 5.2.136 and stayed at 5.2.129 for a while, so this is unlikely. In case v8 needs to get reverted on the current canary only (2717) the same two CLs must be reverted for the canary too. We'll check later how the canary looks before landing the CLs, in order to make this unlikely, too.
,
Apr 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65639bcd2b4a2eb9578988651bf64c42761102c1 commit 65639bcd2b4a2eb9578988651bf64c42761102c1 Author: machenbach <machenbach@chromium.org> Date: Tue Apr 26 12:51:41 2016 Roll src/third_party/pdfium 0f6425f:3081cc0 Summary of changes available at: https://pdfium.googlesource.com/pdfium/+log/0f6425f..3081cc0 BUG= 606547 TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/1923493002 Cr-Commit-Position: refs/heads/master@{#389759} [modify] https://crrev.com/65639bcd2b4a2eb9578988651bf64c42761102c1/DEPS
,
Apr 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60b9aa2bbf35e9855499d9aec11cbbab43387044 commit 60b9aa2bbf35e9855499d9aec11cbbab43387044 Author: machenbach <machenbach@chromium.org> Date: Tue Apr 26 12:52:26 2016 [build] Switch to moved v8.gyp BUG= 474921 , 606547 TBR=torne@chromium.org,alokp@chromium.org,jamescook@chromium.org,amistry@chromium.org,davidben@chromium.org Review URL: https://codereview.chromium.org/1923453003 Cr-Commit-Position: refs/heads/master@{#389760} [modify] https://crrev.com/60b9aa2bbf35e9855499d9aec11cbbab43387044/android_webview/android_webview.gyp [modify] https://crrev.com/60b9aa2bbf35e9855499d9aec11cbbab43387044/build/all.gyp [modify] https://crrev.com/60b9aa2bbf35e9855499d9aec11cbbab43387044/build/gn_migration.gypi [modify] https://crrev.com/60b9aa2bbf35e9855499d9aec11cbbab43387044/build/linux/unbundle/replace_gyp_files.py [modify] https://crrev.com/60b9aa2bbf35e9855499d9aec11cbbab43387044/chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi [modify] https://crrev.com/60b9aa2bbf35e9855499d9aec11cbbab43387044/chrome/chrome_browser.gypi [modify] https://crrev.com/60b9aa2bbf35e9855499d9aec11cbbab43387044/chrome/chrome_browser_chromeos.gypi [modify] https://crrev.com/60b9aa2bbf35e9855499d9aec11cbbab43387044/chrome/chrome_browser_ui.gypi [modify] https://crrev.com/60b9aa2bbf35e9855499d9aec11cbbab43387044/chrome/chrome_tests.gypi [modify] https://crrev.com/60b9aa2bbf35e9855499d9aec11cbbab43387044/chrome/chrome_tests_unit.gypi [modify] https://crrev.com/60b9aa2bbf35e9855499d9aec11cbbab43387044/chromecast/chromecast.gyp [modify] https://crrev.com/60b9aa2bbf35e9855499d9aec11cbbab43387044/components/guest_view.gypi [modify] https://crrev.com/60b9aa2bbf35e9855499d9aec11cbbab43387044/components/pdf.gypi [modify] https://crrev.com/60b9aa2bbf35e9855499d9aec11cbbab43387044/components/plugins.gypi [modify] https://crrev.com/60b9aa2bbf35e9855499d9aec11cbbab43387044/components/test_runner/test_runner.gyp [modify] https://crrev.com/60b9aa2bbf35e9855499d9aec11cbbab43387044/components/translate.gypi [modify] https://crrev.com/60b9aa2bbf35e9855499d9aec11cbbab43387044/content/content.gyp [modify] https://crrev.com/60b9aa2bbf35e9855499d9aec11cbbab43387044/content/content_renderer.gypi [modify] https://crrev.com/60b9aa2bbf35e9855499d9aec11cbbab43387044/content/content_shell.gypi [modify] https://crrev.com/60b9aa2bbf35e9855499d9aec11cbbab43387044/content/content_tests.gypi [modify] https://crrev.com/60b9aa2bbf35e9855499d9aec11cbbab43387044/extensions/shell/app_shell.gyp [modify] https://crrev.com/60b9aa2bbf35e9855499d9aec11cbbab43387044/gin/gin.gyp [modify] https://crrev.com/60b9aa2bbf35e9855499d9aec11cbbab43387044/mojo/mojo_edk.gyp [modify] https://crrev.com/60b9aa2bbf35e9855499d9aec11cbbab43387044/net/net.gyp [modify] https://crrev.com/60b9aa2bbf35e9855499d9aec11cbbab43387044/third_party/WebKit/Source/core/core.gyp [modify] https://crrev.com/60b9aa2bbf35e9855499d9aec11cbbab43387044/third_party/WebKit/Source/modules/modules.gyp [modify] https://crrev.com/60b9aa2bbf35e9855499d9aec11cbbab43387044/third_party/WebKit/Source/platform/blink_platform.gyp [modify] https://crrev.com/60b9aa2bbf35e9855499d9aec11cbbab43387044/third_party/WebKit/Source/platform/blink_platform_tests.gyp [modify] https://crrev.com/60b9aa2bbf35e9855499d9aec11cbbab43387044/third_party/WebKit/Source/web/web.gyp [modify] https://crrev.com/60b9aa2bbf35e9855499d9aec11cbbab43387044/third_party/WebKit/Source/web/web_tests.gyp
,
Apr 26 2016
Fixed by the two commits above.
,
Aug 7 2016
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by adamk@chromium.org
, Apr 25 2016