New issue
Advanced search Search tips

Issue 606515 link

Starred by 1 user

Issue metadata

Status: Verified
Owner: ----
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

CHECK failed: !textDecorationsInEffect || !textDecoration in EditingStyle.cpp

Project Member Reported by ClusterFuzz, Apr 25 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4958256165814272

Fuzzer: mbarbella_js_mutation_layout
Job Type: linux_debug_content_shell_drt
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  CHECK failed: !textDecorationsInEffect || !textDecoration in EditingStyle.cpp
  blink::reconcileTextDecorationProperties
  blink::StyleChange::StyleChange
  

Minimized Testcase (0.24 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv97H56UPzdE4pWnb17LUQXXVGQ7SX-cIKdDFGDYhqvlHmhUNZID3fwEKuVYXUDJfLxzsfrkgEyINztmQ-Y7j6U2zlCcVyg1GdGZijfHPWUG5C4DASWoULjoF1zXLXOBygW_6sN1lI_h7YIPcSLcUdP6_RUdvag
        Female
  <dl>
    DT element
  </dl>
  <br/>
  <hr/>
  <script>
    document.designMode = 'on';
    document.execCommand('SelectAll');
    document.execCommand('Strikethrough');
    document.execCommand('InsertOrderedList');
</script>


Filer: manoranjanr

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: tkent@chromium.org
Components: Blink>Architecture Tools>Test>FindIt>NoResult
Labels: Te-Logged
Owner: koten...@yandex-team.ru
Status: Assigned (was: Available)
kotenkov@, could you please look into this change (https://chromium.googlesource.com/chromium/src/+/4021ae18b9410d496adc92077e00672253f3876d%5E%21/third_party/WebKit/Source/core/editing/EditingStyle.cpp) if possible?

Thank you!

Comment 2 by tkent@chromium.org, Apr 25 2016

Components: -Blink>Architecture Blink>Editing
Owner: ----
Status: Untriaged (was: Assigned)
Route to Editing triage

It seems that the patch is ok -- I cannot see any errors in these ASSERT -> DCHECK conversion. I'll investigate the failures further today.

Comment 4 by tkent@chromium.org, Apr 26 2016

Cc: -tkent@chromium.org

Comment 5 by yosin@chromium.org, Apr 26 2016

Labels: -OS-Linux -Pri-1 OS-All Pri-2
Status: Available (was: Untriaged)
Lower to Pri-2, since real world usage of InsertOrderedList is low.
All three issues ( crbug.com/606517  and  crbug.com/606535  included) are genuine, not duplicates of each other and have nothing to do with ASSERT -> DCHECK change.
Project Member

Comment 7 by ClusterFuzz, Sep 24 2016

ClusterFuzz has detected this issue as fixed in range 403853:403869.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4958256165814272

Fuzzer: mbarbella_js_mutation_layout
Job Type: linux_debug_content_shell_drt
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !textDecorationsInEffect || !textDecoration in EditingStyle.cpp
  blink::reconcileTextDecorationProperties
  blink::StyleChange::StyleChange
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_debug_content_shell_drt&range=268656:269696
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_debug_content_shell_drt&range=403853:403869

Minimized Testcase (0.24 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv9464PJuUnO5qmN6sXRN4WjuQSmxDbjyLuoFElYdJ4HZQRl1eZV_WHQYrv0Cq775eZX7G8oTDBCttVfeEnL9cwwQA2DrqxrKYL2V3vPsU-ZI-LuJCLoB8gjRyF5_JnTTDJSeI3KRks2CZts0BOjMsmMQ6Jit7Q?testcase_id=4958256165814272
        Female
  <dl>
    DT element
  </dl>
  <br/>
  <hr/>
  <script>
    document.designMode = 'on';
    document.execCommand('SelectAll');
    document.execCommand('Strikethrough');
    document.execCommand('InsertOrderedList');
</script>


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Sep 24 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Available)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Components: -Tools>Test>FindIt>NoResult
Project Member

Comment 10 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment