Full-screen and two displays: toolbar is sliding down when it shouldn't |
|||||||
Issue descriptionChrome Version : 50.0.2661.75, 50.0.2661.86 OS Version: OS X 10.11.4 URLs (if applicable) : n/a Other browsers tested: n/a What steps will reproduce the problem? 1. Hardware required: two displays (e.g. laptop and external display), which I shall arbitrarily number 1 and 2. 2. On Display 1, have a full-screen Chrome window (OSX full screen with toolbar/tabs visible). 3. On Display 2, have a normal desktop with at least one window on it. 4. Click to switch focus between the full-screen Chrome window and anything on Display 2. What is the expected result? Nothing in particular happens other than the usual focus cue color/brightness changes. What happens instead of that? When the fullscreen Chrome window has focus, it is normal, but when a non-fullscreen window has focus, the fullscreen Chrome window has a stripe of blank space at the top and the tabs and toolbar move down. The toolbar covers part of the web page and the page cannot be scrolled to change that. This is reminiscent of the behavior when the cursor is moved to the top and the menu bar appears in full screen mode, but there is no menu bar (of course) and no sliding animation. Please provide any additional information below. Attach a screenshot if possible. • This does not happen if the other window having focus is itself a full-screen window. • This is is a new behavior, as in, the last couple of updates. I am seeing it on two different machines. • If focus changes are not done by clicking between the two displays but by using the trackpad three-finger swipe gesture between fullscreen and regular desktop on Display 2, then the blank space does not appear immediately, but will once some click a window causes a switch to a different application on Display 2. • A _possibly_ related thing that changed in a similar time frame: The panels/moles feature (as used by the Hangouts extension) has changed its behavior. If I remember correctly, it used to be that all panels on all displays are hidden whenever any display is showing a full-screen window. (Not great behavior in itself, but consistent.) Now, panels are hidden or shown according to the last switch (3-finger swipe) to or away from full-screen, meaning that if a switch occurs on a different display than has the panels then you can end up with panels on top of fullscreen, or no panels on a desktop. UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.86 Safari/537.36
,
Apr 28 2016
,
Apr 28 2016
Chrome Version : 50.0.2661.94 OS version : 10.11.2 (15C50) Behavior in Safari 9.0.2 (11601.3.9): Behaves normally, issue not present Behavior in Firefox 45.0.2: Behaves normally, issue not present As originally reported, this has only happened with a recent update of chrome (I cannot identify which). Before the last update it worked without suffering from this issue. The attached gif demonstrates the issue. I have two monitors set up. I fullscreen chrome on my lower monitor, move the cursor to the upper monitor, click to focus on a non-fullscreen window on the upper monitor and the blank toolbar appears.
,
May 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bde4e511c9b163ae0f2926a12834485cf9f6e996 commit bde4e511c9b163ae0f2926a12834485cf9f6e996 Author: spqchan <spqchan@chromium.org> Date: Fri May 13 21:09:38 2016 Fix for Fullscreen toolbar with multiple monitors on OSX When checking for the active window during the menubar dropdown progress, use the isMainWindow property instead of onActiveSpace. If we have multiple monitors, onActiveSpace can return true, even if the window isn't active. BUG= 606511 Review-Url: https://codereview.chromium.org/1979663002 Cr-Commit-Position: refs/heads/master@{#393642} [modify] https://crrev.com/bde4e511c9b163ae0f2926a12834485cf9f6e996/chrome/browser/ui/cocoa/presentation_mode_controller.h [modify] https://crrev.com/bde4e511c9b163ae0f2926a12834485cf9f6e996/chrome/browser/ui/cocoa/presentation_mode_controller.mm
,
May 13 2016
,
May 14 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
May 16 2016
,
May 16 2016
Please merge your change to M51 branch 2704 before 5:00 PM PST today (Monday) so we can take it for this week beta release. Thank you.
,
May 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ce0183043107443e995b20de48fdc6bf4381821 commit 7ce0183043107443e995b20de48fdc6bf4381821 Author: spqchan <spqchan@chromium.org> Date: Mon May 16 16:58:57 2016 Fix for Fullscreen toolbar with multiple monitors on OSX When checking for the active window during the menubar dropdown progress, use the isMainWindow property instead of onActiveSpace. If we have multiple monitors, onActiveSpace can return true, even if the window isn't active. BUG= 606511 Review-Url: https://codereview.chromium.org/1979663002 Cr-Commit-Position: refs/heads/master@{#393642} (cherry picked from commit bde4e511c9b163ae0f2926a12834485cf9f6e996) Review URL: https://codereview.chromium.org/1983903002 . Cr-Commit-Position: refs/branch-heads/2704@{#556} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/7ce0183043107443e995b20de48fdc6bf4381821/chrome/browser/ui/cocoa/presentation_mode_controller.h [modify] https://crrev.com/7ce0183043107443e995b20de48fdc6bf4381821/chrome/browser/ui/cocoa/presentation_mode_controller.mm
,
May 16 2016
,
May 18 2016
Tested the issue on dual monitor(Mac OS X, normal desktop) using 51.0.2704.54 as per steps in comment #0 and its working fine. Marking it as TE-Verified.
,
May 21 2016
This issue still occurs with the following steps: 1. Enter full screen mode on 2nd monitor. 2. Click on desktop on 1st monitor. 3. Click on chrome content (2nd monitor full screen). 4. Click on desktop on 1st monitor. The issue only occurs when clicking on the desktop on 1st monitor, no issue with clicking on another running application window. And the issue only appears when the desktop is clicked 2+ times. The issue is not always reproducible when clicking on the chrome header instead of the content window. Observed on Version 53.0.2744.0 canary (64-bit)
,
May 23 2016
Issue 604270 has been merged into this issue.
,
May 23 2016
Created Issue 614137 for #12
,
May 25 2016
The bar is still visible for a short time (< 1 sec), when switching to fullscreen, then it disappears and works ok. Version 51.0.2704.63 (64-bit) |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by patricia...@chromium.org
, Apr 28 2016Components: UI>Browser>FullScreen
Labels: allpublic
Status: Untriaged (was: Unconfirmed)