Issue metadata
Sign in to add a comment
|
Component extension not enabled for incognito |
||||||||||||||||||||||
Issue descriptionVersion: 52.0.2715.0 canary (64-bit) OS: Mac OS X 10.11, possibly all What steps will reproduce the problem? (1) Visit a youtube.com video in an incognito window with Media Router enabled (chrome://flags#media-router) and a Cast device on the network (2) Note that no Cast icon appears What is the expected output? Cast SDK is loaded and icon appears in player to enable casting from youtube.com What do you see instead? - No cast icon on youtube.com - JS console errors loading the Cast SDK from the MR component extension chrome-extension://enhhojjnijigcajfphajepfemndkmdlo/cast_sender.js Failed to load resource: net::ERR_ADDRESS_UNREACHABLE Failed to load resource: net::ERR_ADDRESS_UNREACHABLE chrome-extension://fmfcbgogabcbclcofgocippekhfcmgfj/cast_sender.js Failed to load resource: net::ERR_ADDRESS_UNREACHABLE - "Allow in incognito" is not checked for MR component in chrome://extensions/ when chrome is started with --enable-component-extension-options benwells@ - patch https://chromium.googlesource.com/chromium/src/+/604a2ac93c3427d614e100a699e16567dae14ef9 recently refactored behavior around incognito in extension_util.cc. can you PTAL
,
Apr 25 2016
,
Apr 26 2016
That CL just added null checks, and apart from stopping very infrequent crashes should have no other effect (unless I stuffed up the review) Has anyone bisected? +Devlin as extensions TL
,
Apr 26 2016
+David David, can you see if this reproduces before/after revision 387565? I'm not sure how to map that to a Canary revision. I can try to bisect myself, but won't get to it today.
,
Apr 29 2016
Switching to assigned to get this out of triage.
,
Apr 29 2016
Starting with --show-component-extension-options and manually enabling incognito fixes it, but I'm pretty sure this was working OOB in Chrome 49.
,
Apr 29 2016
,
May 4 2016
I'm having some trouble bisecting this. unless it's not needed, I'll continue to work on it.
,
May 10 2016
David, any luck narrowing down a build? Otherwise I'll have to dig in with a debugger when this gets to the top of my queue.
,
May 11 2016
No, sorry, not yet.
,
May 12 2016
,
May 20 2016
Patch up with a fix. The UX is still trying to render the extensionview in incognito (which is a different issue from this one) and needs debugging further.
,
May 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4193cc61735abc6d53edb85021222d5e866c2c6d commit 4193cc61735abc6d53edb85021222d5e866c2c6d Author: mfoltz <mfoltz@chromium.org> Date: Wed May 25 00:55:56 2016 Enables EXTERNAL_COMPONENT extensions in incognito by default. Currently, the Media Router is in a broken state in incognito: it can talk to the component via the Mojo API, but access to resources (like the Cast SDK, feedbak, and setup) and tab capture is broken. This enables the component in incognito via the extensions system which resolves these issues. BUG= 606495 Review-Url: https://codereview.chromium.org/1991263003 Cr-Commit-Position: refs/heads/master@{#395758} [modify] https://crrev.com/4193cc61735abc6d53edb85021222d5e866c2c6d/chrome/browser/extensions/extension_util.cc
,
May 25 2016
,
May 26 2016
Verified on Windows Canary 53.0.2749.0. Tab mirroring and Cast SDK work as expected in incognito.
,
May 26 2016
,
May 26 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
May 26 2016
Please have a the CL merged by EOD tomorrow (05/27), so it gets tested for dev channel scheduled on 06/02.
,
May 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f9a72e8b1774a4eba32c2eb9adb6fe10479c2bf commit 4f9a72e8b1774a4eba32c2eb9adb6fe10479c2bf Author: mark a. foltz <mfoltz@chromium.org> Date: Thu May 26 22:37:25 2016 Enables EXTERNAL_COMPONENT extensions in incognito by default. Currently, the Media Router is in a broken state in incognito: it can talk to the component via the Mojo API, but access to resources (like the Cast SDK, feedbak, and setup) and tab capture is broken. This enables the component in incognito via the extensions system which resolves these issues. BUG= 606495 Review-Url: https://codereview.chromium.org/1991263003 Cr-Commit-Position: refs/heads/master@{#395758} (cherry picked from commit 4193cc61735abc6d53edb85021222d5e866c2c6d) Review URL: https://codereview.chromium.org/2010273002 . Cr-Commit-Position: refs/branch-heads/2743@{#90} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/4f9a72e8b1774a4eba32c2eb9adb6fe10479c2bf/chrome/browser/extensions/extension_util.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mfo...@chromium.org
, Apr 25 2016