New issue
Advanced search Search tips

Issue 606491 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 595152
issue 595155



Sign in to add a comment

Leaks detected in intersection-observer/edge-inclusive-intersection.html

Project Member Reported by creis@chromium.org, Apr 25 2016

Issue description

intersection-observer/edge-inclusive-intersection.html was added in https://codereview.chromium.org/1826323002 one month ago, and it appears to be causing flaky leaks on the WebKit Linux Leak bot:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/19050
Red, currently listed on https://sheriff-o-matic.appspot.com/chromium:
14:03:34.909 10063 worker/3 intersection-observer/edge-inclusive-intersection.html leaked
14:03:34.909 10063   Xlib:  extension "RANDR" missing on display ":9".
14:03:34.910 10063   Xlib:  extension "RANDR" missing on display ":9".
14:03:34.911 9999 [34498/40423] intersection-observer/edge-inclusive-intersection.html failed unexpectedly (leak detected: ({"numberOfLiveActiveDOMObjects":[2,3]}))
14:03:34.910 10063 worker/3 intersection-observer/edge-inclusive-intersection.html failed:
14:03:34.910 10063 worker/3  leak detected: ({"numberOfLiveActiveDOMObjects":[2,3]})


https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/18997
Green, but leak is in the stdio:
18:06:16.673 18663 worker/4 intersection-observer/edge-inclusive-intersection.html leaked
18:06:16.673 18663   Xlib:  extension "RANDR" missing on display ":9".
18:06:16.673 18663   Xlib:  extension "RANDR" missing on display ":9".
18:06:16.674 18597 [34464/40412] intersection-observer/edge-inclusive-intersection.html failed unexpectedly (leak detected: ({"numberOfLiveActiveDOMObjects":[2,3]}))
18:06:16.674 18663 worker/4 intersection-observer/edge-inclusive-intersection.html failed:
18:06:16.674 18663 worker/4  leak detected: ({"numberOfLiveActiveDOMObjects":[2,3]})

szager: Could you take a look?  Apologies that I don't know the right component to label this.
 

Comment 1 by jianli@chromium.org, Apr 25 2016

Components: -Blink Blink>LayoutTests

Comment 2 by szager@chromium.org, Apr 25 2016

This is a manifestation of  crbug.com/595155 , and it's not a real leak.  The errors should go away once this lands:

https://codereview.chromium.org/1866903002/

Comment 3 by treib@chromium.org, Apr 26 2016

Blockedon: 595155

Comment 5 by engedy@chromium.org, Apr 27 2016

Blockedon: 595152

Comment 6 by szager@chromium.org, Apr 27 2016

The intersection-observer tests are all listed in LeakExpectations; shouldn't that suppress these errors?
Does anyone know the answer my question in comment #6?  If the tests are in LeakExpectations, shouldn't that suppress these errors?
Should be easy enough for you to look that up, https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/LayoutTests/LeakExpectations&q=LeakExpectations&sq=package:chromium&type=cs

edge-inclusive-intersection.html isn't listed there.
Project Member

Comment 10 by bugdroid1@chromium.org, May 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d5b2c50f27390a27d66b241c55b9e6fbb861e43

commit 9d5b2c50f27390a27d66b241c55b9e6fbb861e43
Author: treib <treib@chromium.org>
Date: Fri May 06 13:39:19 2016

Mark intersection-observer/edge-inclusive-intersection as leaky

BUG= 606491 
TBR=szager@chromium.org

Review-Url: https://codereview.chromium.org/1954043002
Cr-Commit-Position: refs/heads/master@{#392046}

[modify] https://crrev.com/9d5b2c50f27390a27d66b241c55b9e6fbb861e43/third_party/WebKit/LayoutTests/LeakExpectations

Labels: Test-Layout
Components: -Blink>LayoutTests Blink
Deprecating component:Blink>LayoutTests, to use label Test=Layout instead. Merging these to component:Blink for the Blink rotation to pick up and re-triage as appropriate. 
Project Member

Comment 13 by bugdroid1@chromium.org, May 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/923374c640e686109bf0bbfe917fa95f66f0d00a

commit 923374c640e686109bf0bbfe917fa95f66f0d00a
Author: szager <szager@chromium.org>
Date: Thu May 19 08:06:40 2016

Convert IntersectionObserver tests to use testRunner.runIdleTasks.

BUG= 606491 
R=ojan@chromium.org,skyostil@chromium.org

Review-Url: https://codereview.chromium.org/1983383002
Cr-Commit-Position: refs/heads/master@{#394711}

[modify] https://crrev.com/923374c640e686109bf0bbfe917fa95f66f0d00a/third_party/WebKit/LayoutTests/LeakExpectations
[modify] https://crrev.com/923374c640e686109bf0bbfe917fa95f66f0d00a/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/923374c640e686109bf0bbfe917fa95f66f0d00a/third_party/WebKit/LayoutTests/http/tests/intersection-observer/iframe-cross-origin.html
[modify] https://crrev.com/923374c640e686109bf0bbfe917fa95f66f0d00a/third_party/WebKit/LayoutTests/http/tests/intersection-observer/resources/cross-origin-subframe.html
[delete] https://crrev.com/07efd22b4df4af03fb04c4a684fda852cee32a73/third_party/WebKit/LayoutTests/http/tests/intersection-observer/resources/helper-functions.js
[modify] https://crrev.com/923374c640e686109bf0bbfe917fa95f66f0d00a/third_party/WebKit/LayoutTests/intersection-observer/containing-block.html
[modify] https://crrev.com/923374c640e686109bf0bbfe917fa95f66f0d00a/third_party/WebKit/LayoutTests/intersection-observer/edge-inclusive-intersection.html
[delete] https://crrev.com/07efd22b4df4af03fb04c4a684fda852cee32a73/third_party/WebKit/LayoutTests/intersection-observer/helper-functions.js
[modify] https://crrev.com/923374c640e686109bf0bbfe917fa95f66f0d00a/third_party/WebKit/LayoutTests/intersection-observer/iframe-no-root.html
[modify] https://crrev.com/923374c640e686109bf0bbfe917fa95f66f0d00a/third_party/WebKit/LayoutTests/intersection-observer/multiple-thresholds.html
[modify] https://crrev.com/923374c640e686109bf0bbfe917fa95f66f0d00a/third_party/WebKit/LayoutTests/intersection-observer/observer-without-js-reference.html
[modify] https://crrev.com/923374c640e686109bf0bbfe917fa95f66f0d00a/third_party/WebKit/LayoutTests/intersection-observer/remove-element.html
[modify] https://crrev.com/923374c640e686109bf0bbfe917fa95f66f0d00a/third_party/WebKit/LayoutTests/intersection-observer/root-margin.html
[modify] https://crrev.com/923374c640e686109bf0bbfe917fa95f66f0d00a/third_party/WebKit/LayoutTests/intersection-observer/same-document-no-root.html
[modify] https://crrev.com/923374c640e686109bf0bbfe917fa95f66f0d00a/third_party/WebKit/LayoutTests/intersection-observer/same-document-root.html
[modify] https://crrev.com/923374c640e686109bf0bbfe917fa95f66f0d00a/third_party/WebKit/LayoutTests/intersection-observer/same-document-zero-size-target.html
[modify] https://crrev.com/923374c640e686109bf0bbfe917fa95f66f0d00a/third_party/WebKit/LayoutTests/intersection-observer/timestamp-expected.txt
[modify] https://crrev.com/923374c640e686109bf0bbfe917fa95f66f0d00a/third_party/WebKit/LayoutTests/intersection-observer/timestamp.html
[modify] https://crrev.com/923374c640e686109bf0bbfe917fa95f66f0d00a/third_party/WebKit/LayoutTests/intersection-observer/unclipped-root.html
[add] https://crrev.com/923374c640e686109bf0bbfe917fa95f66f0d00a/third_party/WebKit/LayoutTests/resources/intersection-observer-helper-functions.js

Components: -Blink Blink>Layout
Status: Fixed (was: Assigned)

Sign in to add a comment