OS/Meta keys not sent to host using Chrome Canary. |
|||||||
Issue descriptionVersion: M52 What steps will reproduce the problem? (1) Run Chrome Canary. (2) Open Chromoting and connect to a host. (3) Press the left or right OS/Meta (Windows or Cmd) key. What is the expected output? Host receives the keypress. What do you see instead? Nothing happens on the host. Previous versions of Chrome handle this key correctly. If you use the key test app, it does receive a key event in both cases, but the details are different--OSLeft prior to M52; MetaLeft in M52+
,
Apr 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/821b64a7c91900617e4190644052fac8afe54a07 commit 821b64a7c91900617e4190644052fac8afe54a07 Author: jamiewalch <jamiewalch@chromium.org> Date: Mon Apr 25 22:24:17 2016 Work around key lookup table version mismatch. Discrepancies between the version of the key lookup table used by Chrome and the one against which the PNaCl plugin is compiled cause keys to go missing in Chromoting. This CL is a quick fix for one recent regression--the longer term fix is to move away from using PPAPI for keyboard events. BUG= 606457 Review URL: https://codereview.chromium.org/1920033003 Cr-Commit-Position: refs/heads/master@{#389587} [modify] https://crrev.com/821b64a7c91900617e4190644052fac8afe54a07/remoting/client/plugin/pepper_input_handler.cc
,
Apr 25 2016
Requesting merge to M51. This change only affects Chrome Remote Desktop; there are no changes to Chrome browser.
,
Apr 25 2016
Note that the merge will need to reverse the order of the strings, since the M51 branch is built against the older version of the lookup table.
,
Apr 26 2016
,
Apr 26 2016
,
Apr 26 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
Apr 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c99249ba0adca880b8d4368f313a5508167a1b0 commit 9c99249ba0adca880b8d4368f313a5508167a1b0 Author: Jamie Walch <jamiewalch@chromium.org> Date: Tue Apr 26 22:34:43 2016 Merge https://codereview.chromium.org/1920033003. Work around key lookup table version mismatch. Discrepancies between the version of the key lookup table used by Chrome and the one against which the PNaCl plugin is compiled cause keys to go missing in Chromoting. This CL is a quick fix for one recent regression--the longer term fix is to move away from using PPAPI for keyboard events. BUG= 606457 Review URL: https://codereview.chromium.org/1920033003 Cr-Commit-Position: refs/heads/master@{#389587} (cherry picked from commit 821b64a7c91900617e4190644052fac8afe54a07) R=garykac@chromium.org Review URL: https://codereview.chromium.org/1915243004 . Cr-Commit-Position: refs/branch-heads/2704@{#256} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/9c99249ba0adca880b8d4368f313a5508167a1b0/remoting/client/plugin/pepper_input_handler.cc
,
Apr 29 2016
Verified bug exists in release web app 51.0.2704.7 in Canary and that the issue no longer occurs in latest ToT web app 52.0.2719.0 |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by w...@chromium.org
, Apr 25 2016