New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 606448 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Breakpad dump attempts metric code is abandoned

Project Member Reported by siggi@chromium.org, Apr 25 2016

Issue description

OS: Windows

The CrashReport.BreakpadCrashDumpOutcome is orphaned with CrashPad taking over.
 

Comment 1 by siggi@chromium.org, Apr 25 2016

Labels: Hotlist-TechnicalDebt
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f34a7582f1cf5cedbeab414d9629d524303cc574

commit f34a7582f1cf5cedbeab414d9629d524303cc574
Author: siggi <siggi@chromium.org>
Date: Wed Apr 27 20:04:59 2016

Scrub the vestigial breakpad crash dump attempts metrics code.

BUG= 606448 

Review-Url: https://codereview.chromium.org/1922473003
Cr-Commit-Position: refs/heads/master@{#390161}

[modify] https://crrev.com/f34a7582f1cf5cedbeab414d9629d524303cc574/chrome/app/chrome_crash_reporter_client_win.cc
[modify] https://crrev.com/f34a7582f1cf5cedbeab414d9629d524303cc574/chrome/app/chrome_crash_reporter_client_win.h
[modify] https://crrev.com/f34a7582f1cf5cedbeab414d9629d524303cc574/chrome/browser/metrics/chrome_stability_metrics_provider.cc
[modify] https://crrev.com/f34a7582f1cf5cedbeab414d9629d524303cc574/chrome/common/metrics_constants_util_win.cc
[modify] https://crrev.com/f34a7582f1cf5cedbeab414d9629d524303cc574/chrome/common/metrics_constants_util_win.h
[modify] https://crrev.com/f34a7582f1cf5cedbeab414d9629d524303cc574/chrome/installer/setup/installer_crash_reporter_client.cc
[modify] https://crrev.com/f34a7582f1cf5cedbeab414d9629d524303cc574/chrome/installer/setup/installer_crash_reporter_client.h
[modify] https://crrev.com/f34a7582f1cf5cedbeab414d9629d524303cc574/components/browser_watcher.gypi
[modify] https://crrev.com/f34a7582f1cf5cedbeab414d9629d524303cc574/components/browser_watcher/BUILD.gn
[delete] https://crrev.com/10cd87645bc101283ca7f741977c68d9a1ac9644/components/browser_watcher/crash_reporting_metrics_win.cc
[delete] https://crrev.com/10cd87645bc101283ca7f741977c68d9a1ac9644/components/browser_watcher/crash_reporting_metrics_win.h
[delete] https://crrev.com/10cd87645bc101283ca7f741977c68d9a1ac9644/components/browser_watcher/crash_reporting_metrics_win_unittest.cc
[modify] https://crrev.com/f34a7582f1cf5cedbeab414d9629d524303cc574/components/components_tests.gyp
[modify] https://crrev.com/f34a7582f1cf5cedbeab414d9629d524303cc574/components/crash/content/app/breakpad_win.cc
[modify] https://crrev.com/f34a7582f1cf5cedbeab414d9629d524303cc574/components/crash/content/app/crash_reporter_client.cc
[modify] https://crrev.com/f34a7582f1cf5cedbeab414d9629d524303cc574/components/crash/content/app/crash_reporter_client.h
[modify] https://crrev.com/f34a7582f1cf5cedbeab414d9629d524303cc574/tools/metrics/histograms/histograms.xml

Comment 3 by siggi@chromium.org, Sep 6 2016

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77e77eb0235255724e0688102a26e64fd4b4482b

commit 77e77eb0235255724e0688102a26e64fd4b4482b
Author: grt <grt@chromium.org>
Date: Mon Mar 06 23:29:56 2017

Cleanups in the wake of various metrics refactorings.

- IWYU fixes in chrome_stability_metrics_provider.cc following r351036
  and r390161.
- Removal of chrome_watcher's depency on
  //chrome/common:metrics_constants_util_win (introduced accidentally in
  r387669).
- Removal of install_static::GetBrowserCrashDumpAttemptsRegistryPath
  (the need was removed in r390161, possibly while its addition was
  being reviewed).

BUG= 606448 
R=asvitkine@chromium.org,siggi@chromium.org

Review-Url: https://codereview.chromium.org/2730283002
Cr-Commit-Position: refs/heads/master@{#454997}

[modify] https://crrev.com/77e77eb0235255724e0688102a26e64fd4b4482b/chrome/browser/metrics/chrome_stability_metrics_provider.cc
[modify] https://crrev.com/77e77eb0235255724e0688102a26e64fd4b4482b/chrome/chrome_watcher/BUILD.gn
[modify] https://crrev.com/77e77eb0235255724e0688102a26e64fd4b4482b/chrome/install_static/install_util.cc
[modify] https://crrev.com/77e77eb0235255724e0688102a26e64fd4b4482b/chrome/install_static/install_util.h

Sign in to add a comment