We currently use std::string for sending UUIDs over mojo but now that mojo supports validation for custom data types we should use BluetoothUUID instead.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e491483f14621c2bf2587c2ccbf3905b57d5acac commit e491483f14621c2bf2587c2ccbf3905b57d5acac Author: ortuno <ortuno@chromium.org> Date: Fri Jun 10 20:15:07 2016 bluetooth: Use BluetoothUUID instead of string when sending uuids This patch introduces a Typemap from mojo::String to unique_ptr<device::BluetoothUUID>. Mapping to base::Optional allows us to have a nullable type. BUG= 606446 Review-Url: https://codereview.chromium.org/2015463004 Cr-Commit-Position: refs/heads/master@{#399259} [modify] https://crrev.com/e491483f14621c2bf2587c2ccbf3905b57d5acac/content/browser/bluetooth/bluetooth_allowed_devices_map.cc [modify] https://crrev.com/e491483f14621c2bf2587c2ccbf3905b57d5acac/content/browser/bluetooth/bluetooth_allowed_devices_map.h [modify] https://crrev.com/e491483f14621c2bf2587c2ccbf3905b57d5acac/content/browser/bluetooth/bluetooth_allowed_devices_map_unittest.cc [modify] https://crrev.com/e491483f14621c2bf2587c2ccbf3905b57d5acac/content/browser/bluetooth/bluetooth_blacklist.cc [modify] https://crrev.com/e491483f14621c2bf2587c2ccbf3905b57d5acac/content/browser/bluetooth/bluetooth_blacklist_unittest.cc [modify] https://crrev.com/e491483f14621c2bf2587c2ccbf3905b57d5acac/content/browser/bluetooth/bluetooth_device_chooser_controller.cc [modify] https://crrev.com/e491483f14621c2bf2587c2ccbf3905b57d5acac/content/browser/bluetooth/bluetooth_metrics.cc [modify] https://crrev.com/e491483f14621c2bf2587c2ccbf3905b57d5acac/content/browser/bluetooth/bluetooth_metrics.h [modify] https://crrev.com/e491483f14621c2bf2587c2ccbf3905b57d5acac/content/browser/bluetooth/web_bluetooth_service_impl.cc [modify] https://crrev.com/e491483f14621c2bf2587c2ccbf3905b57d5acac/content/browser/bluetooth/web_bluetooth_service_impl.h [modify] https://crrev.com/e491483f14621c2bf2587c2ccbf3905b57d5acac/content/renderer/bluetooth/bluetooth_type_converters.cc [modify] https://crrev.com/e491483f14621c2bf2587c2ccbf3905b57d5acac/content/renderer/bluetooth/bluetooth_type_converters.h [modify] https://crrev.com/e491483f14621c2bf2587c2ccbf3905b57d5acac/content/renderer/bluetooth/web_bluetooth_impl.cc [modify] https://crrev.com/e491483f14621c2bf2587c2ccbf3905b57d5acac/device/bluetooth/bluetooth.gyp [modify] https://crrev.com/e491483f14621c2bf2587c2ccbf3905b57d5acac/device/bluetooth/bluetooth_uuid.cc [modify] https://crrev.com/e491483f14621c2bf2587c2ccbf3905b57d5acac/device/bluetooth/bluetooth_uuid.h [add] https://crrev.com/e491483f14621c2bf2587c2ccbf3905b57d5acac/device/bluetooth/public/interfaces/BUILD.gn [add] https://crrev.com/e491483f14621c2bf2587c2ccbf3905b57d5acac/device/bluetooth/public/interfaces/DEPS [add] https://crrev.com/e491483f14621c2bf2587c2ccbf3905b57d5acac/device/bluetooth/public/interfaces/OWNERS [add] https://crrev.com/e491483f14621c2bf2587c2ccbf3905b57d5acac/device/bluetooth/public/interfaces/bluetooth_uuid.mojom [add] https://crrev.com/e491483f14621c2bf2587c2ccbf3905b57d5acac/device/bluetooth/public/interfaces/bluetooth_uuid.typemap [add] https://crrev.com/e491483f14621c2bf2587c2ccbf3905b57d5acac/device/bluetooth/public/interfaces/bluetooth_uuid_struct_traits.h [add] https://crrev.com/e491483f14621c2bf2587c2ccbf3905b57d5acac/device/bluetooth/public/interfaces/typemaps.gni [modify] https://crrev.com/e491483f14621c2bf2587c2ccbf3905b57d5acac/mojo/public/tools/bindings/chromium_bindings_configuration.gni [modify] https://crrev.com/e491483f14621c2bf2587c2ccbf3905b57d5acac/third_party/WebKit/public/BUILD.gn [modify] https://crrev.com/e491483f14621c2bf2587c2ccbf3905b57d5acac/third_party/WebKit/public/blink.gyp [modify] https://crrev.com/e491483f14621c2bf2587c2ccbf3905b57d5acac/third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Comment 1 by ortuno@chromium.org
, May 13 2016