New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 606445 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

MD Settings Search engines: Use favicon cache instead of directly loading favicon URL

Project Member Reported by dpa...@chromium.org, Apr 25 2016

Issue description

Old (options): https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/resources/options/search_engine_manager_engine_list.js&l=127

New (settings):
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html&l=41

Loading directly the favicon URL instead of using the cache can cause performance issues for the case of many search engines.

Caveat of using the favicon cache is that a default icon is displayed if the search engine page has not been visited before.
 

Comment 1 by dpa...@chromium.org, Apr 25 2016

Cc: groby@chromium.org

Comment 2 by groby@chromium.org, Apr 25 2016

See attached screenshot for timeline - after 3.5s, there's a flood of favicon requests, and it delays display roughly until the 7s mark. (The other outliers are favicons that generate server error responses, but they don't seem to affect time to display)



Screen Shot 2016-04-25 at 1.50.47 PM.png
9.7 KB View Download

Comment 3 by dpa...@chromium.org, Apr 25 2016

Status: Started (was: Untriaged)

Comment 6 by dpa...@chromium.org, Apr 27 2016

Status: Fixed (was: Started)

Sign in to add a comment