New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 606434 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

set wallpaper then the PNG file will display incorrect (overlap with last image )

Project Member Reported by abodenha@chromium.org, Apr 25 2016

Issue description

Moved from https://code.google.com/p/chrome-os-partner/issues/detail?id=50472.  See there for more detailed history.

Short version:
1: Set one wallpaper.
2: Then set another.
3: Flip back and forth.

Sometimes, depending on the wallpaper you'll get pieces of both wallpapers displaying at the same time.
 

Comment 1 by x...@chromium.org, Apr 28 2016

Status: Started (was: Assigned)
I guess Chrome OS has some problems with transparent image rendering. I'll take a look at it.
xdai, any progress on this one?

Comment 3 by x...@chromium.org, May 6 2016

Not yet. I was distracted by other issues.

Comment 4 by x...@chromium.org, May 18 2016

Status: Assigned (was: Started)
Move back to 'Assigned' since I won't be able to work on it for the next several months.
Owner: xiaoyinh@chromium.org
xiaoyinh@ can you dig into this since xdai@ will be occupied with other issues for a while?
I'm able to reproduce this issue.

One observation:
Once I change the image to jpeg format, this issue goes away.
Status: Started (was: Assigned)
In code review right now:
https://codereview.chromium.org/1996793002/
Project Member

Comment 8 by bugdroid1@chromium.org, May 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fb57605dc341abde4f2eace5ec578520b74b224

commit 5fb57605dc341abde4f2eace5ec578520b74b224
Author: xiaoyinh <xiaoyinh@chromium.org>
Date: Fri May 20 21:45:42 2016

This change is to fill the canvas with black background every time before painting a new wallpaper, so that the new wallpaper with partial transparency won't be painted upon a previous wallpaper.

BUG= 606434 

Review-Url: https://codereview.chromium.org/1996793002
Cr-Commit-Position: refs/heads/master@{#395175}

[modify] https://crrev.com/5fb57605dc341abde4f2eace5ec578520b74b224/ash/desktop_background/desktop_background_view.cc

Status: Fixed (was: Started)
Cc: durga.behera@chromium.org xiaoyinh@chromium.org pucchakayala@chromium.org songsuk@chromium.org ajha@chromium.org kavvaru@chromium.org
 Issue 613944  has been merged into this issue.
FYI: Fix landed in Chromium 53.0.2744.0.
Status: Verified (was: Fixed)
Verified on 53.0.2754.0/8406.0.0 
Labels: Merge-Request-52
Can we merge this to M52?
Status: Assigned (was: Verified)

Comment 15 by tin...@google.com, Jun 6 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 16 by bugdroid1@chromium.org, Jun 6 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b6f08c731efaf219e4db595a2a6a972521d1701

commit 9b6f08c731efaf219e4db595a2a6a972521d1701
Author: xdai <xdai@chromium.org>
Date: Mon Jun 06 19:01:14 2016

[Merge to M52]Fill the canvas with black background before painting wallpaper.

Merge this CL to M52 on behalf of xiaoyinh@. This change is to fill the canvas
with black background every time before painting a new wallpaper, so that the
new wallpaper with partial transparency won't be painted upon a previous wallpaper.

BUG= 606434 
TBR=achuith@chromium.org, xiaoyinh@chromium.org

Review-Url: https://codereview.chromium.org/1996793002
Cr-Commit-Position: refs/heads/master@{#395175}
(cherry picked from commit 5fb57605dc341abde4f2eace5ec578520b74b224)

Review URL: https://codereview.chromium.org/2039173003 .

Cr-Commit-Position: refs/branch-heads/2743@{#244}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/9b6f08c731efaf219e4db595a2a6a972521d1701/ash/desktop_background/desktop_background_view.cc

Comment 17 by x...@chromium.org, Jun 6 2016

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified on TOT (8456.0.0, 53.0.2764.0) and M52 (8350.31.0, 52.0.2743.41)

Sign in to add a comment