New issue
Advanced search Search tips

Issue 606428 link

Starred by 3 users
Status: Started
Owner:
morlovich@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 599523



Sign in to add a comment

Fuzz HttpServer

Project Member Reported by mmenke@chromium.org, Apr 25 2016 
We're using it in production, for better or for worse, so we should fuzz it.  We should probably use mock sockets, like we do for client tests, though we do need a way to create them.  The fact that the server goes to disk does mean we have to be careful to avoid races, if we want to test multiple requests at once (Which I think we do).
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/860f9bdcd6642816bd2a4879bc878f8473927d9f

commit 860f9bdcd6642816bd2a4879bc878f8473927d9f
Author: morlovich <morlovich@chromium.org>
Date: Fri Jan 20 21:34:25 2017

HttpServer::ParseHeaders: don't DCHECK on bogus headers termination

DCHECK seems like the wrong approach for invalid wire data, rather handle
it as a parse failure.

BUG=606428

Review-Url: https://codereview.chromium.org/2648553002
Cr-Commit-Position: refs/heads/master@{#445173}

[modify] https://crrev.com/860f9bdcd6642816bd2a4879bc878f8473927d9f/net/server/http_server.cc
[modify] https://crrev.com/860f9bdcd6642816bd2a4879bc878f8473927d9f/net/server/http_server_unittest.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/788a643320ed52bdaf97892a43c505314678157a

commit 788a643320ed52bdaf97892a43c505314678157a
Author: morlovich <morlovich@chromium.org>
Date: Mon Jan 23 19:46:58 2017

HttpServer WebSocket: don't crash on data before server handshake

(Which includes the case of a server delegate which doesn't do anything
 with WebSocket requests).

Note: this assumes 860f9bd is in, since otherwise the test
would leak.

BUG=606428

Review-Url: https://codereview.chromium.org/2640363004
Cr-Commit-Position: refs/heads/master@{#445439}

[modify] https://crrev.com/788a643320ed52bdaf97892a43c505314678157a/net/server/http_server_unittest.cc
[modify] https://crrev.com/788a643320ed52bdaf97892a43c505314678157a/net/server/web_socket.cc

Comment 4 by morlovich@chromium.org, Jan 30 2017

Owner: morlovich@chromium.org

Comment 5 by morlovich@chromium.org, Jan 30 2017

Status: Started (was: Available)
►

Sign in to add a comment