Clean up wifi_data_provider_corewlan_mac.mm code |
|||||||||
Issue descriptionwifi_data_provider_corewlan_mac.mm has a comment saying // Define a subset of the CoreWLAN interfaces we require. We can't depend on // CoreWLAN.h existing as we need to build on 10.5 SDKs. We can't just send // messages to an untyped id due to the build treating warnings as errors, // hence the reason we need class definitions. // TODO(joth): When we build all 10.6 code exclusively 10.6 SDK (or later) // tidy this up to use the framework directly. See http://crbug.com/37703 We can rely on the 10.6 SDK (or later) now. I tried just removing the prototypes, but the public API is slightly different from what's declared, so changing this requires some care.
,
Apr 25 2016
It's blocking that bug, it's not blocked on it, right?
,
Apr 25 2016
I set the blocking based on how the other bugs are linked out of bug 579255 .
,
May 6 2016
[mac triage] +cc content/browser/geolocation/OWNERS Also obstinately removing this from the triage queue, and blocking Issue 579255 , which I guess means it will fall to Erik if he wants to close that :)
,
May 6 2016
,
Jun 1 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 12 2016
This issue has been moved once and is lower than Pri-1. Removing the milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 1 2016
https://codereview.chromium.org/2472463002/
,
Nov 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30bcd45ac9f5875bdcf7a17020b4fe7d94d503bf commit 30bcd45ac9f5875bdcf7a17020b4fe7d94d503bf Author: rsesek <rsesek@chromium.org> Date: Mon Nov 07 18:50:36 2016 [Mac] Use CoreWLAN directly now that macOS 10.9 is the minimum version. BUG= 606408 TEST=With WiFi turned on, go to https://maps.google.com, update current location, verify Net.WiFi histograms and AccessPointData. Review-Url: https://codereview.chromium.org/2472463002 Cr-Commit-Position: refs/heads/master@{#430326} [modify] https://crrev.com/30bcd45ac9f5875bdcf7a17020b4fe7d94d503bf/device/geolocation/BUILD.gn [delete] https://crrev.com/ccdd0545aeca70d9b8f32285b6a4469f80aa7011/device/geolocation/wifi_data_provider_corewlan_mac.mm [delete] https://crrev.com/ccdd0545aeca70d9b8f32285b6a4469f80aa7011/device/geolocation/wifi_data_provider_mac.cc [modify] https://crrev.com/30bcd45ac9f5875bdcf7a17020b4fe7d94d503bf/device/geolocation/wifi_data_provider_mac.h [add] https://crrev.com/30bcd45ac9f5875bdcf7a17020b4fe7d94d503bf/device/geolocation/wifi_data_provider_mac.mm
,
Nov 10 2016
,
Sep 22 2017
,
Sep 22 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by rsesek@chromium.org
, Apr 25 2016