entry in about_flags submitted without committing the AboutFlags_-feature part in actions.xml |
||
Issue descriptionhttps://codereview.chromium.org/1568913003 was committed, adding an AboutFlags entry without the associated UserAction entry that was supposed to be added, see https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/about_flags.cc&l=522 This is unfortunate as the next person trying to add an (unrelated) action to the actions.xml got a warning about the missing AboutFlags. Should we have a presubmit on the about_flags file verifying it is added correctly? Note that the requirement is mentioned here: https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/about_flags.cc&l=522
,
Apr 25 2016
Storing it as a histogram on startup does make more sense. The idea is to have a sense of what % of people have a given about::flag enabled, and user actions really isn't the best model for that. Should it be per upload instead of per-startup, or is that too heavy weight?
,
Apr 25 2016
rkaplow@ is this issue for adding it to presumbit checks or is it only for the issue I caused and you want me to assign it to myself and fix it?
,
Apr 25 2016
Re #3 I already landed a fix for the missing action, so nothing left to do there: https://codereview.chromium.org/1918953002/
,
Apr 25 2016
Hmm, per upload would certainly be more immediately useful, but if we do it that way, we need to ensure it has a minimal impact on data size. This *probably* the case since I expect most users don't use about flags, but we should verify before such a change.
,
Sep 12 2016
AboutFlags_ actions have been removed now, in favor of a histogram, see crbug.com/639304 . |
||
►
Sign in to add a comment |
||
Comment 1 by asvitk...@chromium.org
, Apr 25 2016