New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 606393 link

Starred by 1 user
Status: Fixed
Owner:
█ nyquist@chromium.org
Traveling - Back 2/6
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Build spam from layer_tree_host.proto

Project Member Reported by thakis@chromium.org, Apr 25 2016 
[864/10006] RULE Generating C++ and Python code from proto/layer_tree_host.proto
layer_tree_host.proto: warning: Import layer_tree_settings.proto but not used.


The build should be silent; please fix.

Comment 1 by dtapu...@chromium.org, Apr 25 2016

Cc: -dtapu...@chromium.org nyquist@chromium.org
Components: Internals>Compositing

Comment 2 by nyquist@chromium.org, Apr 25 2016

Cc: -nyquist@chromium.org
Owner: nyquist@chromium.org
Status: Started (was: Unconfirmed)

Comment 3 by jaydasika@chromium.org, Apr 25 2016

Cc: -jaydasika@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63058ab766b06470a17d417577e505964560c6df

commit 63058ab766b06470a17d417577e505964560c6df
Author: nyquist <nyquist@chromium.org>
Date: Mon Apr 25 19:45:10 2016

Remove unused proto import for LayerTreeHost.

The initial commit of the layer_tree_host.proto
https://codereview.chromium.org/1519293002 included an unused
import for layer_tree_settings.proto, since LayerTreeHost message
does not refer to LayerTreeSettings.

The LayerTreeSettings are instead used for the
CompositorMessageToImpl messages and specifically the
InitializeImpl message.

This CL just removes the unused import to clean up code and remove
build spam.

BUG= 606393 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1920793004

Cr-Commit-Position: refs/heads/master@{#389542}

[modify] https://crrev.com/63058ab766b06470a17d417577e505964560c6df/cc/proto/layer_tree_host.proto

Comment 6 by nyquist@chromium.org, Apr 26 2016

Status: Fixed (was: Started)
►

Sign in to add a comment