New issue
Advanced search Search tips

Issue 606389 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Feb 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ConnectivityTaskTest#testCallbackTwoTimeouts is highly flaky on some devices

Reported by kra...@amazon.com, Apr 25 2016

Issue description

Chrome Version: Any (e.g. tip of master)
OS: Android

What steps will reproduce the problem?
Run ConnectivityTaskTest#testCallbackTwoTimeouts repeatedly with num_retries=0
What is the expected result?
100%
C   20.651s Main  ********************************************************************************
C   20.651s Main  [==========] 1 test ran.
C   20.651s Main  [  PASSED  ] 1 test.
C   20.651s Main  ********************************************************************************

What happens instead?
On some device types, the test fails nearly half the time with
C   19.154s Main  [FAIL] org.chromium.chrome.browser.feedback.ConnectivityTaskTest#testCallbackTwoTimeouts:
C   19.154s Main  junit.framework.ComparisonFailure: Wrong result for CHROME_HTTP expected:<[CONNECTED]> but was:<[TIMEOUT]>
C   19.154s Main  	at org.chromium.chrome.browser.feedback.ConnectivityTaskTest.assertResult(ConnectivityTaskTest.java:80)
C   19.154s Main  	at org.chromium.chrome.browser.feedback.ConnectivityTaskTest.verifyConnections(ConnectivityTaskTest.java:66)
C   19.154s Main  	at org.chromium.chrome.browser.feedback.ConnectivityTaskTest.testCallbackTwoTimeouts(ConnectivityTaskTest.java:143)
C   19.154s Main  	at java.lang.reflect.Method.invokeNative(Native Method)
C   19.154s Main  	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
C   19.154s Main  	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
C   19.154s Main  	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:129)
C   19.154s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C   19.154s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C   19.154s Main  	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:556)
C   19.154s Main  	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1705)

Please provide any additional information below. Attach a screenshot if
possible.
 

Comment 1 by kra...@amazon.com, Apr 25 2016

Proposed fix: https://codereview.chromium.org/1915133002
I ran it several hundred times on one of the devices that failed ~50% before this change (0 failures so far)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5c7ff26be05f5dca549e35b1b042af0c32b8116

commit d5c7ff26be05f5dca549e35b1b042af0c32b8116
Author: kraush <kraush@amazon.com>
Date: Thu Apr 28 15:44:39 2016

Increase timeout in ConnectivityTaskTest#testCallbackTwoTimeouts

This increases the timeout in ConnectivityTaskTest#testCallbackTwoTimeouts
from 100ms to 1s in order to let it pass on all devices.

BUG= 606389 

Review-Url: https://codereview.chromium.org/1915133002
Cr-Commit-Position: refs/heads/master@{#390393}

[modify] https://crrev.com/d5c7ff26be05f5dca549e35b1b042af0c32b8116/chrome/android/javatests/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java

Status: Fixed (was: Untriaged)

Sign in to add a comment