New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 606385 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

[Windows Host] Remove XP code and DLL for sending a secure attention sequence

Project Member Reported by joedow@chromium.org, Apr 25 2016

Issue description

A specific DLL is needed in order to send a secure attention sequence (Ctrl + Alt + Del).  This DLL is available on Win7/WS 2008 R2 but not on downlevel OSes.  Since we no longer support Vista/XP We should consider whether we want to keep this functionality (redist DLL and special codepath to load it) for WS2008 or if we required WS 2008 R2 and can remove it.

 

Comment 1 by joedow@chromium.org, Apr 25 2016

WS2008 is based on Vista so I'm assuming it is ok to deprecate code for it.

Comment 2 by joedow@chromium.org, Apr 26 2016

Components: Services>Chromoting
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19d55d345af78a83f3ef181004b8f475377cc354

commit 19d55d345af78a83f3ef181004b8f475377cc354
Author: joedow <joedow@chromium.org>
Date: Fri Jun 03 20:55:15 2016

Removing the sas.dll dependency from the Chromoting MSI

The sas.dll was originally added to allow Chromtoing to inject the Secure
Attention Sequence (SAS).  Win7 and later OSes have an API for doing this
however we needed to support this functionality on XP and Vista and using the
redist sas.dll allows this.  Since we no longer need to support OSes earlier
than Win7/W2k8R2, we can call the OS API instead of using the version exposed
in sas.dll.

Removing this dependency also cleans up our code and reduces our pacakge size.

I don't think anyone else is using this dll so I am going to submit a follow-up
CL to remove the higher level GYP variables after this lands.

BUG= 606385 

Review-Url: https://codereview.chromium.org/2033683003
Cr-Commit-Position: refs/heads/master@{#397798}

[modify] https://crrev.com/19d55d345af78a83f3ef181004b8f475377cc354/remoting/host/BUILD.gn
[modify] https://crrev.com/19d55d345af78a83f3ef181004b8f475377cc354/remoting/host/installer/win/chromoting.wxs
[modify] https://crrev.com/19d55d345af78a83f3ef181004b8f475377cc354/remoting/host/sas_injector_win.cc
[modify] https://crrev.com/19d55d345af78a83f3ef181004b8f475377cc354/remoting/host/win/rdp_client_window.cc
[modify] https://crrev.com/19d55d345af78a83f3ef181004b8f475377cc354/remoting/remoting_host_win.gypi

Labels: OS-Windows
Owner: ajnolley@chromium.org
Status: Fixed (was: Started)
Can you take a look at this to make sure the SAS functionality was not regressed on Win8/Win10?  I've verified on Win7.  Note, I believe this requires a non-curtain mode setup as we use a different mechanism for SAS if we are using an RDP session.
Status: Verified (was: Fixed)
There are no regressions at this time. Checked with the latest Win 10 Insider build

Sign in to add a comment