Clean-up memory-infra benchmarks |
|||||||||
Issue description
Hey Annie,
given all the things that happened in the past (switch to memory-infra) and that are coming now (TMBv2), we were thinking to do a mega reset pass to normalize the situation.
Petr, Juan and I just sat together and realized that the situation today is really confusing and are proposing to fix it before moving forward with new stuff.
Summary of the situation today
------------------------------
internal:
memory.system_health_plan: uses a set 10 pages (!= top_10_mobile, no real reason other than "historical"), 5 iterations
upstream:
system_health_quick: same as memory.system_health_plan, but 1 iteration.
memory.top_10_mobile: same pageset of top_10_mobile, uses memory-infra v1
this one never had any alerts, was just a way for us to get confidence on
memory-infra v1. It's no longer needed at this stage.
Data we care about:
- The only data we care about (and we alert on) is the downstream memory.memory_health_plan.
- We don't care and can drop everything upstream (memory.top_10_mobile, memory.memory_health_quick, memory.memory_health_plan)
Upcoming things:
----------------
Petr is writing a TBMv2 memory-infra benchmark.
Question: which pageset should it use? How many iterations?
Proposal
--------
Our proposal is to make everything uniform and simpler:
- switch the internal system_health_plan to use the top_10_mobile pageset (the same of other benchmarks)
- rename it to just memory.top_10_mobile (as it now will match the other top_10_mobile benchmarks)
- kill system_health_quick and its data
- kill the existing memory.top_10_mobile and its data
- Call the upstream equivalent of the downstream memory.top_10_mobile with the same name, and keep the same num. iterations (5)
So the confusing part here is about naming. We are essentially proposing to kill memory.top_10_mobile and reusing its name for what we called so far "system_health". this is to keep the system_health namespace free for whenever the Chrome System health will happen.
in essence, we will have as a result of this proposal:
memory.top_10_mobile, pageset: top_10_mobile, iterations: 5
- running downstream against clank
- running upstream against ChromePublic
Plus
- petr's upcoming memory.top_10_mobile_tbmv2
At the end of the TBMv2 transition we will have only:
- memory.top_10_mobile_tbmv2 both upstream and downstream.
Execution steps:
- kill memory.top_10_mobile and delete its data (today should be upstream only).
- kill memory.memory_health_quick and delete its data (ditto, upstream only, existed only for a week or so).
- also remove memory.memory_health_{chrome,webview} (it's downstream only). They are from back the days were we needed two different names for chrome/webview, later got unified under memory.memory_health_plan. we shipped them and we have records in juan's dashboard. Unlikely we'll need/bisect on that data again.
- rename memory.memory_health_plan to memory.top_10_mobile (Also rename the data and alerts). This is the only one we really care about.
- Petr will land the TBMv2 as memory.top_10_mobile_tbmv2
WDYT?
,
Apr 25 2016
> Where will we document which memory benchmarks are running and why? Good point, what is the best place for this? a Markdown in the codebase? Wiki? I'll happy to do that in whatever space is more appropriate. > the old page_cycler memory metrics, and when they will be removed? Excellent question, I skipped in the discussion to avoid adding too many things together. I'd say that once we have memory.top_10_mobile tracking the same page set and cardinality of page_cycler, we can set a deadline (~1 month) and that day compare the regressions we got between page_cycler.top_10_mobile and memory.top_10_mobile and if there are no suspicious blocker ditch the old-style metric (if there are blockers address them). Unfortunately we cannot do this today as today's memory.top_10_mobile is 1 iteration only, which makes it uncomparable with page_cycler
,
Apr 25 2016
>> Where will we document which memory benchmarks are running and why? >Good point, what is the best place for this? a Markdown in the codebase? Wiki? I'll happy to do that in whatever space is more appropriate. We don't have a great track record for making easily findable docs. I think the best place would be markdown in tools/perf/docs. Ned, wdyt? Have you got general thoughts on where end-user system health docs should go? Deprecation plan for memory on old page_cyclers sgtm.
,
Apr 25 2016
top_10_mobile.py is a tbmv1 benchmark (see https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/page_sets/top_10_mobile.py&l=54). We should make a new one with similar content but do not contain the old interaction record. Also to better organize the new page sets that we maintain for system health, I propose that we put all the system health page sets into a new folder: page_sets/system_health/... What do you all think?
,
Apr 25 2016
*I agree with putting system health doc as .md files in tools/perf/docs/..
,
Apr 25 2016
We have lot of things on this bug, let's focus a bit the discussion to avoid a mega-bug hard to follow. system-health: this bug is NOT about the (Chrome) system health. You and peter are working on that, let's keep the discussion about folder / page-set somewhere else. This bug is about normalizing the situation of the page-cyclers, and in particular the ones that we happen to use today for the Android system health plan. For them we need to maintain a page cycler of some form (the current proposal it to at least reuse the top_10_mobile page set, to drop one extra page-set) until the chrome system health benchmark will be ready an running reliably. So far we used a mixture of top_10_mobile and random-10-pages for page sets, my proposal here is to start ditching one of the two and free up the "health" name, so you and Petr can use it with the new set of benchmarks that will come in the future.
,
Apr 25 2016
Fair enough, I agree that the situation is so confusing that it's hard to even innovate on the page sets side. So to clarify, in the short term, the only two memory benchmarks team will have are: memory.top_10_mobile (to be deleted once the tbmv version is confirmed to be as good) memory.top_10_mobile_tbmv2 Do we also consider renaming memory.top_10_mobile_tbmv2 to memory.top_10_mobile once we delete the tbmv1 version?
,
Apr 25 2016
That is exactly the plan.
,
Apr 25 2016
#7 yes, you're absolutely correct, the best form of correct :) >Do we also consider renaming memory.top_10_mobile_tbmv2 to memory.top_10_mobile once we delete the tbmv1 version? Don't have a strong opinion, whatever you think is best. My main concern is just ending up having "one" of these, regardless of whatever name.
,
Apr 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92efb5bc7f3830436cc047a39e79c5374b5a4d7a commit 92efb5bc7f3830436cc047a39e79c5374b5a4d7a Author: petrcermak <petrcermak@chromium.org> Date: Mon Apr 25 18:34:35 2016 Set up a parallel memory.memory_health_quick_tbmv2 benchmark This patch adds a temporary parallel benchmark to compare the new TBMv2 memory metric (third_party/catapult/tracing/tracing/metrics/ system_health/memory_metric.html) with the existing TBMv1 one (third_party/catapult/telemetry/telemetry/web_perf/metrics/ memory_timeline.py). Once all issues associated with the TBMv2 metric are resolved, all memory benchmarks will switch to use it instead of the TBMv1 metric and the temporary parallel benchmark will be removed. BUG= 581716 , 606361 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Review URL: https://codereview.chromium.org/1907343002 Cr-Commit-Position: refs/heads/master@{#389519} [modify] https://crrev.com/92efb5bc7f3830436cc047a39e79c5374b5a4d7a/tools/perf/benchmarks/memory_infra.py [modify] https://crrev.com/92efb5bc7f3830436cc047a39e79c5374b5a4d7a/tools/perf/page_sets/memory_health_story.py
,
Apr 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92efb5bc7f3830436cc047a39e79c5374b5a4d7a commit 92efb5bc7f3830436cc047a39e79c5374b5a4d7a Author: petrcermak <petrcermak@chromium.org> Date: Mon Apr 25 18:34:35 2016 Set up a parallel memory.memory_health_quick_tbmv2 benchmark This patch adds a temporary parallel benchmark to compare the new TBMv2 memory metric (third_party/catapult/tracing/tracing/metrics/ system_health/memory_metric.html) with the existing TBMv1 one (third_party/catapult/telemetry/telemetry/web_perf/metrics/ memory_timeline.py). Once all issues associated with the TBMv2 metric are resolved, all memory benchmarks will switch to use it instead of the TBMv1 metric and the temporary parallel benchmark will be removed. BUG= 581716 , 606361 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Review URL: https://codereview.chromium.org/1907343002 Cr-Commit-Position: refs/heads/master@{#389519} [modify] https://crrev.com/92efb5bc7f3830436cc047a39e79c5374b5a4d7a/tools/perf/benchmarks/memory_infra.py [modify] https://crrev.com/92efb5bc7f3830436cc047a39e79c5374b5a4d7a/tools/perf/page_sets/memory_health_story.py
,
Apr 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c572b2ccff4c64f3e9aecd526729ffb4e89a00e commit 1c572b2ccff4c64f3e9aecd526729ffb4e89a00e Author: perezju <perezju@chromium.org> Date: Tue Apr 26 08:49:14 2016 Revert of Set up a parallel memory.memory_health_quick_tbmv2 benchmark (patchset #4 id:80001 of https://codereview.chromium.org/1907343002/ ) Reason for revert: Broke data upload to perf dashboard for these benchmarks. BUG= 606698 Original issue's description: > Set up a parallel memory.memory_health_quick_tbmv2 benchmark > > This patch adds a temporary parallel benchmark to compare the new TBMv2 > memory metric (third_party/catapult/tracing/tracing/metrics/ > system_health/memory_metric.html) with the existing TBMv1 one > (third_party/catapult/telemetry/telemetry/web_perf/metrics/ > memory_timeline.py). > > Once all issues associated with the TBMv2 metric are resolved, all > memory benchmarks will switch to use it instead of the TBMv1 metric and > the temporary parallel benchmark will be removed. > > BUG= 581716 , 606361 > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq > > Committed: https://crrev.com/92efb5bc7f3830436cc047a39e79c5374b5a4d7a > Cr-Commit-Position: refs/heads/master@{#389519} TBR=primiano@chromium.org,nednguyen@google.com,petrcermak@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 581716 , 606361 Review URL: https://codereview.chromium.org/1915163003 Cr-Commit-Position: refs/heads/master@{#389726} [modify] https://crrev.com/1c572b2ccff4c64f3e9aecd526729ffb4e89a00e/tools/perf/benchmarks/memory_infra.py [modify] https://crrev.com/1c572b2ccff4c64f3e9aecd526729ffb4e89a00e/tools/perf/page_sets/memory_health_story.py
,
Apr 26 2016
,
Apr 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2dfc3c66ad792aea2f53009c26520deb4cbfed8 commit a2dfc3c66ad792aea2f53009c26520deb4cbfed8 Author: nednguyen <nednguyen@google.com> Date: Wed Apr 27 18:10:58 2016 Reland of Set up a parallel memory.memory_health_quick_tbmv2 benchmark (patchset #1 id:1 of https://codereview.chromium.org/1915163003/ ) Reason for revert: Underlied problem should be already fixed. Original issue's description: > Revert of Set up a parallel memory.memory_health_quick_tbmv2 benchmark (patchset #4 id:80001 of https://codereview.chromium.org/1907343002/ ) > > Reason for revert: > Broke data upload to perf dashboard for these benchmarks. > > BUG= 606698 > > Original issue's description: > > Set up a parallel memory.memory_health_quick_tbmv2 benchmark > > > > This patch adds a temporary parallel benchmark to compare the new TBMv2 > > memory metric (third_party/catapult/tracing/tracing/metrics/ > > system_health/memory_metric.html) with the existing TBMv1 one > > (third_party/catapult/telemetry/telemetry/web_perf/metrics/ > > memory_timeline.py). > > > > Once all issues associated with the TBMv2 metric are resolved, all > > memory benchmarks will switch to use it instead of the TBMv1 metric and > > the temporary parallel benchmark will be removed. > > > > BUG= 581716 , 606361 > > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq > > > > Committed: https://crrev.com/92efb5bc7f3830436cc047a39e79c5374b5a4d7a > > Cr-Commit-Position: refs/heads/master@{#389519} > > TBR=primiano@chromium.org,nednguyen@google.com,petrcermak@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= 581716 , 606361 > > Committed: https://crrev.com/1c572b2ccff4c64f3e9aecd526729ffb4e89a00e > Cr-Commit-Position: refs/heads/master@{#389726} TBR=primiano@chromium.org,petrcermak@chromium.org,perezju@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 606698 Review-Url: https://codereview.chromium.org/1920363003 Cr-Commit-Position: refs/heads/master@{#390126} [modify] https://crrev.com/a2dfc3c66ad792aea2f53009c26520deb4cbfed8/tools/perf/benchmarks/memory_infra.py [modify] https://crrev.com/a2dfc3c66ad792aea2f53009c26520deb4cbfed8/tools/perf/page_sets/memory_health_story.py
,
Apr 29 2016
,
Apr 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16f997fbab9e601b85ee967aeb1e9b544a708742 commit 16f997fbab9e601b85ee967aeb1e9b544a708742 Author: perezju <perezju@chromium.org> Date: Fri Apr 29 18:02:17 2016 Memory Infra: Remove memory.top_10_mobile benchmark Removing this benchmark, to be replaced with the current memory health user story running on the top 10 mobile page set. BUG= 606361 , 540022 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Review-Url: https://codereview.chromium.org/1936493002 Cr-Commit-Position: refs/heads/master@{#390695} [modify] https://crrev.com/16f997fbab9e601b85ee967aeb1e9b544a708742/tools/perf/benchmarks/memory_infra.py [delete] https://crrev.com/4912248549948586848885a5b3eccff2ea16c104/tools/perf/page_sets/memory_infra_top_10_mobile_story.py
,
May 3 2016
That last CL removed the old memory.top_10_mobile benchmark, which should not be running any more. Annie, could you help us remove all dashboard data associated with that benchmark? What that is done please assign back to me so I can rename the existing memory.memory_health_plan to memory.top_10_mobile
,
May 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d710bb61772f8368fb69203c79d27a1afc81b74d commit d710bb61772f8368fb69203c79d27a1afc81b74d Author: perezju <perezju@chromium.org> Date: Tue May 03 18:03:39 2016 [tools/perf] Remove trace rerun options from dual browser benchmark The "TraceRerun" methods are no longer used by memory_infra. BUG= 585760 , 606361 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Review-Url: https://codereview.chromium.org/1944693002 Cr-Commit-Position: refs/heads/master@{#391294} [modify] https://crrev.com/d710bb61772f8368fb69203c79d27a1afc81b74d/tools/perf/benchmarks/memory_infra.py
,
May 5 2016
Reassigning to Juan as the data has been deleted as per request in #17.
,
May 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc85d3a60ed046eb107e5b61580c148860bde0e6 commit cc85d3a60ed046eb107e5b61580c148860bde0e6 Author: perezju <perezju@chromium.org> Date: Thu May 05 17:01:06 2016 [tools/perf] Remove memory.memory_health_quick Also brings memory.top_10_mobile_tbmv2 on par with the remaining memory.memory_health_plan, both running with pageset_repeat: 5, and differing only on the TBM version. BUG= 606361 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Review-Url: https://codereview.chromium.org/1947883002 Cr-Commit-Position: refs/heads/master@{#391832} [modify] https://crrev.com/cc85d3a60ed046eb107e5b61580c148860bde0e6/tools/perf/benchmarks/memory_infra.py
,
May 5 2016
Can we kill the old memory trace parsing code in telemetry too?
,
May 6 2016
#21: Yes, we'll do that as soon as memory.memory_health_plan migrates to TBMv2 (current estimate: in ~2 weeks time).
,
May 6 2016
Yup the current plan is to enable the TBMv2 memory_health (once Juan is back) and kill the TBMv1 benchmark and metric after the branch point (for android health plan we need branch-to-branch contiguity)
,
May 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/038c8e440a546b73df32a36ce3e21949bf6fef0a commit 038c8e440a546b73df32a36ce3e21949bf6fef0a Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Sat May 07 00:13:59 2016 Roll src/third_party/catapult/ c611ed28a..5fd81fa73 (1 commit). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/c611ed28a31b..5fd81fa73c9f $ git log c611ed28a..5fd81fa73 --date=short --no-merges --format='%ad %ae %s' BUG= 606361 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/1959843002 Cr-Commit-Position: refs/heads/master@{#392213} [modify] https://crrev.com/038c8e440a546b73df32a36ce3e21949bf6fef0a/DEPS
,
May 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10ce2c477f580413bb34f26a0395c9c3bca5682a commit 10ce2c477f580413bb34f26a0395c9c3bca5682a Author: perezju <perezju@chromium.org> Date: Wed May 25 13:24:23 2016 Memory Infra: Replace memory_health_plan with top_10_mobile Replace memory.memory_health_plan with the memory.top_10_mobile benchmark. This keeps the story to provide foreground/background measurements, but swaps the page set to use top_10_mobile. New recordings are provided. Perf sheriffs warning: this is very likely to cause measurements in memory.top_10_mobile to shift. BUG= 606361 Review-Url: https://codereview.chromium.org/1936533002 Cr-Commit-Position: refs/heads/master@{#395876} [modify] https://crrev.com/10ce2c477f580413bb34f26a0395c9c3bca5682a/tools/perf/benchmarks/memory_infra.py [delete] https://crrev.com/292f29f4145ab3d099128dfdd9b4e465dc62f76a/tools/perf/page_sets/data/memory_health_plan.json [delete] https://crrev.com/292f29f4145ab3d099128dfdd9b4e465dc62f76a/tools/perf/page_sets/data/memory_health_plan_000.wpr.sha1 [add] https://crrev.com/10ce2c477f580413bb34f26a0395c9c3bca5682a/tools/perf/page_sets/data/memory_top_10_mobile.json [add] https://crrev.com/10ce2c477f580413bb34f26a0395c9c3bca5682a/tools/perf/page_sets/data/memory_top_10_mobile_000.wpr.sha1 [rename] https://crrev.com/10ce2c477f580413bb34f26a0395c9c3bca5682a/tools/perf/page_sets/memory_top_10_mobile.py
,
May 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0b6e7a03576f8899ab9766f42781f654cd367d7 commit e0b6e7a03576f8899ab9766f42781f654cd367d7 Author: michaelbai <michaelbai@chromium.org> Date: Wed May 25 20:38:15 2016 Revert of Memory Infra: Replace memory_health_plan with top_10_mobile (patchset #5 id:80001 of https://codereview.chromium.org/1936533002/ ) Reason for revert: It seemed this broke the downstream bots https://uberchromegw.corp.google.com/i/internal.client.clank/builders/health-plan-clankium-low-end-phone/builds/858 Original issue's description: > Memory Infra: Replace memory_health_plan with top_10_mobile > > Replace memory.memory_health_plan with the memory.top_10_mobile > benchmark. > > This keeps the story to provide foreground/background measurements, > but swaps the page set to use top_10_mobile. > > New recordings are provided. > > Perf sheriffs warning: this is very likely to cause measurements in > memory.top_10_mobile to shift. > > BUG= 606361 > > Committed: https://crrev.com/10ce2c477f580413bb34f26a0395c9c3bca5682a > Cr-Commit-Position: refs/heads/master@{#395876} TBR=petrcermak@chromium.org,sullivan@chromium.org,primiano@chromium.org,perezju@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 606361 Review-Url: https://codereview.chromium.org/2007113009 Cr-Commit-Position: refs/heads/master@{#395982} [modify] https://crrev.com/e0b6e7a03576f8899ab9766f42781f654cd367d7/tools/perf/benchmarks/memory_infra.py [add] https://crrev.com/e0b6e7a03576f8899ab9766f42781f654cd367d7/tools/perf/page_sets/data/memory_health_plan.json [add] https://crrev.com/e0b6e7a03576f8899ab9766f42781f654cd367d7/tools/perf/page_sets/data/memory_health_plan_000.wpr.sha1 [delete] https://crrev.com/3d0b31870e3db76a8943a0e6f349600aa92f743c/tools/perf/page_sets/data/memory_top_10_mobile.json [delete] https://crrev.com/3d0b31870e3db76a8943a0e6f349600aa92f743c/tools/perf/page_sets/data/memory_top_10_mobile_000.wpr.sha1 [rename] https://crrev.com/e0b6e7a03576f8899ab9766f42781f654cd367d7/tools/perf/page_sets/memory_health_story.py
,
May 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ac6c6b7aa6b67f8b2a8df8af2c3c347aafb0f0b commit 1ac6c6b7aa6b67f8b2a8df8af2c3c347aafb0f0b Author: perezju <perezju@chromium.org> Date: Thu May 26 11:02:37 2016 Reland of Memory Infra: Replace memory_health_plan with top_10_mobile Replace memory.memory_health_plan with the memory.top_10_mobile benchmark. (But the old name is maintained to give a chance for bots to be updated.) This keeps the story to provide foreground/background measurements, but swaps the page set to use top_10_mobile. New recordings are provided. Perf sheriffs warning: this is very likely to cause measurements in corresponding memory infra metrics to shift. BUG= 606361 TBR=sullivan@chromium.org,primiano@chromium.org,petrcermak@chromium.org Review-Url: https://codereview.chromium.org/2006223008 Cr-Commit-Position: refs/heads/master@{#396157} [modify] https://crrev.com/1ac6c6b7aa6b67f8b2a8df8af2c3c347aafb0f0b/tools/perf/benchmarks/memory_infra.py [delete] https://crrev.com/bd0f07eb0c705b800aa424ef9feef11b7181aa7e/tools/perf/page_sets/data/memory_health_plan.json [delete] https://crrev.com/bd0f07eb0c705b800aa424ef9feef11b7181aa7e/tools/perf/page_sets/data/memory_health_plan_000.wpr.sha1 [add] https://crrev.com/1ac6c6b7aa6b67f8b2a8df8af2c3c347aafb0f0b/tools/perf/page_sets/data/memory_top_10_mobile.json [add] https://crrev.com/1ac6c6b7aa6b67f8b2a8df8af2c3c347aafb0f0b/tools/perf/page_sets/data/memory_top_10_mobile_000.wpr.sha1 [rename] https://crrev.com/1ac6c6b7aa6b67f8b2a8df8af2c3c347aafb0f0b/tools/perf/page_sets/memory_top_10_mobile.py
,
May 27 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/24cdf0ba4843497232fcef7dcf86aa6b2f8b2925 commit 24cdf0ba4843497232fcef7dcf86aa6b2f8b2925 Author: Juan A. Navarro Perez <perezju@google.com> Date: Thu May 26 09:00:00 2016
,
May 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a09a820cb5ac93f5e610a2c2e27879bfea5e52fc commit a09a820cb5ac93f5e610a2c2e27879bfea5e52fc Author: perezju <perezju@chromium.org> Date: Fri May 27 15:56:55 2016 [tools/perf] Remove deprecated memory.memory_health_plan Remove obsolte benchmark, as bots have been switched to use the new benchmark name now. BUG= 606361 Review-Url: https://codereview.chromium.org/2016273002 Cr-Commit-Position: refs/heads/master@{#396478} [modify] https://crrev.com/a09a820cb5ac93f5e610a2c2e27879bfea5e52fc/tools/perf/benchmarks/memory_infra.py
,
May 31 2016
Issue 615416 has been merged into this issue.
,
May 31 2016
All of the final CLs to replace memory.memory_health_plan with memory.top_10_mobile on the bots have landed and stuck.
Annie, passing this back to you to:
(1) Remove existing memory.memory_health_{chrome,webview} (it's downstream only). [Very old data, not actionable anymore.]
(2) Rename existing data and alerts from memory.memory_health_plan to memory.top_10_mobile.
,
May 31 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/12988f7018a9a954b0edee1d8b46d131a5e264e0 commit 12988f7018a9a954b0edee1d8b46d131a5e264e0 Author: Juan A. Navarro Perez <perezju@google.com> Date: Tue May 31 10:09:00 2016
,
May 31 2016
Thanks Juan! Re: #31, old data from 1) is deleted and migration in 2) is in progress.
,
Jun 8 2016
2) is finished
,
Jan 4 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by sullivan@chromium.org
, Apr 25 2016