Go back to the same place in snippets |
|||||||||||||||||||||||||||||||
Issue descriptionHitting system back should take the user back to the same place on the NTP. Currently, they need to scroll down to view the stories again.
,
Apr 26 2016
Do you think this should be part of the MVP?
,
Apr 26 2016
Not sure. Nepper?
,
Apr 26 2016
Issue 605044 has been merged into this issue.
,
Apr 26 2016
Yes, would be great to have, but not an MVP launch blocker.
,
May 3 2016
,
May 10 2016
,
Jun 3 2016
,
Jun 7 2016
,
Jun 7 2016
,
Jul 1 2016
,
Jul 1 2016
,
Jul 1 2016
,
Jul 8 2016
,
Jul 13 2016
,
Jul 13 2016
,
Jul 29 2016
,
Aug 22 2016
(+1 from me)
,
Aug 23 2016
Elevating priority to make this a cherry pick after launch blockers are done.
,
Aug 23 2016
Cherry pick as in merge into the release branch after branch point? I think that would need to be P1 in that case.
,
Aug 25 2016
Sorry for the ambiguity. I meant let's try to fix this before BP once our P1s are done.
,
Aug 25 2016
,
Aug 30 2016
,
Aug 30 2016
,
Sep 8 2016
,
Sep 8 2016
,
Sep 12 2016
,
Sep 19 2016
,
Sep 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22b18a9a6d4f421ddb6d4f74280a571bf7dca4f6 commit 22b18a9a6d4f421ddb6d4f74280a571bf7dca4f6 Author: mvanouwerkerk <mvanouwerkerk@chromium.org> Date: Wed Sep 21 16:15:23 2016 Ntp: restore scroll position. * The scroll position is stored as extra data on the NavigationEntry. * The main use case handled is when the user clicks on a suggested article and then back to view more suggestions. Maintaining scroll position helps maintain context and flow here. * It is the RecyclerView Adapter position that is stored and restored, so if the device is rotated in the meantime, scroll restore will still present the same content as long as the underlying data has not changed. * Because the underlying data is subject to change a few times per day, the scroll position is not persisted. It would be confusing the restore to an old position that now shows different content. BUG= 606356 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2327083002 Cr-Commit-Position: refs/heads/master@{#420075} [modify] https://crrev.com/22b18a9a6d4f421ddb6d4f74280a571bf7dca4f6/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java [modify] https://crrev.com/22b18a9a6d4f421ddb6d4f74280a571bf7dca4f6/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java [modify] https://crrev.com/22b18a9a6d4f421ddb6d4f74280a571bf7dca4f6/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java [modify] https://crrev.com/22b18a9a6d4f421ddb6d4f74280a571bf7dca4f6/chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java [modify] https://crrev.com/22b18a9a6d4f421ddb6d4f74280a571bf7dca4f6/content/browser/frame_host/navigation_controller_android.cc [modify] https://crrev.com/22b18a9a6d4f421ddb6d4f74280a571bf7dca4f6/content/browser/frame_host/navigation_controller_android.h [modify] https://crrev.com/22b18a9a6d4f421ddb6d4f74280a571bf7dca4f6/content/public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java [modify] https://crrev.com/22b18a9a6d4f421ddb6d4f74280a571bf7dca4f6/content/public/android/java/src/org/chromium/content_public/browser/NavigationController.java
,
Sep 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/651d3cce5637e5b1875468534b66325fc9f5dc92 commit 651d3cce5637e5b1875468534b66325fc9f5dc92 Author: hush <hush@chromium.org> Date: Wed Sep 21 20:18:07 2016 Revert of Ntp: restore scroll position. (patchset #9 id:160001 of https://codereview.chromium.org/2327083002/ ) Reason for revert: Broke org.chromium.chrome.browser.ntp.NewTabPageTest.* Original issue's description: > Ntp: restore scroll position. > > * The scroll position is stored as extra data on the NavigationEntry. > * The main use case handled is when the user clicks on a suggested > article and then back to view more suggestions. Maintaining scroll position helps maintain context and flow here. > * It is the RecyclerView Adapter position that is stored and restored, so if the device is rotated in the meantime, scroll restore will still present the same content as long as the underlying data has not changed. > * Because the underlying data is subject to change a few times per day, the scroll position is not persisted. It would be confusing the restore to an old position that now shows different content. > > BUG= 606356 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/22b18a9a6d4f421ddb6d4f74280a571bf7dca4f6 > Cr-Commit-Position: refs/heads/master@{#420075} TBR=bauerb@chromium.org,tedchoc@chromium.org,clamy@chromium.org,mvanouwerkerk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 606356 Review-Url: https://codereview.chromium.org/2363483002 Cr-Commit-Position: refs/heads/master@{#420146} [modify] https://crrev.com/651d3cce5637e5b1875468534b66325fc9f5dc92/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java [modify] https://crrev.com/651d3cce5637e5b1875468534b66325fc9f5dc92/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java [modify] https://crrev.com/651d3cce5637e5b1875468534b66325fc9f5dc92/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java [modify] https://crrev.com/651d3cce5637e5b1875468534b66325fc9f5dc92/chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java [modify] https://crrev.com/651d3cce5637e5b1875468534b66325fc9f5dc92/content/browser/frame_host/navigation_controller_android.cc [modify] https://crrev.com/651d3cce5637e5b1875468534b66325fc9f5dc92/content/browser/frame_host/navigation_controller_android.h [modify] https://crrev.com/651d3cce5637e5b1875468534b66325fc9f5dc92/content/public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java [modify] https://crrev.com/651d3cce5637e5b1875468534b66325fc9f5dc92/content/public/android/java/src/org/chromium/content_public/browser/NavigationController.java
,
Sep 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/651d3cce5637e5b1875468534b66325fc9f5dc92 commit 651d3cce5637e5b1875468534b66325fc9f5dc92 Author: hush <hush@chromium.org> Date: Wed Sep 21 20:18:07 2016 Revert of Ntp: restore scroll position. (patchset #9 id:160001 of https://codereview.chromium.org/2327083002/ ) Reason for revert: Broke org.chromium.chrome.browser.ntp.NewTabPageTest.* Original issue's description: > Ntp: restore scroll position. > > * The scroll position is stored as extra data on the NavigationEntry. > * The main use case handled is when the user clicks on a suggested > article and then back to view more suggestions. Maintaining scroll position helps maintain context and flow here. > * It is the RecyclerView Adapter position that is stored and restored, so if the device is rotated in the meantime, scroll restore will still present the same content as long as the underlying data has not changed. > * Because the underlying data is subject to change a few times per day, the scroll position is not persisted. It would be confusing the restore to an old position that now shows different content. > > BUG= 606356 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/22b18a9a6d4f421ddb6d4f74280a571bf7dca4f6 > Cr-Commit-Position: refs/heads/master@{#420075} TBR=bauerb@chromium.org,tedchoc@chromium.org,clamy@chromium.org,mvanouwerkerk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 606356 Review-Url: https://codereview.chromium.org/2363483002 Cr-Commit-Position: refs/heads/master@{#420146} [modify] https://crrev.com/651d3cce5637e5b1875468534b66325fc9f5dc92/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java [modify] https://crrev.com/651d3cce5637e5b1875468534b66325fc9f5dc92/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java [modify] https://crrev.com/651d3cce5637e5b1875468534b66325fc9f5dc92/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java [modify] https://crrev.com/651d3cce5637e5b1875468534b66325fc9f5dc92/chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java [modify] https://crrev.com/651d3cce5637e5b1875468534b66325fc9f5dc92/content/browser/frame_host/navigation_controller_android.cc [modify] https://crrev.com/651d3cce5637e5b1875468534b66325fc9f5dc92/content/browser/frame_host/navigation_controller_android.h [modify] https://crrev.com/651d3cce5637e5b1875468534b66325fc9f5dc92/content/public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java [modify] https://crrev.com/651d3cce5637e5b1875468534b66325fc9f5dc92/content/public/android/java/src/org/chromium/content_public/browser/NavigationController.java
,
Sep 23 2016
,
Sep 26 2016
Hey Michael - how's this piece coming along? We didn't have a chance to go over it in the weekly today. Any pending questions?
,
Sep 26 2016
My CL was reverted, but I could not reproduce the test failures locally, so I'm going to reland it.
,
Sep 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c78ced6c8ce46eec8c9f7100b14b3414b7cbc07 commit 2c78ced6c8ce46eec8c9f7100b14b3414b7cbc07 Author: mvanouwerkerk <mvanouwerkerk@chromium.org> Date: Mon Sep 26 15:53:28 2016 Reland: Ntp: restore scroll position. * The scroll position is stored as extra data on the NavigationEntry. * The main use case handled is when the user clicks on a suggested article and then back to view more suggestions. Maintaining scroll position helps maintain context and flow here. * It is the RecyclerView Adapter position that is stored and restored, so if the device is rotated in the meantime, scroll restore will still present the same content as long as the underlying data has not changed. * Because the underlying data is subject to change a few times per day, the scroll position is not persisted. It would be confusing the restore to an old position that now shows different content. BUG= 606356 TBR=clamy,bauerb,tedchoc CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/22b18a9a6d4f421ddb6d4f74280a571bf7dca4f6 Cr-Commit-Position: refs/heads/master@{#420075} patch from issue 2327083002 at patchset 160001 (http://crrev.com/2327083002#ps160001) Review-Url: https://codereview.chromium.org/2365313002 Cr-Commit-Position: refs/heads/master@{#420896} [modify] https://crrev.com/2c78ced6c8ce46eec8c9f7100b14b3414b7cbc07/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java [modify] https://crrev.com/2c78ced6c8ce46eec8c9f7100b14b3414b7cbc07/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java [modify] https://crrev.com/2c78ced6c8ce46eec8c9f7100b14b3414b7cbc07/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java [modify] https://crrev.com/2c78ced6c8ce46eec8c9f7100b14b3414b7cbc07/chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java [modify] https://crrev.com/2c78ced6c8ce46eec8c9f7100b14b3414b7cbc07/content/browser/frame_host/navigation_controller_android.cc [modify] https://crrev.com/2c78ced6c8ce46eec8c9f7100b14b3414b7cbc07/content/browser/frame_host/navigation_controller_android.h [modify] https://crrev.com/2c78ced6c8ce46eec8c9f7100b14b3414b7cbc07/content/public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java [modify] https://crrev.com/2c78ced6c8ce46eec8c9f7100b14b3414b7cbc07/content/public/android/java/src/org/chromium/content_public/browser/NavigationController.java
,
Sep 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14b97a44b845781fed2b493e948fd7d6509586df commit 14b97a44b845781fed2b493e948fd7d6509586df Author: khushalsagar <khushalsagar@chromium.org> Date: Mon Sep 26 19:35:07 2016 Revert of Reland: Ntp: restore scroll position. (patchset #2 id:20001 of https://codereview.chromium.org/2365313002/ ) Reason for revert: Breaks AndroidTests(Dbg: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/36381 Original issue's description: > Reland: Ntp: restore scroll position. > > * The scroll position is stored as extra data on the NavigationEntry. > * The main use case handled is when the user clicks on a suggested > article and then back to view more suggestions. Maintaining scroll position helps maintain context and flow here. > * It is the RecyclerView Adapter position that is stored and restored, so if the device is rotated in the meantime, scroll restore will still present the same content as long as the underlying data has not changed. > * Because the underlying data is subject to change a few times per day, the scroll position is not persisted. It would be confusing the restore to an old position that now shows different content. > > BUG= 606356 > TBR=clamy,bauerb,tedchoc > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/22b18a9a6d4f421ddb6d4f74280a571bf7dca4f6 > Cr-Commit-Position: refs/heads/master@{#420075} > > patch from issue 2327083002 at patchset 160001 (http://crrev.com/2327083002#ps160001) > > Committed: https://crrev.com/2c78ced6c8ce46eec8c9f7100b14b3414b7cbc07 > Cr-Commit-Position: refs/heads/master@{#420896} TBR=tedchoc@chromium.org,clamy@chromium.org,bauerb@chromium.org,mvanouwerkerk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 606356 Review-Url: https://codereview.chromium.org/2370023002 Cr-Commit-Position: refs/heads/master@{#420963} [modify] https://crrev.com/14b97a44b845781fed2b493e948fd7d6509586df/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java [modify] https://crrev.com/14b97a44b845781fed2b493e948fd7d6509586df/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java [modify] https://crrev.com/14b97a44b845781fed2b493e948fd7d6509586df/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java [modify] https://crrev.com/14b97a44b845781fed2b493e948fd7d6509586df/chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java [modify] https://crrev.com/14b97a44b845781fed2b493e948fd7d6509586df/content/browser/frame_host/navigation_controller_android.cc [modify] https://crrev.com/14b97a44b845781fed2b493e948fd7d6509586df/content/browser/frame_host/navigation_controller_android.h [modify] https://crrev.com/14b97a44b845781fed2b493e948fd7d6509586df/content/public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java [modify] https://crrev.com/14b97a44b845781fed2b493e948fd7d6509586df/content/public/android/java/src/org/chromium/content_public/browser/NavigationController.java
,
Sep 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b1519e7304f1a6d2f1c3e50c2d8a933e21f2806 commit 5b1519e7304f1a6d2f1c3e50c2d8a933e21f2806 Author: mvanouwerkerk <mvanouwerkerk@chromium.org> Date: Tue Sep 27 15:47:46 2016 Reland: Ntp: restore scroll position. * The scroll position is stored as extra data on the NavigationEntry. * The main use case handled is when the user clicks on a suggested article and then back to view more suggestions. Maintaining scroll position helps maintain context and flow here. * It is the RecyclerView Adapter position that is stored and restored, so if the device is rotated in the meantime, scroll restore will still present the same content as long as the underlying data has not changed. * Because the underlying data is subject to change a few times per day, the scroll position is not persisted. It would be confusing the restore to an old position that now shows different content. BUG= 606356 TBR=clamy,bauerb,tedchoc CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/22b18a9a6d4f421ddb6d4f74280a571bf7dca4f6 Cr-Commit-Position: refs/heads/master@{#420075} patch from issue 2327083002 at patchset 160001 (http://crrev.com/2327083002#ps160001) Committed: https://crrev.com/2c78ced6c8ce46eec8c9f7100b14b3414b7cbc07 Review-Url: https://codereview.chromium.org/2365313002 Cr-Original-Commit-Position: refs/heads/master@{#420896} Cr-Commit-Position: refs/heads/master@{#421223} [modify] https://crrev.com/5b1519e7304f1a6d2f1c3e50c2d8a933e21f2806/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java [modify] https://crrev.com/5b1519e7304f1a6d2f1c3e50c2d8a933e21f2806/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java [modify] https://crrev.com/5b1519e7304f1a6d2f1c3e50c2d8a933e21f2806/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java [modify] https://crrev.com/5b1519e7304f1a6d2f1c3e50c2d8a933e21f2806/chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java [modify] https://crrev.com/5b1519e7304f1a6d2f1c3e50c2d8a933e21f2806/content/browser/frame_host/navigation_controller_android.cc [modify] https://crrev.com/5b1519e7304f1a6d2f1c3e50c2d8a933e21f2806/content/browser/frame_host/navigation_controller_android.h [modify] https://crrev.com/5b1519e7304f1a6d2f1c3e50c2d8a933e21f2806/content/public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java [modify] https://crrev.com/5b1519e7304f1a6d2f1c3e50c2d8a933e21f2806/content/public/android/java/src/org/chromium/content_public/browser/NavigationController.java
,
Sep 29 2016
Removing the Zine UX tag since it looks like this doesn't currently need my input.
,
Oct 3 2016
Rachel: please review the current behavior, it is present in the Dev channel. If this is good enough for now, let's close it as Fixed. For later refinements we can open a new bug.
,
Oct 4 2016
Thanks! This LGTM.
,
Oct 4 2016
,
Oct 4 2016
,
Oct 14 2016
Verified on latest builds
,
Dec 8 2016
|
|||||||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||||||
Comment 1 by maybelle@chromium.org
, Apr 25 2016