New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 606343 link

Starred by 1 user
Status: Fixed
Owner:
danakj@chromium.org
Closed: Sep 2016
Cc:
danakj@chromium.org
█ jbau...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Compilation failure around gpu::SharedMemoryLimits

Project Member Reported by martina....@intel.com, Apr 25 2016 
I'm getting the error:

ninja -C out/Debug-gn obj/mojo/gles2/gles2/gles2_context.o 
../../mojo/gles2/gles2_context.cc:35:37: error: default initialization of an object of const type 'const gpu::SharedMemoryLimits' without a user-provided default constructor
  constexpr gpu::SharedMemoryLimits default_limits;

when trying to compile current master (013326065eb9cb09dd34). The issue probably originates from https://codereview.chromium.org/1900993002. I'm using clang 3.9.0.

GN config:
is_debug = true
is_component_build = true
use_debug_fission = false
enable_nacl = false
linux_use_bundled_binutils = false
clang_use_chrome_plugins = false
dcheck_always_on = true

It's a bit odd because gpu::SharedMemoryLimits initializes all fields, so it shouldn't need a constructor AFAIK.

Comment 1 by danakj@chromium.org, Apr 25 2016 

Why do you get this error but I don't and the bots don't?

linux_use_bundled_binutils = false ?

Comment 2 Deleted

Comment 3 by sl1pk...@gmail.com, Sep 29 2016 

same here in 55.0.2873.4 but only with clang 3.8.1 (archlinux). but with bundled clang (tools/clang/scripts/update.py) or GCC 6.2.1 build OK

in 55.0.2868.3 build ok with all compillers

greetings

Comment 4 by sl1pk...@gmail.com, Sep 29 2016 

[13963/26557] /usr/bin/clang++ -Qunused-arguments -MMD -MF obj/services/ui/public/cpp/internal/gles2_context.o.d -DGL_GLEXT_PROTOTYPES -DV8_DEPRECATION_WARNINGS -DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DNO_TCMALLOC -DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DUSE_PROPRIETARY_CODECS -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=282097-1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGL_GLEXT_PROTOTYPES -DUSE_GLX -DUSE_EGL -DSK_IGNORE_DW_GRAY_FIX -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_SUPPORT_GPU=1 -DENABLE_IPC_FUZZER -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_NOEXCEPT= -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -I../.. -Igen -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -Igen/shim_headers/zlib_shim -Igen/shim_headers/harfbuzz_shim -Igen/shim_headers/libpng_shim -Igen/shim_headers/libjpeg_shim -I../../third_party/khronos -I../../gpu -Igen/shim_headers/re2_shim -Igen/shim_headers/ffmpeg_shim -Igen/shim_headers/libvpx_shim -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -funwind-tables -fPIC -pipe -fcolor-diagnostics -fdebug-prefix-map=/tmp/makepkg/chromium-dev/src/chromium-55.0.2873.4=. -pthread -m64 -march=x86-64 -Wall -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -O2 -fno-ident -fdata-sections -ffunction-sections -g0 -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions -D_FORTIFY_SOURCE=2 -march=native -O2 -pipe -fstack-protector-strong -Wno-unknown-warning-option -c ../../services/ui/public/cpp/gles2_context.cc -o obj/services/ui/public/cpp/internal/gles2_context.o
FAILED: obj/services/ui/public/cpp/internal/gles2_context.o 
/usr/bin/clang++ -Qunused-arguments -MMD -MF obj/services/ui/public/cpp/internal/gles2_context.o.d -DGL_GLEXT_PROTOTYPES -DV8_DEPRECATION_WARNINGS -DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DNO_TCMALLOC -DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DUSE_PROPRIETARY_CODECS -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=282097-1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGL_GLEXT_PROTOTYPES -DUSE_GLX -DUSE_EGL -DSK_IGNORE_DW_GRAY_FIX -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_SUPPORT_GPU=1 -DENABLE_IPC_FUZZER -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_NOEXCEPT= -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -I../.. -Igen -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -Igen/shim_headers/zlib_shim -Igen/shim_headers/harfbuzz_shim -Igen/shim_headers/libpng_shim -Igen/shim_headers/libjpeg_shim -I../../third_party/khronos -I../../gpu -Igen/shim_headers/re2_shim -Igen/shim_headers/ffmpeg_shim -Igen/shim_headers/libvpx_shim -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -funwind-tables -fPIC -pipe -fcolor-diagnostics -fdebug-prefix-map=/tmp/makepkg/chromium-dev/src/chromium-55.0.2873.4=. -pthread -m64 -march=x86-64 -Wall -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -O2 -fno-ident -fdata-sections -ffunction-sections -g0 -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions -D_FORTIFY_SOURCE=2 -march=native -O2 -pipe -fstack-protector-strong -Wno-unknown-warning-option -c ../../services/ui/public/cpp/gles2_context.cc -o obj/services/ui/public/cpp/internal/gles2_context.o
../../services/ui/public/cpp/gles2_context.cc:49:37: error: default initialization of an object of const type 'const gpu::SharedMemoryLimits' without a user-provided default constructor
  constexpr gpu::SharedMemoryLimits default_limits;
                                    ^
                                                  {}
1 error generated.

Comment 5 by danakj@chromium.org, Sep 29 2016

Cc: jbau...@chromium.org
Owner: danakj@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac08df435d06f26f46ee25b1b962bbf71a160dc1

commit ac08df435d06f26f46ee25b1b962bbf71a160dc1
Author: danakj <danakj@chromium.org>
Date: Thu Sep 29 19:26:22 2016

gpu: Add default constructor to SharedMemoryLimits.

We get compiler errors due to missing a constructor.

R=jbauman@chromium.org
BUG= 606343 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2383633002
Cr-Commit-Position: refs/heads/master@{#421897}

[modify] https://crrev.com/ac08df435d06f26f46ee25b1b962bbf71a160dc1/gpu/command_buffer/client/shared_memory_limits.h

Comment 7 by danakj@chromium.org, Sep 29 2016

Status: Fixed (was: Started)
LMK if that doesn't fix.
►

Sign in to add a comment