New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 606322 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Languages doesn't get removed from chrome://translate-internals/ page after deleting it from chrome://settings/languages overlay.

Reported by vku...@etouch.net, Apr 25 2016

Issue description

Chrome Version:52.0.2715.0 (Official Build)3fae42f136f929251b627b2ae6300100afc8ab83-refs/heads/master@{#388964} (32/64-bit)
OS:Windows (7, 8, 10), Mac (10.10.5)(10.11.4),Linux (ubuntu 14.04 LTS)

What steps will reproduce the problem?
1.Launch chrome and navigate to chrome://settings/languages , add any two languages
2.Navigate to chrome://translate-internals/ observe the newly added languages appears.
3.Now switch to previous tab and remove any 1 language from chrome://settings/languages overlay.
4.Again switch to chrome://translate-internals/ tab and reload,observe

Actual:Languages doesn't get removed from chrome://translate-internals/ page after deleting it from chrome://settings/languages overlay (viceversa)

Expected:Languages should get removed from chrome://translate-internals/ page after deleting it from chrome://settings/languages overlay (viceversa)

This is a Non-regression issue seen from 'M32' series i.e 32.0.1658.2
 
Actual_Translate.mov
8.5 MB Download
Status: Untriaged (was: Unconfirmed)
marking as Untriaged and requesting dev team to look into this issue.
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 12 2016

Labels: -M-53 MovedFrom-53
This issue has been moved once and is lower than Pri-1. Removing the milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: claudiomagni@chromium.org
Removing a language from the Settings language list doesn't remove it from the translate_blocked_languages pref.

However, once it's removed from the language list, Chrome will once again prompt the user to translate sites in that language. Even though the language is still in translate_blocked_languages.

That's because we check the language list when deciding whether a language can be translated:

https://cs.chromium.org/chromium/src/components/translate/core/browser/translate_prefs.cc?type=cs&q=TranslatePrefs::CanTranslateLanguage

Claudio, any reason we can't just remove the language from the blacklist when it's removed from accept-languages?
This issue has been fixed in M65. So in about 2 weeks it should roll out to 100% users.

I've added the logic that removes the language from blacklist: 
https://cs.chromium.org/chromium/src/components/translate/core/browser/translate_prefs.cc?rcl=004ef60597343bb057c0268443abbca2f2266bc9&l=275
Status: Assigned (was: Untriaged)
Status: Fixed (was: Assigned)

Sign in to add a comment