New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 606285 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

git drover crashes when running in parallel

Project Member Reported by jochen@chromium.org, Apr 25 2016

Issue description

I was git drover'ing a CL and while waiting for gnumbd to do it's thing, I started a second git drover which also ended up waiting for gnumbd.

Once the first one landed, however, the second one crashed:

first git drover:
-----------------

Fetching pending ref refs/pending/branch-heads/2704...
Cherry-picking commit on top of pending ref...
Pushing commit to refs/pending/branch-heads/2704... It can take a while.
Commit pushed to pending ref successfully!

Waiting for commit to be landed on refs/branch-heads/2704...
(If you are impatient, you may Ctrl-C once without harm)
Found commit on refs/branch-heads/2704
Closing issue (you may be prompted for your codereview password)...

second git drover
-----------------

Fetching pending ref refs/pending/branch-heads/2704...
Cherry-picking commit on top of pending ref...
Pushing commit to refs/pending/branch-heads/2704... It can take a while.
Commit pushed to pending ref successfully!

Waiting for commit to be landed on refs/branch-heads/2704...
(If you are impatient, you may Ctrl-C once without harm)
Error: Command 'cl land --bypass-hooks' failed: Command '['git', 'cl', 'land', '--bypass-hooks']' returned non-zero exit status 1


 

Comment 1 by jochen@chromium.org, Apr 25 2016

Cc: tandrii@chromium.org
Cc: iannucci@chromium.org
Robbie, do you think this is git-drover killing other git processes,
or is it git cl land being confused?

Comment 3 by iannu...@google.com, Apr 25 2016

Is this 2 drovers in the same working directory?

I didn't actually write git-drover though, so I dunno if it does any anti-parallel stuff :/. It kinda looks like git-cl-land though.

Comment 4 by benhenry@google.com, Apr 27 2016

Components: Infra>Git
Labels: -Infra-Git

Comment 5 by jochen@chromium.org, Apr 27 2016

it's the same checkout, but I thought git drover creates it's own working directory?

Comment 6 by iannu...@google.com, Apr 27 2016

Components: -Infra>Git Infra>SDK
It's possible that git-drover actually manipulates refs in the .git folder, which could cause conflicts... I'm not sure though. I'm moving this over to Infra>SDK for further triage.
Cc: -tandrii@chromium.org
Status: Available (was: Untriaged)
Project Member

Comment 9 by sheriffbot@chromium.org, Sep 4 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: aga...@chromium.org
Status: Fixed (was: Untriaged)
The gerrit git drover now does no work locally -- it just makes API calls to Gerrit. This should no longer be a problem.

Sign in to add a comment