Remove obsolete PageCyclerV1 page sets |
|||||||||
Issue descriptionWe have a lot of obsolete PCv1 page sets. Let's remove it.
,
Apr 25 2016
,
Apr 25 2016
+msheets: Which page sets is CrOS still using?
,
Apr 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/599a55f4169c18ff43626a89b92d6695e2b91a32 commit 599a55f4169c18ff43626a89b92d6695e2b91a32 Author: kouhei <kouhei@chromium.org> Date: Mon Apr 25 14:51:54 2016 Remove DhtmlPageSet DhtmlPageSet is currently only used on ChromeOS bots, and contains super old artificial tests inherited from Mozilla. Now speed-infra CrOS bots are capable of running regular page_sets like typical_25, remove the DHTML page set and its page cycler v1 benchmark per comment. BUG= 606277 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Review URL: https://codereview.chromium.org/1920773002 Cr-Commit-Position: refs/heads/master@{#389476} [modify] https://crrev.com/599a55f4169c18ff43626a89b92d6695e2b91a32/tools/perf/benchmarks/page_cycler.py [delete] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/tools/perf/page_sets/page_cycler/dhtml.py
,
Apr 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/599a55f4169c18ff43626a89b92d6695e2b91a32 commit 599a55f4169c18ff43626a89b92d6695e2b91a32 Author: kouhei <kouhei@chromium.org> Date: Mon Apr 25 14:51:54 2016 Remove DhtmlPageSet DhtmlPageSet is currently only used on ChromeOS bots, and contains super old artificial tests inherited from Mozilla. Now speed-infra CrOS bots are capable of running regular page_sets like typical_25, remove the DHTML page set and its page cycler v1 benchmark per comment. BUG= 606277 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Review URL: https://codereview.chromium.org/1920773002 Cr-Commit-Position: refs/heads/master@{#389476} [modify] https://crrev.com/599a55f4169c18ff43626a89b92d6695e2b91a32/tools/perf/benchmarks/page_cycler.py [delete] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/tools/perf/page_sets/page_cycler/dhtml.py
,
Apr 26 2016
The only page sets we are using for Crosbolt are typical_25 and top_25_smooth (although this is for smoothness rather than page_cycler tests). Others may be currently used in CrOS test code somewhere, but as far as I know they are not regularly run.
,
May 5 2016
Kouhei@: What are other benchmarks to be deleted?
,
May 6 2016
+Annie: once Kouhei done deleting these benchmark, can you help clean up their data from the perf dashboard?
,
May 6 2016
I can do that. But are we sure we won't want to look at the historical data? It's not a problem from a cost/maintenance perspective to keep it around, although from a UI perspective people do get confused sometimes when they see a test in the menu and there is no new data for it.
,
May 6 2016
According to kouhei@, those pages are badly obsolete, so I don't think people care much. Would be nice if the dashboard has s.t like <button>Also show abandoned benchmarks</button> for this historical use case, but I can see we are quite swamped :P
,
May 9 2016
I'm sure there are more, but I haven't been allocating much time on this. Feel free to ping me / take this bug when you want this done faster.
,
May 9 2016
Sure, just let me know the name of the benchmarks to be deleted & I can handle the rest :-)
,
May 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c62d2bd321645e5054b86de8fb0509d846420b86 commit c62d2bd321645e5054b86de8fb0509d846420b86 Author: dtu <dtu@chromium.org> Date: Fri May 13 03:39:37 2016 Disable page_cycler.morejs. This is the last remaining benchmark that depends on src-internal, and we're going to deprecate it. I'd like to clean up that gclient config. TBR=kouhei BUG= 606277 , 611484 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Review-Url: https://codereview.chromium.org/1967363004 Cr-Commit-Position: refs/heads/master@{#393442} [modify] https://crrev.com/c62d2bd321645e5054b86de8fb0509d846420b86/tools/perf/benchmarks/page_cycler.py
,
May 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89829b85f836e164584ecf88d9de8584427eb13d commit 89829b85f836e164584ecf88d9de8584427eb13d Author: nednguyen <nednguyen@google.com> Date: Fri May 13 07:54:24 2016 Remove page_cycler.morejs benchmark & morejs pageset BUG= 606277 , 611484 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Review-Url: https://codereview.chromium.org/1979433002 Cr-Commit-Position: refs/heads/master@{#393466} [modify] https://crrev.com/89829b85f836e164584ecf88d9de8584427eb13d/tools/perf/benchmarks/page_cycler.py [delete] https://crrev.com/9b33018fcf78d2ce335eb43c431d922b708eb05f/tools/perf/page_sets/page_cycler/morejs.py [delete] https://crrev.com/9b33018fcf78d2ce335eb43c431d922b708eb05f/tools/perf/page_sets/page_cycler/morejsnp.py
,
May 18 2016
,
May 19 2016
,
May 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98f0b00ab26bf5994d40a82c2bf6c803523a2c3a commit 98f0b00ab26bf5994d40a82c2bf6c803523a2c3a Author: kouhei <kouhei@chromium.org> Date: Thu May 19 03:12:03 2016 Remove Moz{,2}Pageset and its pcv1 benchmark MozPageSet is currently only used on ChromeOS bots, and contains super old artificial tests inherited from Mozilla. Moz2PageSet isn't used in any telemetry benchmarks. Now speed-infra CrOS bots are capable of running regular page_sets like typical_25, remove the page set and its page cycler v1 benchmark per comment. BUG= 606277 Review-Url: https://codereview.chromium.org/1998453003 Cr-Commit-Position: refs/heads/master@{#394646} [modify] https://crrev.com/98f0b00ab26bf5994d40a82c2bf6c803523a2c3a/tools/perf/benchmarks/page_cycler.py [delete] https://crrev.com/6165ca0c38af8740c831b65ad79655933c0ceb5d/tools/perf/page_sets/page_cycler/moz.py [delete] https://crrev.com/6165ca0c38af8740c831b65ad79655933c0ceb5d/tools/perf/page_sets/page_cycler/moz2.py
,
May 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/beabaaccf1caaf177427b399e1c8640a9b64b384 commit beabaaccf1caaf177427b399e1c8640a9b64b384 Author: nednguyen <nednguyen@google.com> Date: Thu May 19 03:21:30 2016 Remove some page_cycler benchmarks that have been disabled for a long time BUG= 606277 , 443730 Review-Url: https://codereview.chromium.org/1997523002 Cr-Commit-Position: refs/heads/master@{#394651} [modify] https://crrev.com/beabaaccf1caaf177427b399e1c8640a9b64b384/tools/perf/benchmarks/page_cycler.py [delete] https://crrev.com/2eb9a83d0f53707c230eb0d6c41215001da3c0fa/tools/perf/page_sets/big_js.py [delete] https://crrev.com/2eb9a83d0f53707c230eb0d6c41215001da3c0fa/tools/perf/page_sets/data/big_js.json [delete] https://crrev.com/2eb9a83d0f53707c230eb0d6c41215001da3c0fa/tools/perf/page_sets/data/big_js_000.wpr.sha1 [delete] https://crrev.com/2eb9a83d0f53707c230eb0d6c41215001da3c0fa/tools/perf/page_sets/data/big_js_001.wpr.sha1
,
May 19 2016
Kouhei carefully reviewed all the existing page cycler last nights & we already deleted all benchmarks that no longer matter. @Koheui: for pcv2, it's probably still a good idea to merge all the international URL cases together.
,
Jul 31 2016
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by sullivan@chromium.org
, Apr 25 2016