New issue
Advanced search Search tips

Issue 606277 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 575762



Sign in to add a comment

Remove obsolete PageCyclerV1 page sets

Project Member Reported by kouhei@chromium.org, Apr 25 2016

Issue description

We have a lot of obsolete PCv1 page sets. Let's remove it.
 
Let me know if I can be of any assistance with this (unblocking, etc). I agree these page sets are quite dated.

One thing to note when updating page cyclers: I'm sure we'll want to continue testing many languages, although we may well pick a different subset than the current set has. We used to put all the pages from every language into one page cycler. This ended up making them over-exercise the font cache, as it switched languages *much* faster than any real-world use case. So whatever languages we choose to test, we'll want to try and ensure we don't over-test the font cache in this fashion.
Cc: nedngu...@google.com
Cc: mshe...@chromium.org
+msheets: Which page sets is CrOS still using?
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/599a55f4169c18ff43626a89b92d6695e2b91a32

commit 599a55f4169c18ff43626a89b92d6695e2b91a32
Author: kouhei <kouhei@chromium.org>
Date: Mon Apr 25 14:51:54 2016

Remove DhtmlPageSet

DhtmlPageSet is currently only used on ChromeOS bots, and contains super old artificial tests inherited from Mozilla.

Now speed-infra CrOS bots are capable of running regular page_sets like typical_25, remove the DHTML page set and its page cycler v1 benchmark per comment.

BUG= 606277 
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Review URL: https://codereview.chromium.org/1920773002

Cr-Commit-Position: refs/heads/master@{#389476}

[modify] https://crrev.com/599a55f4169c18ff43626a89b92d6695e2b91a32/tools/perf/benchmarks/page_cycler.py
[delete] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/tools/perf/page_sets/page_cycler/dhtml.py

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 25 2016

Labels: merge-merged-2716
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/599a55f4169c18ff43626a89b92d6695e2b91a32

commit 599a55f4169c18ff43626a89b92d6695e2b91a32
Author: kouhei <kouhei@chromium.org>
Date: Mon Apr 25 14:51:54 2016

Remove DhtmlPageSet

DhtmlPageSet is currently only used on ChromeOS bots, and contains super old artificial tests inherited from Mozilla.

Now speed-infra CrOS bots are capable of running regular page_sets like typical_25, remove the DHTML page set and its page cycler v1 benchmark per comment.

BUG= 606277 
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Review URL: https://codereview.chromium.org/1920773002

Cr-Commit-Position: refs/heads/master@{#389476}

[modify] https://crrev.com/599a55f4169c18ff43626a89b92d6695e2b91a32/tools/perf/benchmarks/page_cycler.py
[delete] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/tools/perf/page_sets/page_cycler/dhtml.py

The only page sets we are using for Crosbolt are typical_25 and top_25_smooth (although this is for smoothness rather than page_cycler tests).

Others may be currently used in CrOS test code somewhere, but as far as I know they are not regularly run.
Kouhei@: What are other benchmarks to be deleted?
Cc: sullivan@chromium.org
+Annie: once Kouhei done deleting these benchmark, can you help clean up their data from the perf dashboard?
I can do that. But are we sure we won't want to look at the historical data? It's not a problem from a cost/maintenance perspective to keep it around, although from a UI perspective people do get confused sometimes when they see a test in the menu and there is no new data for it.
According to kouhei@, those pages are badly obsolete, so I don't think people care much.
Would be nice if the dashboard has s.t like <button>Also show abandoned benchmarks</button> for this historical use case, but I can see we are quite swamped :P
I'm sure there are more, but I haven't been allocating much time on this. Feel free to ping me / take this bug when you want this done faster.
Sure, just let me know the name of the benchmarks to be deleted & I can handle the rest :-)
Project Member

Comment 13 by bugdroid1@chromium.org, May 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c62d2bd321645e5054b86de8fb0509d846420b86

commit c62d2bd321645e5054b86de8fb0509d846420b86
Author: dtu <dtu@chromium.org>
Date: Fri May 13 03:39:37 2016

Disable page_cycler.morejs.

This is the last remaining benchmark that depends on src-internal, and we're going to deprecate it.
I'd like to clean up that gclient config.

TBR=kouhei
BUG= 606277 ,  611484 
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Review-Url: https://codereview.chromium.org/1967363004
Cr-Commit-Position: refs/heads/master@{#393442}

[modify] https://crrev.com/c62d2bd321645e5054b86de8fb0509d846420b86/tools/perf/benchmarks/page_cycler.py

Project Member

Comment 14 by bugdroid1@chromium.org, May 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89829b85f836e164584ecf88d9de8584427eb13d

commit 89829b85f836e164584ecf88d9de8584427eb13d
Author: nednguyen <nednguyen@google.com>
Date: Fri May 13 07:54:24 2016

Remove page_cycler.morejs benchmark & morejs pageset

BUG= 606277 ,  611484 
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Review-Url: https://codereview.chromium.org/1979433002
Cr-Commit-Position: refs/heads/master@{#393466}

[modify] https://crrev.com/89829b85f836e164584ecf88d9de8584427eb13d/tools/perf/benchmarks/page_cycler.py
[delete] https://crrev.com/9b33018fcf78d2ce335eb43c431d922b708eb05f/tools/perf/page_sets/page_cycler/morejs.py
[delete] https://crrev.com/9b33018fcf78d2ce335eb43c431d922b708eb05f/tools/perf/page_sets/page_cycler/morejsnp.py

Blocking: 575762
Owner: nedngu...@google.com
Labels: -Pri-3 Pri-1
Project Member

Comment 17 by bugdroid1@chromium.org, May 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98f0b00ab26bf5994d40a82c2bf6c803523a2c3a

commit 98f0b00ab26bf5994d40a82c2bf6c803523a2c3a
Author: kouhei <kouhei@chromium.org>
Date: Thu May 19 03:12:03 2016

Remove Moz{,2}Pageset and its pcv1 benchmark

MozPageSet is currently only used on ChromeOS bots, and contains super old
artificial tests inherited from Mozilla.
Moz2PageSet isn't used in any telemetry benchmarks.

Now speed-infra CrOS bots are capable of running regular page_sets like
typical_25, remove the page set and its page cycler v1 benchmark per
comment.

BUG= 606277 

Review-Url: https://codereview.chromium.org/1998453003
Cr-Commit-Position: refs/heads/master@{#394646}

[modify] https://crrev.com/98f0b00ab26bf5994d40a82c2bf6c803523a2c3a/tools/perf/benchmarks/page_cycler.py
[delete] https://crrev.com/6165ca0c38af8740c831b65ad79655933c0ceb5d/tools/perf/page_sets/page_cycler/moz.py
[delete] https://crrev.com/6165ca0c38af8740c831b65ad79655933c0ceb5d/tools/perf/page_sets/page_cycler/moz2.py

Owner: kouhei@chromium.org
Status: Fixed (was: Started)
Kouhei carefully reviewed all the existing page cycler last nights & we already deleted all benchmarks that no longer matter.

@Koheui: for pcv2, it's probably still a good idea to merge all the international URL cases together.
Cc: -mshe...@chromium.org

Sign in to add a comment