New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 606264 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

[Regression]: Uber tray is missing while creating supervised user

Project Member Reported by sc00335...@techmahindra.com, Apr 25 2016

Issue description

Version: 52.0.2715.0/8239.0.0 (Official Build) dev-channel daisy,peppy,gnawty
OS: Chrome os

What steps will reproduce the problem?
(1) Add a person >> Sign in and sign out of the user >> From 3 dot menu on shelf add supervised user
(2) Sign in with correct password so that overlay to create supervised user user appears >> Now observe for uber tray

Expected: Uber tray should be seen while creating supervised user
Actual: Instead uber tray is seen missing.

NOTE: On enabling on screen keyboard from accessibility it is shown in uber tray, but shelf options and shut down options are not seen.

This is a regression issue broken as it is working fine in 49.0.2623.112/7834.70.0 stable-channel Daisy.
 
Expected.jpg
1.5 MB View Download
Actual_when onscreen is present.jpg
2.6 MB View Download
Actual_whenonscreen not present.jpg
2.4 MB View Download
Issue is also seen in 50.0.2661.84/7978.60.0 beta channel daisy.

Comment 2 by finkm@google.com, Apr 25 2016

@UI folks: IIRC we (supervised user) haven't changed anything. Would you mind having a look? Thanks!

Comment 3 by ajha@chromium.org, Apr 25 2016

Cc: pucchakayala@chromium.org
Labels: ReleaseBlock-Stable
Status: Untriaged (was: Unconfirmed)
Able to reproduce this on 52.0.2715.0/8239.0.0 dev-channel gnawty.


Labels: -Pri-1 Pri-2
Owner: warx@chromium.org
Status: Assigned (was: Untriaged)

Comment 5 by warx@chromium.org, Apr 27 2016

Cc: -ajha@chromium.org jdufault@chromium.org
According to crbug/532545 comment 17, hiding tray shelf is intentional; and I think we should also leave the onscreen keyboard icon there as it is a needed a11y setting for manager's input.
What happens to the onscreen keyboard icon when the owners shelf position is set to be on the side?

If the keyboard icon moves to an edge, we should implement a different solution than hiding the shelf. Otherwise, I agree with warx@ and think the current behavior is fine.

Comment 7 by warx@chromium.org, Apr 27 2016

Interesting. We might need to polish it. (1) First, it only shows onscreen_keyboard, (2) if we activate onscreen_keyboard one time to use, then "shut down" icon and shelf will appear and overlap with onscreen_keyboard


first_just enter the creation screen.png
1.5 MB View Download
second_when onscreen is used one time.png
1.5 MB View Download
Cc: dzhioev@chromium.org
For fixing the edge case, I think there are two paths forward:

  1: Prevent the keyboard icon from showing up.
  2: Revert [1] which hides the uber tray and instead ensure the uber tray always
     appears on the bottom.  Bug 532545  has important context.

For approach #2, then patch set 1 of code review [2] will force the shelf to always be on the bottom.

1: https://codereview.chromium.org/1623603002
2: https://codereview.chromium.org/1539713002/#ps1
Labels: -ReleaseBlock-Stable
I don't think this should block 52
Project Member

Comment 10 by sheriffbot@chromium.org, Jun 11 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 11 by warx@chromium.org, Jul 7 2016

Besides the virtual keyboard tray, notification tray now also has the same behavior as comment 7.
There is now SHELF_ALIGNMENT_BOTTOM_LOCKED[1] that should do exactly what is needed here; force the shelf to the bottom without saving to prefs.

If that's used instead, we should be able to eliminate all of the edge cases in this bug and restore the original behavior.

1: https://cs.chromium.org/chromium/src/ash/common/shelf/shelf_types.h?l=17
Project Member

Comment 13 by bugdroid1@chromium.org, Jul 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d5ca54363346df10c557d96215cd228b1a93c45

commit 8d5ca54363346df10c557d96215cd228b1a93c45
Author: warx <warx@chromium.org>
Date: Fri Jul 08 16:58:22 2016

Set ShelfAlignment on supervised user creation page to BOTTOM_LOCKED

(1) first revert the hide solution in https://codereview.chromium.org/1623603002

(2) on supervised user creation page, set shelf alignment to BOTTOM_LOCKED.

BUG= 606264 
TEST=on supervised user creation page, shelf is no longer hidden, but set to bottom aligned. The user alignment pref is maintained after login (that is to say, left is still left).

Review-Url: https://codereview.chromium.org/2129013002
Cr-Commit-Position: refs/heads/master@{#404418}

[modify] https://crrev.com/8d5ca54363346df10c557d96215cd228b1a93c45/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc
[modify] https://crrev.com/8d5ca54363346df10c557d96215cd228b1a93c45/chrome/browser/chromeos/login/ui/webui_login_view.cc

Comment 14 by warx@chromium.org, Jul 8 2016

Status: Fixed (was: Assigned)
thanks to jdufault@'s suggestion
Status: Verified (was: Fixed)
Verified on ChromeOS 8697.0.0, 54.0.2826.0
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-53; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-53 label, otherwise remove Merge-TBD label. Thanks.

Comment 17 by warx@chromium.org, Oct 3 2016

Cc: keta...@chromium.org
Hi Ketaki, as described in comment 16, this CL is landed on Jul 8, which is after the m53 branch point. Is a merge necessary?

Comment 18 by warx@chromium.org, Oct 3 2016

Labels: -Merge-TBD
Since m54 is coming soon, and this is not a critical bug.

Removing merge-tbd. 

Sign in to add a comment