New issue
Advanced search Search tips

Issue 606247 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

12.5% regression in blink_perf.bindings at 388987:388997

Project Member Reported by toyoshim@chromium.org, Apr 25 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=606247

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgpMintgsM


Bot(s) for this bug's original alert(s):

chromium-rel-mac-retina
Cc: toyoshim@chromium.org
 Issue 606244  has been merged into this issue.
Note: many DOM related tests seem to have a regression at the same revision, and are set to have this bug ID. See the group report link.
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Apr 25 2016

Cc: dgozman@chromium.org
Owner: dgozman@chromium.org

=== Auto-CCing suspected CL author dgozman@chromium.org ===

Hi dgozman@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : [DevTools] Move from InstrumentingAgents to InstrumentingSessions.
Author  : dgozman
Commit description:
  
InspectorSession now holds auto-generated InstrumentingAgents instance.

InspectorInstrumentation fetches InstrumentingSessions from different entities and
then calls into agents in each session. This could potentially speed up instrumentation
when inspector is not attached: we only have InspectorSession objects when attached,
while InstrumentingAgents object was always present before.

BUG= 590878 

Review URL: https://codereview.chromium.org/1903953002

Cr-Commit-Position: refs/heads/master@{#388992}
Commit  : 946af3c81704defad704e49046c65e29ccd5f5dd
Date    : Fri Apr 22 01:15:35 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@388986         837.275016  2.934838    5           good
chromium@388989         830.878249  5.064682    5           good
chromium@388991         813.236364  5.109727    5           good
chromium@388992         708.894103  3.222357    5           bad         <-
chromium@388997         700.264178  3.117202    5           bad

Bisect job ran on: mac_retina_perf_bisect
Bug ID: 606247

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.bindings
Test Metric: set-attribute/set-attribute
Relative Change: 16.36%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_bisect/builds/1261
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9014430924050845696


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=606247

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4e025c3657c27292c63486b00c163ae63e25e63

commit e4e025c3657c27292c63486b00c163ae63e25e63
Author: dgozman <dgozman@chromium.org>
Date: Thu Apr 28 22:57:35 2016

[DevTools] Improve performance of InstrumentingAgents.

This patch moves from set of InstrumentingAgents to multiple
per-agent sets of instrumenting agents. This should speed up
instrumentation in case only some of the agents are enabled.

BUG= 606247 

Review-Url: https://codereview.chromium.org/1924173002
Cr-Commit-Position: refs/heads/master@{#390526}

[modify] https://crrev.com/e4e025c3657c27292c63486b00c163ae63e25e63/third_party/WebKit/Source/core/core.gypi
[modify] https://crrev.com/e4e025c3657c27292c63486b00c163ae63e25e63/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/e4e025c3657c27292c63486b00c163ae63e25e63/third_party/WebKit/Source/core/frame/LocalFrame.h
[modify] https://crrev.com/e4e025c3657c27292c63486b00c163ae63e25e63/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py
[modify] https://crrev.com/e4e025c3657c27292c63486b00c163ae63e25e63/third_party/WebKit/Source/core/inspector/InspectedFrames.cpp
[modify] https://crrev.com/e4e025c3657c27292c63486b00c163ae63e25e63/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp
[modify] https://crrev.com/e4e025c3657c27292c63486b00c163ae63e25e63/third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.cpp
[modify] https://crrev.com/e4e025c3657c27292c63486b00c163ae63e25e63/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
[modify] https://crrev.com/e4e025c3657c27292c63486b00c163ae63e25e63/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp
[modify] https://crrev.com/e4e025c3657c27292c63486b00c163ae63e25e63/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/e4e025c3657c27292c63486b00c163ae63e25e63/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp
[modify] https://crrev.com/e4e025c3657c27292c63486b00c163ae63e25e63/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp
[modify] https://crrev.com/e4e025c3657c27292c63486b00c163ae63e25e63/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h
[modify] https://crrev.com/e4e025c3657c27292c63486b00c163ae63e25e63/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp
[modify] https://crrev.com/e4e025c3657c27292c63486b00c163ae63e25e63/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
[modify] https://crrev.com/e4e025c3657c27292c63486b00c163ae63e25e63/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp
[modify] https://crrev.com/e4e025c3657c27292c63486b00c163ae63e25e63/third_party/WebKit/Source/core/inspector/InspectorSession.cpp
[modify] https://crrev.com/e4e025c3657c27292c63486b00c163ae63e25e63/third_party/WebKit/Source/core/inspector/InspectorSession.h
[modify] https://crrev.com/e4e025c3657c27292c63486b00c163ae63e25e63/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp
[delete] https://crrev.com/10b9175edd735bd07b76540fb706ba6fbe4eff41/third_party/WebKit/Source/core/inspector/InstrumentingSessions.h
[modify] https://crrev.com/e4e025c3657c27292c63486b00c163ae63e25e63/third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp
[modify] https://crrev.com/e4e025c3657c27292c63486b00c163ae63e25e63/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
[modify] https://crrev.com/e4e025c3657c27292c63486b00c163ae63e25e63/third_party/WebKit/Source/core/inspector/WorkerInspectorController.h
[modify] https://crrev.com/e4e025c3657c27292c63486b00c163ae63e25e63/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/e4e025c3657c27292c63486b00c163ae63e25e63/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h

It looks like all graphs have recovered (at least partially), but let's wait a bit more.
Labels: Needs-Feedback TE-Triaged
dgozman@ : Could you please take a look into this and update further as the alerts seems to be recovered.
Status: Fixed (was: Assigned)

Sign in to add a comment