New issue
Advanced search Search tips

Issue 606206 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

"Turn off" button in first run experience for the credential manager on Android doesn't work.

Project Member Reported by melandory@chromium.org, Apr 24 2016

Issue description

"Turn off" button in first run experience for the credential manager on Android doesn't work.

Expected behavior: after button is clicked credentials_enable_autosignin has value false
Observed: credentials_enable_autosignin doesn't change its value
 
Labels: Merge-Request-51

Comment 3 by tin...@google.com, Apr 25 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 25 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/104930a015639e64b33f7cb5fed66ffadba844eb

commit 104930a015639e64b33f7cb5fed66ffadba844eb
Author: Tatiana Gornak <melandory@chromium.org>
Date: Mon Apr 25 13:31:21 2016

[Smart Lock] Fix "turn off" button in auto-signin first run experience.

BUG= 606206 

Review URL: https://codereview.chromium.org/1917713003

Cr-Commit-Position: refs/heads/master@{#389457}
(cherry picked from commit da55ab76c24c3da0179daddc424443a1328e9abd)

Review URL: https://codereview.chromium.org/1917813002 .

Cr-Commit-Position: refs/branch-heads/2704@{#213}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/104930a015639e64b33f7cb5fed66ffadba844eb/chrome/browser/password_manager/auto_signin_first_run_dialog_android_unittest.cc
[modify] https://crrev.com/104930a015639e64b33f7cb5fed66ffadba844eb/components/password_manager/core/browser/password_bubble_experiment.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified fix in M51 - 51.0.2704.28.
Thanks!

Sign in to add a comment