Command-line Gerrit tools will break after Uberproxy exception expires |
|||||
Issue descriptionThe 'gerrit' tool used by developers to mark CLs as commit ready will stop working after the Uberproxy exception expires in 1 week (see https://buganizer.corp.google.com/u/0/issues/26286530 ) The Android gerrit tool is fully capable of handling Uberproxy auth but the ChromeOS one doesn't. Aviv, could you find someone to take a look?
,
Apr 25 2016
How many people use this routinely? Any idea what it would take to make this uberproxy compatible?
,
Apr 25 2016
pretty sure a good number of people use `gerrit` regularly as it's the only way to process a lot of CLs quickly i thought there was a bug filed at some point about adding SSO support to gerrit, but i can't seem to find it. see this thread at least: https://groups.google.com/a/google.com/d/msg/gerritcodereview-team/1p697bSBy4g/ltaUTHAdAgAJ
,
Apr 25 2016
We don't specifically need to fix the gerrit tool, but people will need a replacement at least to have some way of marking their CLs ready quickly. The Android tool could work well for this with a few quick tweaks.
,
Dec 5 2016
i've posted some CLs to support SSO
,
Jan 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/277bfa409c6d55f7f41cfee7926fd5ef90a29aeb commit 277bfa409c6d55f7f41cfee7926fd5ef90a29aeb Author: Mike Frysinger <vapier@chromium.org> Date: Fri Dec 02 19:51:27 2016 patch: handle gerrit results that omit http/https results When dealing with GoB instances that do not support http or https (and only support sso), the patch walking loader fails since it always assumes http is available. Rework the code to walk a bunch of known protocols instead and stop when we find one that works. BUG= chromium:606168 TEST=`gerrit -g googleplex-android inspect 825814` doesn't fail on patch parsing Change-Id: Id7338b973f566254459350a6b708c96fbdf4f8b7 Reviewed-on: https://chromium-review.googlesource.com/416328 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/277bfa409c6d55f7f41cfee7926fd5ef90a29aeb/lib/patch_unittest.py [modify] https://crrev.com/277bfa409c6d55f7f41cfee7926fd5ef90a29aeb/lib/patch.py
,
Mar 9 2018
,
Mar 27 2018
Obsolete, as far as I know. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by akes...@chromium.org
, Apr 25 2016