OnRequestREloadImageForContextNode code is doing Blink-ey things |
|||||
Issue description
This code seems to be up a layer from where it needs to be. Need to investigate where the right place should be:
WebNode context_node = frame->contextMenuNode();
if (!context_node.isNull() && context_node.isElementNode()) {
frame->reloadImage(context_node);
}
,
Jan 27 2017
,
May 10 2017
Memo: the code above is currently in ChromeRenderFrameObserver::RequestReloadImageForContextNode() in chrome/renderer/chrome_render_frame_observer.cc. Related to this code path: esprehn@ left comments about ReloadImage() interface, which were not reflected: https://codereview.chromium.org/1112513005#msg39 Also, this code path is not tested (including HTMLImageElement::ForceReload() that is called inside ReloadImage()). (I'm adding a test that covers HTMLImageElement::ForceReload() but not the code above)
,
May 11 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 11 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by tkent@chromium.org
, Jun 23 2016