New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 606163 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Chrome doesn't remember the pulseaudio sink choice

Reported by nia...@gmail.com, Apr 23 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.75 Safari/537.36

Example URL:

Steps to reproduce the problem:
1. Open audio stream
2. Pick a different sink in pulseaudio
3. Close audio stream, wait for chrome to disconnect from pulseaudio
4. Reopen audio stream

What is the expected behavior?
The sink chosen should be used

What went wrong?
Chrome revert back to the first sink instead.

Did this work before? N/A 

Is it a problem with Flash or HTML5? Both

Does this work in other browsers? Yes 

Chrome version: 51  Channel: beta
OS Version: 
Flash Version: Shockwave Flash 21.0 r0

Setting the default sink in pulseaudio doesn't solve this problem.

Looks like chrome just pick the sink with the smallest ID.
 
Labels: Needs-Feedback
is this flash or html5?

Comment 2 by nia...@gmail.com, Apr 26 2016

Both flash and html5 have this problem
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 27 2016

Labels: -Needs-Feedback Needs-Review
Owner: yini...@chromium.org
Thank you for providing more feedback. Adding requester "yiningc@chromium.org" for another review and adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by nia...@gmail.com, May 9 2016

This problem is related to  Issue #343839 :

That is a bad idea, using system default sink will ignore user preference, which is annoying.

Comment 5 by nia...@gmail.com, May 9 2016

Another odd thing is that if I build chromium myself (linked against libpulse on my system), chromium starts picking up the default sink in PulseAudio. Whereas the official chrome build from the dev channel (libpulse statically linked??) doesn't use the default sink.
Cc: yini...@chromium.org
Components: -Internals>Media Internals>Media>Audio
Owner: dalecur...@chromium.org
Status: Assigned (was: Unconfirmed)
Dale, is this chrome related bug? it sounds platform related. Can you confirm and re-assign?
Cc: dalecur...@chromium.org
Owner: ----
Status: Unconfirmed (was: Assigned)
Cc: guidou@chromium.org rchtara@chromium.org

Comment 9 by guidou@chromium.org, May 16 2016

Cc: grunell@chromium.org
Labels: Needs-Feedback
To use the system default device instead of the application default was an intentional change (as pointed to in comment #4). It has not yet made it to stable, hence different behavior there.

nialv7: To understand the problem more, what is the use case when you want to select and remember a different output device for Chrome than the system default? If you want to change the output device for all audio, the system audio settings would normally be changed.

Comment 11 by nia...@gmail.com, May 17 2016

I don't think the difference in behavior is version related. I tested chromium 51 (which I built against system libpulse) and chrome from both dev and beta channel. Chromium 51 will pick the system default, and chrome doesn't seems to honor the default sink setting. 

As for use case, I have multiple laptops and I route audio over network using pulseaudio. So sinks can come and go, the default sink is not always what I want. Also sometimes I only want to route chrome's audio without affecting other applications 

Comment 12 by nia...@gmail.com, May 17 2016

It even says in the pulseaudio document that you should use NULL for dev: https://freedesktop.org/software/pulseaudio/doxygen/stream_8h.html#ab9544f6677af133fbe81bf8a21eb489c
Project Member

Comment 13 by sheriffbot@chromium.org, May 18 2016

Labels: -Needs-Feedback
Owner: grunell@chromium.org
Thank you for providing more feedback. Adding requester "grunell@chromium.org" for another review and adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: tommi@chromium.org
Labels: -Needs-Review M-52
Status: Fixed (was: Unconfirmed)
I think the problem described in the use case in comment #11 warrants a revert of the change we did earlier. We'll have to revisit the original need for making that change.
Labels: -M-52 Merge-Request-51 M-51
Requesting merge for the revert in comment #14. This is a low risk merge, it takes us back to previous behavior.
Cc: sshruthi@chromium.org
Labels: -Merge-Request-51 Merge-Approved-51
Approving merge for the revert to M51 branch 2704  based on comment #16. Please revert it ASAP as we're getting very close to M51 stable candidate cut.
Project Member

Comment 18 by bugdroid1@chromium.org, May 20 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8726fa7e9fafe6969fc5fcb8fe92c53872baa014

commit 8726fa7e9fafe6969fc5fcb8fe92c53872baa014
Author: Henrik Grunell <grunell@chromium.org>
Date: Fri May 20 08:44:49 2016

Use "application default" audio device as default PulseAudio device.

This reverts commit 254c78a58a9da3a320c5ce8b1d84c0843fe3b8bc (https://codereview.chromium.org/1711823004) which changed to use the system default. That change causes problems for some use cases.

BUG= 606163 
TBR=tommi@chromium.org (this is a revert)

Review-Url: https://codereview.chromium.org/1992203002
Cr-Commit-Position: refs/heads/master@{#394758}
(cherry picked from commit 398915beccf80d5e9632b4fa8ea4f61bbc0b4835)

Review URL: https://codereview.chromium.org/1998173002 .

Cr-Commit-Position: refs/branch-heads/2704@{#615}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/8726fa7e9fafe6969fc5fcb8fe92c53872baa014/media/audio/pulse/pulse_input.cc
[modify] https://crrev.com/8726fa7e9fafe6969fc5fcb8fe92c53872baa014/media/audio/pulse/pulse_input.h
[modify] https://crrev.com/8726fa7e9fafe6969fc5fcb8fe92c53872baa014/media/audio/pulse/pulse_output.cc
[modify] https://crrev.com/8726fa7e9fafe6969fc5fcb8fe92c53872baa014/media/audio/pulse/pulse_output.h
[modify] https://crrev.com/8726fa7e9fafe6969fc5fcb8fe92c53872baa014/media/audio/pulse/pulse_util.cc
[modify] https://crrev.com/8726fa7e9fafe6969fc5fcb8fe92c53872baa014/media/audio/pulse/pulse_util.h

Sign in to add a comment