New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 606150 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 602906



Sign in to add a comment

ANGLE CQ: git diff returning no files

Project Member Reported by jmad...@chromium.org, Apr 23 2016

Issue description

Unsure if this is because of a recent change to dEQP DEPS I made or another change which broke the ANGLE CQ unbeknownst to us.

Example failure:

https://build.chromium.org/p/tryserver.chromium.angle/builders/win_angle_x64_dbg_ng/builds/1021

The problem seems to be that git diff returns no files:

https://build.chromium.org/p/tryserver.chromium.angle/builders/win_angle_x64_dbg_ng/builds/1021/steps/git%20diff%20to%20analyze%20patch/logs/stdio

MA, Ken, any ideas?
 

Comment 1 by kbr@chromium.org, Apr 23 2016

Cc: iannucci@chromium.org
I don't know but would suggest you try reverting the DEPS change.

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6376c2c38f5bbd6f56a89794f5003cce2aa89c2

commit a6376c2c38f5bbd6f56a89794f5003cce2aa89c2
Author: jmadill <jmadill@chromium.org>
Date: Sun Apr 24 02:34:38 2016

Revert of Pin dEQP to ANGLE's DEPS file. (patchset #1 id:1 of https://codereview.chromium.org/1912153003/ )

Reason for revert:
Using unsupported syntax, could possibly be breaking the ANGLE CQ.

BUG= 606150 

Original issue's description:
> Pin dEQP to ANGLE's DEPS file.
>
> This will make rolling a new dEQP version in ANGLE testable on the
> bots.
>
> BUG= 605987 
>
> Committed: https://crrev.com/60783171abc3fc122aeefd9a3705193e9191ccd9
> Cr-Commit-Position: refs/heads/master@{#389262}

TBR=maruel@chromium.org,kbr@chromium.org,kjellander@chromium.org,iannucci@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 605987 

Review URL: https://codereview.chromium.org/1914843003

Cr-Commit-Position: refs/heads/master@{#389396}

[modify] https://crrev.com/a6376c2c38f5bbd6f56a89794f5003cce2aa89c2/DEPS

Ken, looks like the revert didn't fix the build, at least on the CQ job I tried. May have been something that slipped in on Friday evening or Saturday.

Comment 4 by kbr@chromium.org, Apr 24 2016

Owner: dpranke@chromium.org
Status: Assigned (was: Untriaged)
Jamie: please provide links to your failing builds to speed up the process of diagnosis. I assume https://build.chromium.org/p/tryserver.chromium.angle/builders/win_angle_rel_ng/builds/1160 is the most recent failing one. stdout attached.

The salient part of the errors seems to be:

set GYP_DEFINES=test_isolation_mode=prepare archive_gpu_tests=1 ffmpeg_branding=Chrome proprietary_codecs=1 build_angle_deqp_tests=1 internal_gles2_conform_tests=1 component=static_library use_goma=1 fastbuild=1 dcheck_always_on=1 fastbuild=1 target_arch=ia32
python build\gyp_chromium -G output_dir=out -f analyzer -G config_path=c:\users\chrome~2\appdata\local\temp\tmpd3zt5a.json -G analyzer_output_path=c:\users\chrome~2\appdata\local\temp\tmphqtvbn.json
Enabled Psyco JIT.
Updating projects from gyp files...
Error: Must specify files to analyze via config_path generator flag

analyze output:
{
  "error": "Must specify files to analyze via config_path generator flag"
}


I have a feeling this was caused by the recent switch of the Windows bots to mb, the meta-build system. Dirk, could you help Jamie investigate these failures this coming week?

stdout.txt
2.6 MB View Download
The error I believe is that git diff is returning no files,

analyze input:
{
  "additional_compile_targets": [], 
  "files": [], 
  "test_targets": [
    "angle_deqp_egl_tests", 
    "angle_deqp_egl_tests_run", 
    "angle_deqp_gles2_tests", 
    "angle_deqp_gles2_tests_run", 
    "angle_deqp_gles3_tests", 
    "angle_deqp_gles3_tests_run", 
    "angle_end2end_tests", 
    "angle_end2end_tests_run", 
    "angle_unittests", 
    "angle_unittests_run", 
    "audio_unittests", 
    "audio_unittests_run", 
    "browser_tests", 
    "content_gl_tests", 
    "content_gl_tests_run", 
    "gl_tests", 
    "gl_tests_run", 
    "gl_unittests", 
    "gl_unittests_run", 
    "gles2_conform_test", 
    "gles2_conform_test_run", 
    "tab_capture_end2end_tests_run", 
    "telemetry_gpu_test_run"
  ]
}

here the error seems to be complaining that files is []
Also sorry for not attaching a new build, the failure mode was exactly the same for all the failing builds, including the one in the description.

https://build.chromium.org/p/tryserver.chromium.angle/builders/win_angle_rel_ng/builds/1160 is one of the set of six failing builds from the most recent try job run.

ie Mac: https://build.chromium.org/p/tryserver.chromium.angle/builders/mac_angle_rel_ng/builds/1069

same for mac_dbg, win_dbg, win_rel_64, and win_dbg_64

Comment 7 by kbr@chromium.org, Apr 25 2016

Again, I have a feeling that the failure is due to the recent change of the Windows bots to mb, the meta-build system. I'm not sure the GPU bots were converted over, and/or there may have been an error in the conversion. Hopefully Dirk can help debug the error on Monday.

Cc: tandrii@chromium.org no...@chromium.org
It's not clear to me how the switch to mb could've broken this, but I won't write it off as impossible just yet. 

I think jmadill's analysis in the description is correct, `git diff` seems to think there were no files changed, so maybe something is broken in how the patch is being downloaded and applied. There have been a bunch of changes in the git-cl/apply_patch/gerrit integration lately, so cc'ing nodir@ and tandrii@ to take a look.
Thanks. The whole ANGLE team's work is blocked because of this so help would be appreciated.
Looking
I think it's totally git diff. I suspect this is change to bot_update handling last Friday. What CL can I re-trigger to test this?
I think this is this roll https://chromium.googlesource.com/chromium/tools/build.git/+/30b94928cde1f682089eff8fe94cf201d88dcac5 that broke you. I'm going to revert change in depot_tools https://codereview.chromium.org/1904663002, then kick the recipe autoroller, and then we can retry something on your tryserver.
Owner: tandrii@chromium.org
Status: Started (was: Assigned)
FTR, given your last successful and first breaking builds and checking revisions, i found this list of possible changes in build: https://chromium.googlesource.com/chromium/tools/build.git/+log/1ded93a29efc0b2f79d78316ba1b4501bdb5be76..f635ccd891adb805e29c022540f401c119654fa4

which showed me the CL i've actually LGTM-ed and which is now reverted:
https://codereview.chromium.org/1918903003/

now let's kick the recipe roller: https://uberchromegw.corp.google.com/i/chromium.infra.cron/builders/recipe-autoroller-public/builds/2515
Triggered CQ dry run on both CLs in #12.
Cc: -no...@chromium.org
Owner: phajdan.jr@chromium.org
Status: Assigned (was: Started)
I think the analyze gets at least some diff right now.
For build 1027, these are:

  "files": [
    "third_party/angle/DEPS", 
    "third_party/angle/src/libANGLE/renderer/d3d/d3d9/StateManager9.cpp", 
    "third_party/angle/src/tests/deqp.gypi"
  ], 

I don't really understand where cpp file comes from, however. I'm reassigning this to Pawel to have a look and re-land his CL with a fix.
Labels: -Pri-1 Pri-2
Thanks Andrii, moving to Pri-2 since I think we can resume using the CQ again now.
Project Member

Comment 20 by bugdroid1@chromium.org, Apr 25 2016

Labels: merge-merged-2716
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6376c2c38f5bbd6f56a89794f5003cce2aa89c2

commit a6376c2c38f5bbd6f56a89794f5003cce2aa89c2
Author: jmadill <jmadill@chromium.org>
Date: Sun Apr 24 02:34:38 2016

Revert of Pin dEQP to ANGLE's DEPS file. (patchset #1 id:1 of https://codereview.chromium.org/1912153003/ )

Reason for revert:
Using unsupported syntax, could possibly be breaking the ANGLE CQ.

BUG= 606150 

Original issue's description:
> Pin dEQP to ANGLE's DEPS file.
>
> This will make rolling a new dEQP version in ANGLE testable on the
> bots.
>
> BUG= 605987 
>
> Committed: https://crrev.com/60783171abc3fc122aeefd9a3705193e9191ccd9
> Cr-Commit-Position: refs/heads/master@{#389262}

TBR=maruel@chromium.org,kbr@chromium.org,kjellander@chromium.org,iannucci@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 605987 

Review URL: https://codereview.chromium.org/1914843003

Cr-Commit-Position: refs/heads/master@{#389396}

[modify] https://crrev.com/a6376c2c38f5bbd6f56a89794f5003cce2aa89c2/DEPS

Blocking: 602906
Project Member

Comment 22 by bugdroid1@chromium.org, May 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/116286a64acc62a1adab07e2eddd490f65c092e4

commit 116286a64acc62a1adab07e2eddd490f65c092e4
Author: phajdan.jr@chromium.org <phajdan.jr@chromium.org>
Date: Fri May 06 14:54:12 2016

depot_tools: add debug logic to bot_update for gerrit patches

BUG= 606150 ,  602906 

Review-Url: https://codereview.chromium.org/1954083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300466 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/116286a64acc62a1adab07e2eddd490f65c092e4/recipe_modules/bot_update/resources/bot_update.py

Project Member

Comment 23 by bugdroid1@chromium.org, May 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/bc204fb2ce6f6b11a254a141dee539f3104fd791

commit bc204fb2ce6f6b11a254a141dee539f3104fd791
Author: recipe-roller@chromium.org <recipe-roller@chromium.org>
Date: Fri May 06 15:01:00 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

depot_tools:
  https://crrev.com/116286a64acc62a1adab07e2eddd490f65c092e4 depot_tools: add debug logic to bot_update for gerrit patches (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org
BUG= 606150 , 602906 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/1953253004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300467 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/bc204fb2ce6f6b11a254a141dee539f3104fd791/infra/config/recipes.cfg

Project Member

Comment 24 by bugdroid1@chromium.org, May 6 2016

The following revision refers to this bug:
  http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=87498

------------------------------------------------------------------
r87498 | recipe-roller@chromium.org | 2016-05-06T15:03:12.429891Z

-----------------------------------------------------------------
Components: Infra>Client>Angle Infra>SDK Infra>Git
Owner: tandrii@chromium.org
Status: Fixed (was: Assigned)
This has been fixed by me. The related bug of actually rebasing patches in CQ is handled here:  issue 612417 
Components: Infra>Client
Components: -Infra>Client>Angle

Sign in to add a comment