ASSERT_NOT_REACHED when painting outlines of image maps |
|||
Issue descriptionDiscovered while reviewing https://codereview.chromium.org/1912863002, we'll assert due to painting outlines twice in the attached testcase. SHOULD NEVER BE REACHED ../../third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp(90)... 1 0x120459d23 blink::PaintController::processNewItem(blink::DisplayItem&) 2 0x12044db50 void blink::PaintController::createAndAppend<blink::DrawingDisplayItem, blink:... 3 0x12044da70 blink::DrawingRecorder::~DrawingRecorder() 4 0x12044db93 blink::DrawingRecorder::~DrawingRecorder() 5 0x13aecc508 WTF::Optional<blink::DrawingRecorder>::~Optional() 6 0x13aecc453 WTF::Optional<blink::DrawingRecorder>::~Optional() 7 0x13aecc3fe blink::LayoutObjectDrawingRecorder::~LayoutObjectDrawingRecorder() 8 0x13aeca1b3 blink::LayoutObjectDrawingRecorder::~LayoutObjectDrawingRecorder() 9 0x13baeb61c blink::ImagePainter::paintAreaElementFocusRing(blink:... 10 0x13baeb354 blink::ImagePainter::paint(blink::PaintInfo const&, b...
,
Apr 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2ef23f23e20d28e9e611961c27fbaa0d49333a8 commit e2ef23f23e20d28e9e611961c27fbaa0d49333a8 Author: pdr <pdr@chromium.org> Date: Sat Apr 23 22:54:50 2016 Ensure display item ids are unique for image areas When painting the focus ring for an image map's area, we would use the same display item id (layout object + phase) for both the image's outline and the focus ring. This patch creates a separate display item type for image area focus rings. BUG= 606113 Review URL: https://codereview.chromium.org/1910233005 Cr-Commit-Position: refs/heads/master@{#389392} [add] https://crrev.com/e2ef23f23e20d28e9e611961c27fbaa0d49333a8/third_party/WebKit/LayoutTests/fast/images/imagemap-duplicate-outlines-crash-expected.html [add] https://crrev.com/e2ef23f23e20d28e9e611961c27fbaa0d49333a8/third_party/WebKit/LayoutTests/fast/images/imagemap-duplicate-outlines-crash.html [modify] https://crrev.com/e2ef23f23e20d28e9e611961c27fbaa0d49333a8/third_party/WebKit/Source/core/paint/ImagePainter.cpp [modify] https://crrev.com/e2ef23f23e20d28e9e611961c27fbaa0d49333a8/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.cpp [modify] https://crrev.com/e2ef23f23e20d28e9e611961c27fbaa0d49333a8/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h
,
Apr 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2ef23f23e20d28e9e611961c27fbaa0d49333a8 commit e2ef23f23e20d28e9e611961c27fbaa0d49333a8 Author: pdr <pdr@chromium.org> Date: Sat Apr 23 22:54:50 2016 Ensure display item ids are unique for image areas When painting the focus ring for an image map's area, we would use the same display item id (layout object + phase) for both the image's outline and the focus ring. This patch creates a separate display item type for image area focus rings. BUG= 606113 Review URL: https://codereview.chromium.org/1910233005 Cr-Commit-Position: refs/heads/master@{#389392} [add] https://crrev.com/e2ef23f23e20d28e9e611961c27fbaa0d49333a8/third_party/WebKit/LayoutTests/fast/images/imagemap-duplicate-outlines-crash-expected.html [add] https://crrev.com/e2ef23f23e20d28e9e611961c27fbaa0d49333a8/third_party/WebKit/LayoutTests/fast/images/imagemap-duplicate-outlines-crash.html [modify] https://crrev.com/e2ef23f23e20d28e9e611961c27fbaa0d49333a8/third_party/WebKit/Source/core/paint/ImagePainter.cpp [modify] https://crrev.com/e2ef23f23e20d28e9e611961c27fbaa0d49333a8/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.cpp [modify] https://crrev.com/e2ef23f23e20d28e9e611961c27fbaa0d49333a8/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h
,
Apr 25 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 Deleted