New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 606110 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Copy exoplayer's flush workaround conditions

Project Member Reported by w...@chromium.org, Apr 23 2016

Issue description

We only do the flush workaround for API level < 18 but exoplayer does it for a couple of other decoders too:

https://github.com/google/ExoPlayer/blob/master/library/src/main/java/com/google/android/exoplayer/MediaCodecTrackRenderer.java#L1022
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f69cdd991be34f090aa3888ccfb60c5a674e0da

commit 5f69cdd991be34f090aa3888ccfb60c5a674e0da
Author: watk <watk@chromium.org>
Date: Thu Jul 21 21:15:48 2016

Use the MediaCodec flush workaround in more cases

Courtesy of exoplayer, now we use the flush workaround in more cases
than before.

BUG= 606110 

Review-Url: https://codereview.chromium.org/1918623002
Cr-Commit-Position: refs/heads/master@{#406942}

[modify] https://crrev.com/5f69cdd991be34f090aa3888ccfb60c5a674e0da/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java
[modify] https://crrev.com/5f69cdd991be34f090aa3888ccfb60c5a674e0da/media/base/android/media_codec_bridge.h
[modify] https://crrev.com/5f69cdd991be34f090aa3888ccfb60c5a674e0da/media/base/android/media_codec_util.cc
[modify] https://crrev.com/5f69cdd991be34f090aa3888ccfb60c5a674e0da/media/base/android/media_codec_util.h
[modify] https://crrev.com/5f69cdd991be34f090aa3888ccfb60c5a674e0da/media/base/android/ndk_media_codec_bridge.cc
[modify] https://crrev.com/5f69cdd991be34f090aa3888ccfb60c5a674e0da/media/base/android/ndk_media_codec_bridge.h
[modify] https://crrev.com/5f69cdd991be34f090aa3888ccfb60c5a674e0da/media/base/android/sdk_media_codec_bridge.cc
[modify] https://crrev.com/5f69cdd991be34f090aa3888ccfb60c5a674e0da/media/base/android/sdk_media_codec_bridge.h
[modify] https://crrev.com/5f69cdd991be34f090aa3888ccfb60c5a674e0da/media/gpu/android_video_decode_accelerator.cc

Comment 2 by w...@chromium.org, Jul 21 2016

Components: -Blink>Media Internals>Media
Status: Fixed (was: Started)

Sign in to add a comment