New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 606106 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 608799



Sign in to add a comment

Implement "Offline snapshots for recent pages" feature

Project Member Reported by dim...@chromium.org, Apr 23 2016

Issue description

See launch bug 605704 for overall feature description.

This is a tracking bug for implementation of "recent pages snapshots".

Design doc: go/paquete-offline-page-cache-dd

 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18a6b28cc90dfc6ecfeb075804a67f74e5c42f9d

commit 18a6b28cc90dfc6ecfeb075804a67f74e5c42f9d
Author: dimich <dimich@chromium.org>
Date: Tue Apr 26 19:15:07 2016

SnapshotController implementation. It will be used in WebContentsObservers for Offline Pages - to detect the right moment to make a snapshot.
It will take input and generate a sequence of StartSnapshot calls (typically 1 or 2) to its Client.
This is initial implementation, in the future we might update the logic to rely not on a timer and onload event,
but rather on some more specific indicators (meaningful layout or proportion of resources loaded).

BUG= 606106 

Review URL: https://codereview.chromium.org/1920603002

Cr-Commit-Position: refs/heads/master@{#389843}

[modify] https://crrev.com/18a6b28cc90dfc6ecfeb075804a67f74e5c42f9d/components/components_tests.gyp
[modify] https://crrev.com/18a6b28cc90dfc6ecfeb075804a67f74e5c42f9d/components/offline_pages.gypi
[modify] https://crrev.com/18a6b28cc90dfc6ecfeb075804a67f74e5c42f9d/components/offline_pages/BUILD.gn
[add] https://crrev.com/18a6b28cc90dfc6ecfeb075804a67f74e5c42f9d/components/offline_pages/snapshot_controller.cc
[add] https://crrev.com/18a6b28cc90dfc6ecfeb075804a67f74e5c42f9d/components/offline_pages/snapshot_controller.h
[add] https://crrev.com/18a6b28cc90dfc6ecfeb075804a67f74e5c42f9d/components/offline_pages/snapshot_controller_unittest.cc

Blocking: 608799
Project Member

Comment 3 by bugdroid1@chromium.org, May 5 2016

Status: Fixed (was: Assigned)

Sign in to add a comment