New issue
Advanced search Search tips

Issue 606100 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

TTY_CONSOLE is (sometimes?) still initialized with tty2 for freon-based overlays

Project Member Reported by briannorris@chromium.org, Apr 23 2016

Issue description

I noticed that I see /etc/init/console-tty2.conf in my gru image.

I also noticed that most recent ARM-based overlays have started clobbering TTY_CONSOLE themselves (rather than appending to it) in their make.conf, possibly due to this issue. See veyron, oak, elm, and arm64-llvmpipe.

See:

https://chromium-review.googlesource.com/#/c/340286/

for more info.
 
Cc: diand...@chromium.org smbar...@chromium.org
Owner: spang@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/65d0a9f8b65304d7a3663ae98d2a19a7a66c80b0

commit 65d0a9f8b65304d7a3663ae98d2a19a7a66c80b0
Author: Brian Norris <briannorris@chromium.org>
Date: Sat Apr 23 00:21:40 2016

freon: actually disable tty2 for gru/kevin

For some overlays, ${TTY_CONSOLE} is initialized to tty2, and even
though we allegedly mask it here with adding "-tty_console_tty2" to USE.

This seems to be partially related to the old hack which is in use in
the freon overlay, where we only mask the USE flag and not the actually
TTY_CONSOLE variable. Now that portage has been patched to obviate the
hack, let's do this right: disable tty2 in the TTY_CONSOLE variable in
freon, and have subsequently-stacked overlays configure additional
console(s) in their make.defaults.

This only converts gru for now, as that's where I'm having trouble. We
could also do this conversion for other overlays now too.

BUG= chromium:606100 
TEST=`emerge chromeos-base/tty` and check for /etc/init/console-*.conf

Change-Id: I66560f53549684e54dc82003b183ed4917d73841
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/340286
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/65d0a9f8b65304d7a3663ae98d2a19a7a66c80b0/baseboard-gru/make.conf
[modify] https://crrev.com/65d0a9f8b65304d7a3663ae98d2a19a7a66c80b0/project-freon/profiles/base/make.defaults
[add] https://crrev.com/65d0a9f8b65304d7a3663ae98d2a19a7a66c80b0/baseboard-gru/profiles/base/make.defaults

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/cf2a3ff735b53d9614a1adace9b763ee802fa7f2

commit cf2a3ff735b53d9614a1adace9b763ee802fa7f2
Author: Brian Norris <briannorris@chromium.org>
Date: Wed Apr 27 03:34:05 2016

overlays: move TTY_CONSOLE to make.defaults

TTY_CONSOLE is an incremental variable in our portage profile (see
USE_EXPAND). We have previously hacked around this, because portage
didn't always handle it properly, but now that portage is fixed up, we
should be handling it in make.defaults (which can stack properly)
instead of in make.conf (which typically clobbers any existing
definition).

This theoretically makes the X vs. freon selection work a little nicer,
even if we might not care practically any more.

By inspection, this shouldn't cause any noticeable changes because:
(a) most of these TTY_CONSOLE definitions are comment out anyway;
(b) for those that aren't, they either
    (i) didn't try to (incorrectly) do incremental assignments anyway or
    (ii) don't appear to use freon (I only checked the top-level
    overlay; I didn't check all the parent structure).

(IOW, I don't believe any of these overlays actually exhibit the issue
in  http://crbug.com/606100  -- but this still qualifies as cleanup.)

BUG= chromium:606100 
TEST=`emerge-${BOARD} -av chromeos-base/tty` and check the value of
      TTY_CONSOLE; also check for /etc/init/console-tty*.conf; I did
      this test for several boards, and only inspected the remaining

Change-Id: If7573ad6de9f0d09818fbd1ded3e19f0a031697c
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/340902
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-gizmo/profiles/base/make.defaults
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-peach/profiles/base/make.defaults
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-glados/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-candy/make.conf
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-swanky/profiles/base/make.defaults
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-ultima/make.conf
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-elm/profiles/base/make.defaults
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-sumo/profiles/base/make.defaults
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-strago/make.conf
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-chell/profiles/base/make.defaults
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-tidus/profiles/base/make.defaults
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-setzer/profiles/base/make.defaults
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-quawks/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-kunimitsu/make.conf
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-heli/profiles/base/make.defaults
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-beaglebone/profiles/base/make.defaults
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-strago/profiles/base/make.defaults
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-orco/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-sentry/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-sumo/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-oak/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-cyan/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-acorn/make.conf
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-lulu/profiles/base/make.defaults
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-cyan/profiles/base/make.defaults
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-umaro/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-veyron/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-beaglebone/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-heli/make.conf
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-kunimitsu/profiles/base/make.defaults
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-kip/make.conf
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-oak/profiles/base/make.defaults
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-cranky/profiles/base/make.defaults
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-ninja/profiles/base/make.defaults
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-cranky/make.conf
[delete] https://crrev.com/ccd788e1b119f5b832f05a99524ed87283094158/project-labstation/profiles/base/make.defaults
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-rambi/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-chell/make.conf
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-clapper/profiles/base/make.defaults
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-buddy/profiles/base/make.defaults
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-raspberrypi/profiles/base/make.defaults
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-banjo/profiles/base/make.defaults
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-puppy/profiles/base/make.defaults
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-celes/make.conf
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-winky/profiles/base/make.defaults
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-ninja/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-jecht/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-veyron/profiles/base/make.defaults
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-setzer/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-gizmo/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-reptile/profiles/base/make.defaults
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-rikku/profiles/base/make.defaults
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-lulu/make.conf
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-arm64-llvmpipe/profiles/base/make.defaults
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-daisy/make.conf
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-squawks/profiles/base/make.defaults
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-winky/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-glimmer/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-variant-daisy-skate/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-expresso/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-cid/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-swanky/make.conf
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-glados/profiles/base/make.defaults
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-orco/profiles/base/make.defaults
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-tidus/make.conf
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-parry/profiles/base/make.defaults
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-celes/profiles/base/make.defaults
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-rambi/profiles/base/make.defaults
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-umaro/profiles/base/make.defaults
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-glimmer/profiles/base/make.defaults
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-guado/profiles/base/make.defaults
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-enguarde/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-reks/make.conf
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-cid/profiles/base/make.defaults
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-auron/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-nyan/profiles/base/make.defaults
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-parry/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-nyan/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-gandof/make.conf
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-gandof/profiles/base/make.defaults
[rename] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-variant-guado-labstation/profiles/base/make.defaults
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-rikku/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-raspberrypi/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-foster/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-guado/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-foster/profiles/base/make.defaults
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-reks/profiles/base/make.defaults
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-arm64-llvmpipe/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-buddy/make.conf
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-enguarde/profiles/base/make.defaults
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-clapper/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-lars/make.conf
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-auron/profiles/base/make.defaults
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-sama5d3/make.conf
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-gnawty/profiles/base/make.defaults
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-cave/profiles/base/make.defaults
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-candy/profiles/base/make.defaults
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-banon/profiles/base/make.defaults
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-gnawty/make.conf
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-ultima/profiles/base/make.defaults
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-jecht/profiles/base/make.defaults
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-kip/profiles/base/make.defaults
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-reptile/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-squawks/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-daisy/profiles/base/make.defaults
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-elm/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-puppy/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-banon/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-variant-daisy-skate/profiles/base/make.defaults
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-peach/make.conf
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-sentry/profiles/base/make.defaults
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-lars/profiles/base/make.defaults
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-sama5d3/profiles/base/make.defaults
[rename] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-variant-guado-moblab/profiles/base/make.defaults
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-wizpig/profiles/base/make.defaults
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-acorn/profiles/base/make.defaults
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-banjo/make.conf
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-terra/profiles/base/make.defaults
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-expresso/profiles/base/make.defaults
[add] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-quawks/profiles/base/make.defaults
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-terra/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-wizpig/make.conf
[modify] https://crrev.com/cf2a3ff735b53d9614a1adace9b763ee802fa7f2/overlay-cave/make.conf

Owner: briannorris@chromium.org
Status: Fixed (was: Untriaged)
Bulk verified
Status: Verified (was: Fixed)
bulk verified
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 14 2016

Labels: merge-merged-factory-oak-8182.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341

commit 49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341
Author: Brian Norris <briannorris@chromium.org>
Date: Wed Apr 27 03:34:05 2016

overlays: move TTY_CONSOLE to make.defaults

TTY_CONSOLE is an incremental variable in our portage profile (see
USE_EXPAND). We have previously hacked around this, because portage
didn't always handle it properly, but now that portage is fixed up, we
should be handling it in make.defaults (which can stack properly)
instead of in make.conf (which typically clobbers any existing
definition).

This theoretically makes the X vs. freon selection work a little nicer,
even if we might not care practically any more.

By inspection, this shouldn't cause any noticeable changes because:
(a) most of these TTY_CONSOLE definitions are comment out anyway;
(b) for those that aren't, they either
    (i) didn't try to (incorrectly) do incremental assignments anyway or
    (ii) don't appear to use freon (I only checked the top-level
    overlay; I didn't check all the parent structure).

(IOW, I don't believe any of these overlays actually exhibit the issue
in  http://crbug.com/606100  -- but this still qualifies as cleanup.)

BUG= chromium:606100 
TEST=`emerge-${BOARD} -av chromeos-base/tty` and check the value of
      TTY_CONSOLE; also check for /etc/init/console-tty*.conf; I did
      this test for several boards, and only inspected the remaining

Change-Id: If7573ad6de9f0d09818fbd1ded3e19f0a031697c
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/340902
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/360088
Reviewed-by: Hsu Wei-Cheng <mojahsu@chromium.org>
Commit-Queue: Hsu Wei-Cheng <mojahsu@chromium.org>
Tested-by: Hsu Wei-Cheng <mojahsu@chromium.org>

[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-gizmo/profiles/base/make.defaults
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-peach/profiles/base/make.defaults
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-glados/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-candy/make.conf
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-swanky/profiles/base/make.defaults
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-ultima/make.conf
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-elm/profiles/base/make.defaults
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-sumo/profiles/base/make.defaults
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-strago/make.conf
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-chell/profiles/base/make.defaults
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-tidus/profiles/base/make.defaults
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-setzer/profiles/base/make.defaults
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-quawks/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-kunimitsu/make.conf
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-heli/profiles/base/make.defaults
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-beaglebone/profiles/base/make.defaults
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-strago/profiles/base/make.defaults
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-orco/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-sentry/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-sumo/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-oak/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-cyan/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-acorn/make.conf
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-lulu/profiles/base/make.defaults
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-cyan/profiles/base/make.defaults
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-umaro/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-veyron/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-beaglebone/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-heli/make.conf
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-kunimitsu/profiles/base/make.defaults
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-kip/make.conf
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-oak/profiles/base/make.defaults
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-cranky/profiles/base/make.defaults
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-ninja/profiles/base/make.defaults
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-cranky/make.conf
[delete] https://crrev.com/a8b901ba57ec68ddbd771d0253da2d3a7d1299ed/project-labstation/profiles/base/make.defaults
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-rambi/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-chell/make.conf
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-clapper/profiles/base/make.defaults
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-buddy/profiles/base/make.defaults
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-raspberrypi/profiles/base/make.defaults
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-banjo/profiles/base/make.defaults
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-puppy/profiles/base/make.defaults
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-celes/make.conf
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-winky/profiles/base/make.defaults
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-ninja/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-jecht/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-veyron/profiles/base/make.defaults
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-setzer/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-gizmo/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-reptile/profiles/base/make.defaults
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-rikku/profiles/base/make.defaults
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-lulu/make.conf
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-arm64-llvmpipe/profiles/base/make.defaults
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-daisy/make.conf
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-squawks/profiles/base/make.defaults
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-winky/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-glimmer/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-variant-daisy-skate/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-expresso/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-cid/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-swanky/make.conf
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-glados/profiles/base/make.defaults
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-orco/profiles/base/make.defaults
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-tidus/make.conf
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-parry/profiles/base/make.defaults
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-celes/profiles/base/make.defaults
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-rambi/profiles/base/make.defaults
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-umaro/profiles/base/make.defaults
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-glimmer/profiles/base/make.defaults
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-guado/profiles/base/make.defaults
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-enguarde/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-reks/make.conf
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-cid/profiles/base/make.defaults
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-auron/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-nyan/profiles/base/make.defaults
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-parry/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-nyan/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-gandof/make.conf
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-gandof/profiles/base/make.defaults
[rename] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-variant-guado-labstation/profiles/base/make.defaults
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-rikku/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-raspberrypi/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-foster/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-guado/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-foster/profiles/base/make.defaults
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-reks/profiles/base/make.defaults
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-arm64-llvmpipe/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-buddy/make.conf
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-enguarde/profiles/base/make.defaults
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-clapper/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-lars/make.conf
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-auron/profiles/base/make.defaults
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-sama5d3/make.conf
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-gnawty/profiles/base/make.defaults
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-cave/profiles/base/make.defaults
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-candy/profiles/base/make.defaults
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-banon/profiles/base/make.defaults
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-gnawty/make.conf
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-ultima/profiles/base/make.defaults
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-jecht/profiles/base/make.defaults
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-kip/profiles/base/make.defaults
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-reptile/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-squawks/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-daisy/profiles/base/make.defaults
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-elm/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-puppy/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-banon/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-variant-daisy-skate/profiles/base/make.defaults
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-peach/make.conf
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-sentry/profiles/base/make.defaults
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-lars/profiles/base/make.defaults
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-sama5d3/profiles/base/make.defaults
[rename] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-variant-guado-moblab/profiles/base/make.defaults
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-wizpig/profiles/base/make.defaults
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-acorn/profiles/base/make.defaults
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-banjo/make.conf
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-terra/profiles/base/make.defaults
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-expresso/profiles/base/make.defaults
[add] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-quawks/profiles/base/make.defaults
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-terra/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-wizpig/make.conf
[modify] https://crrev.com/49f9351bfe8fac4c69c8306f8f0d0ea1a6f19341/overlay-cave/make.conf

Sign in to add a comment