New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 606086 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OOO until NaN
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Remove RenderFrameImpl::GetFocusedElement

Project Member Reported by dglazkov@chromium.org, Apr 22 2016

Issue description

... as a step toward better Onion Soup, reducing the use of WebElement.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b1ec427a7fc6c12c6323930b93eee37ee71dc42

commit 1b1ec427a7fc6c12c6323930b93eee37ee71dc42
Author: dglazkov <dglazkov@chromium.org>
Date: Mon May 16 21:13:30 2016

Remove RenderFrameImpl::GetFocusedElement.

The concept of WebNode shouldn't really exist in the Blink Onion Soup world. In this particular case, the knowledge of the focused element was already being plumbed in and out of Blink. This patch removes the weaving and the API that caused it.

There should be no behavior change, but one of the existing behaviors wasn't covered by tests, so I added it.

BUG= 606086 
TEST= WebPluginContainerTest.CopyFromContextMenu

Review-Url: https://codereview.chromium.org/1977633003
Cr-Commit-Position: refs/heads/master@{#393923}

[modify] https://crrev.com/1b1ec427a7fc6c12c6323930b93eee37ee71dc42/components/autofill/content/renderer/page_click_tracker.cc
[modify] https://crrev.com/1b1ec427a7fc6c12c6323930b93eee37ee71dc42/components/autofill/content/renderer/password_autofill_agent.cc
[modify] https://crrev.com/1b1ec427a7fc6c12c6323930b93eee37ee71dc42/content/public/renderer/render_frame.h
[modify] https://crrev.com/1b1ec427a7fc6c12c6323930b93eee37ee71dc42/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/1b1ec427a7fc6c12c6323930b93eee37ee71dc42/content/renderer/render_frame_impl.h
[modify] https://crrev.com/1b1ec427a7fc6c12c6323930b93eee37ee71dc42/content/renderer/render_view_impl.cc
[modify] https://crrev.com/1b1ec427a7fc6c12c6323930b93eee37ee71dc42/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/1b1ec427a7fc6c12c6323930b93eee37ee71dc42/third_party/WebKit/Source/web/WebLocalFrameImpl.h
[modify] https://crrev.com/1b1ec427a7fc6c12c6323930b93eee37ee71dc42/third_party/WebKit/Source/web/WebNode.cpp
[modify] https://crrev.com/1b1ec427a7fc6c12c6323930b93eee37ee71dc42/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
[modify] https://crrev.com/1b1ec427a7fc6c12c6323930b93eee37ee71dc42/third_party/WebKit/Source/web/WebRemoteFrameImpl.h
[modify] https://crrev.com/1b1ec427a7fc6c12c6323930b93eee37ee71dc42/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/1b1ec427a7fc6c12c6323930b93eee37ee71dc42/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp
[modify] https://crrev.com/1b1ec427a7fc6c12c6323930b93eee37ee71dc42/third_party/WebKit/public/web/WebFrame.h
[modify] https://crrev.com/1b1ec427a7fc6c12c6323930b93eee37ee71dc42/third_party/WebKit/public/web/WebNode.h

Status: Fixed (was: Started)

Comment 3 by tkent@chromium.org, Jun 23 2016

Components: -Blink>Architecture Blink>Internals
Renaming Blink>Architecture to Blink>Internals

Sign in to add a comment