LKGR builders can't find goma |
|||
Issue descriptionLooks like we moved the location of goma on the bots but the (non-recipe) LKGR builders weren't told about it and now can't find it: https://build.chromium.org/p/chromium.lkgr/builders/ASAN%20Release/builds/2109 (good) https://build.chromium.org/p/chromium.lkgr/builders/ASAN%20Release/builds/2110 (bad) The LKGR master was restarted in between those two builds, and the new builds are using MB to generate the build files, but I don't think that's the problem. Rather, I see no evidence that the builder was configured to specify a goma_dir anywhere, and as a result would've used the default location ($HOME/goma); however, I think we switched to pulling goma via cipd and maybe that changed the location?
,
Apr 22 2016
from https://build.chromium.org/p/chromium.lkgr/builders/ASAN%20Release/builds/2110/steps/compile/logs/stdio: /usr/bin/python /mnt/data/b/build/goma/goma_ctl.py restart creating crash dump dir (/tmp/goma_crash.chrome-bot). 19038 Using goma VERSION=104 (no_auto_update) GOMA version 4270fba7bcd47eb26a63f9dbb2f263f1c01b7965@1460960074 compiler proxy (pid=19023,19038) status: http://127.0.0.1:8088 ok Now goma is ready! ---------------------- doesn't this mean that it can find goma? Maybe I don't understand something..
,
Apr 22 2016
It's this part that is the problem (further down in the file): [90/21905] CXX obj/third_party/libyuv/source/libyuv.convert_to_i420.o FAILED: /home/chrome-bot/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD ... -c ../../third_party/libyuv/source/convert_from_argb.cc -o obj/third_party/libyuv/source/libyuv.convert_from_argb.o /bin/sh: 1: /home/chrome-bot/goma/gomacc: not found
,
Apr 22 2016
vm980-m1:/b/build/goma/gomacc exists
,
Apr 23 2016
This is my fault; when I changed the bots to use MB, they aren't passing in the location of goma. I had not noticed that before, because the other non-recipe bots that do this (the official desktop bots) don't use goma. Fixing now ...
,
Apr 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/97ebb85bad75d14f77b740e5292901f3119048f4 commit 97ebb85bad75d14f77b740e5292901f3119048f4 Author: dpranke@chromium.org <dpranke@chromium.org> Date: Sat Apr 23 00:44:54 2016 Make non-recipe builders that use MB work w/ goma properly. TBR=nodir@chromium.org BUG= 606082 Review URL: https://codereview.chromium.org/1920453004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300129 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/97ebb85bad75d14f77b740e5292901f3119048f4/scripts/master/factory/commands.py
,
Apr 23 2016
I've pushed a fix and restarted the master, and multiple builders have successfully found goma (though no builds have actually completed yet), so I think this is fixed. |
|||
►
Sign in to add a comment |
|||
Comment 1 by no...@chromium.org
, Apr 22 2016