Theme color on Android allows sites to de-emphasize the lock icon and make "https" gray. |
|||||||||||||
Issue description<b>Version: <Kenneth, what is the frequency?></b> <b>OS: <please tell me it's not XP></b> What steps will reproduce the problem? (1) Visit github.com (2) Visit github.com/lgarron/badssl.com What is the expected output? The lock icon stays the same and "https" stays green. (github-no-theme.png) What do you see instead? The lock icon is replaced by a smaller one (with white padding around it) and the scheme becomes gray. (github-fdfdfd.png) GitHub sends <meta name="theme-color" content="#f5f5f5"> to Android, which triggers Hera coloring. It *used* to be that we would show the usual lock icon and green scheme for light theme-colors. For dark colors, we always showed the inverted lock icon and gray scheme, but that didn't look excellent for all colors (see Issue 436553 ). At some point, it seems we switched to inverted at all times. Was this intentional? Given that their theme color matches the URL bar color, GitHub seems to be doing it purely to reduce the visibility of our security indicators. Are we okay with that? yusufo@: Do you know how this decision was reached? felt@, palmer@, ainslie@: Bug? WontFix? "Urgh"?
,
Apr 25 2016
We have mainly done this to get out of situations where green emphasis was getting lost inside some colors that has enough tinge of green in them. And the main thing that we wanted to stay careful about was theme color disappearing on broken lock and red emphasis staying there. Am I misremembering this, or the new lock icons were going to be a single color irrespective of the SSL state?
,
Apr 25 2016
The lock color will change in some states. It'll still be green with the normal gray toolbar and then black/white to match the toolbar-controls + omnibox text for theme-color toolbars. A white lock icon example (outdated mock, not a spec) is attached. https://docs.google.com/presentation/d/1symd8YrF_GF3KG7gEaRgpl9xHogxAqD3P7dVojLZwT4/edit#slide=id.gf2f47636d_0_5
,
Apr 29 2016
I guess this is WontFix, then? I just came across someone who was confused about the current behaviour: "What does it mean for smaller green lock icon ?" [1] sealhouse.cc does the same as GitHub. [1] https://productforums.google.com/forum/?utm_medium=email&utm_source=footer#!msg/chrome/xRgn5M33BPs/F9Jg4dprAwAJ
,
Jul 19 2016
It looks like this has been fixed.
,
Dec 9 2016
Security>UX component is deprecated in favor of the Team-Security-UX label |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by ainslie@chromium.org
, Apr 24 2016