Some pseudo style changes are not properly handled for paint invalidation and layout |
|||||||||
Issue description
Open attached test case. The first line should be green.
The problem is that in Element::recalcOwnStyle():
if (localChange != NoChange || pseudoStyleCacheIsInvalid(oldStyle.get(), newStyle.get()) || svgFilterNeedsLayerUpdate()) {
pseudoStyleCacheIsValid (which has side-effect to update pseudo style cache and invalidate for first-line style change) is called only if localChange == NoChange.
,
Apr 22 2016
Issue 563943 has been merged into this issue.
,
Apr 22 2016
Copy the test case of bug 563943 (by rune@opera.com) here.
,
Apr 22 2016
Re: #1 s/too familiar/too unfamiliar/ :)
,
Apr 22 2016
The pseudo cache code has always looked broken to me, but I could never produce a test to show it. I think we should stop storing styles embedded inside ComputedStyle fwiw and just use ElementRareData. We should treat resolving those styles as a totally separate pass independent of the main style.
,
Aug 10 2016
,
Aug 18 2016
I looked at this in Chrome, Safari and Firefox using selection.html: Chrome: Background is red on load, highlights green when using the mouse Safari: Background is red on load, highlights green when using the mouse Firefox: Background is blue on load, highlights blue when using the mouse
,
Aug 18 2016
Firefox needs the ::-moz- prefix. Interestingly, Gecko has the same issue with selection.html.
,
Feb 13 2017
,
Oct 30 2017
,
Oct 31 2017
On 64.0.3253.0, can't reproduce #c3 but can repro #c1.
,
Nov 23 2017
,
Dec 6 2017
,
Dec 6
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 6
#c0 still reproduces. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by wangxianzhu@chromium.org
, Apr 22 2016Owner: ----
Status: Available (was: Assigned)
Summary: Some pseudo style changes are not properly handled for paint invalidation and layout (was: First-line style change together with other style change may not update first line style)