New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 606067 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

need verfication of glibc fix

Project Member Reported by llozano@chromium.org, Apr 22 2016

Issue description

please verify fix for https://sourceware.org/bugzilla/show_bug.cgi?id=13862

is in our sources for glibc.

see  b/28155578 for more details.


 
Labels: -Pri-3 Pri-2
Cc: llozano@chromium.org
No, this patch is not in our tree. Do we want it?

Comment 3 by wzhong@chromium.org, Apr 25 2016

Yes. Please apply the patch.

Thanks.
Sure.
Just want to make sure.
Is the patch this one?
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=d8dd00805b8f3a011735d7a407097fb1c408d867

Comment 5 by wzhong@chromium.org, Apr 25 2016

I think 2 patches are needed.

"Reallocate DTV if the current DTV isn't big enough"

"Resize DTV if the current DTV isn't big enough"

https://sourceware.org/bugzilla/show_bug.cgi?id=13862

Comment 6 by wzhong@chromium.org, Apr 25 2016

Sorry. I guess the 2 patches actually refers to the same CL.

Yes. The link is https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=d8dd00805b8f3a011735d7a407097fb1c408d867
The patch applies cleanly but it depends on other patches. It may take some time to apply it to our tree.
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ed7c38de93fc3f40b29b38b298467872b3b4a5af

commit ed7c38de93fc3f40b29b38b298467872b3b4a5af
Author: Yunlian Jiang <yunlian@google.com>
Date: Mon Apr 25 20:28:14 2016

glibc: backport a patch requested by ChromeCast

This backports the upstream commit
commit d8dd00805b8f3a011735d7a407097fb1c408d867
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Fri Nov 28 07:54:07 2014 -0800

    Resize DTV if the current DTV isn't big enough

And it replaces a call to atomic_load_acquire() with
__atomic_load_n(). The former macro was introduced by another patch and
glibc 2.19 could not build with that one because a macro was not defined.

The patch that adds atomic_load_acquire() was
commit ff8714269c9312d9164456279a56b6f6c47e2771
Author: Torvald Riegel <triegel@redhat.com>
Date:   Sun Sep 14 20:04:54 2014 +0200

    Add atomic operations similar to those provided by C11.

BUG= chromium:606067 
TEST=emerge glibc passes.
     cbuildbot chromiumos-sdk falco-release daisy-release
     test case in the bug entry passes.

Change-Id: I2d6101d5fae08e8b942952154409953669d02e46
Reviewed-on: https://chromium-review.googlesource.com/340369
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Wei Zhong <wzhong@google.com>
Reviewed-by: Luis Lozano <llozano@chromium.org>

[add] https://crrev.com/ed7c38de93fc3f40b29b38b298467872b3b4a5af/sys-libs/glibc/files/local/glibc-2.21-resize-dtv.patch
[rename] https://crrev.com/ed7c38de93fc3f40b29b38b298467872b3b4a5af/sys-libs/glibc/glibc-2.19-r11.ebuild

Status: Fixed (was: Assigned)
Bulk verified
Status: Verified (was: Fixed)
bulk verified

Sign in to add a comment