New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 606061 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Clean up CHECKs that assert that MediaCodec methods don't fail

Project Member Reported by w...@chromium.org, Apr 22 2016

Issue description

Comment 1 by ti...@chromium.org, May 9 2016

Components: Internals>Media
Labels: OS-Android
Project Member

Comment 2 by bugdroid1@chromium.org, May 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68736c79b4c85fc95c321f1e4b5523a9e22dd1df

commit 68736c79b4c85fc95c321f1e4b5523a9e22dd1df
Author: timav <timav@chromium.org>
Date: Thu May 12 00:51:02 2016

Report media error if PlayOutputBuffer failed

Replace CHECK_EQ with a proper error reporting in
MediaSourcePlayer and MediaCodecPlayer. This CL completes
https://codereview.chromium.org/1764813002.

For MediaSourcePlayer we report the error through the
status that is passed with DecoderCallback. For MediaCodecPlayer
the decoder's method Render() now returns bool.

BUG= 585978 ,  606061 

Review-Url: https://codereview.chromium.org/1963343002
Cr-Commit-Position: refs/heads/master@{#393124}

[modify] https://crrev.com/68736c79b4c85fc95c321f1e4b5523a9e22dd1df/media/base/android/audio_decoder_job.cc
[modify] https://crrev.com/68736c79b4c85fc95c321f1e4b5523a9e22dd1df/media/base/android/audio_decoder_job.h
[modify] https://crrev.com/68736c79b4c85fc95c321f1e4b5523a9e22dd1df/media/base/android/audio_media_codec_decoder.cc
[modify] https://crrev.com/68736c79b4c85fc95c321f1e4b5523a9e22dd1df/media/base/android/audio_media_codec_decoder.h
[modify] https://crrev.com/68736c79b4c85fc95c321f1e4b5523a9e22dd1df/media/base/android/media_codec_decoder.cc
[modify] https://crrev.com/68736c79b4c85fc95c321f1e4b5523a9e22dd1df/media/base/android/media_codec_decoder.h
[modify] https://crrev.com/68736c79b4c85fc95c321f1e4b5523a9e22dd1df/media/base/android/media_decoder_job.cc
[modify] https://crrev.com/68736c79b4c85fc95c321f1e4b5523a9e22dd1df/media/base/android/media_decoder_job.h
[modify] https://crrev.com/68736c79b4c85fc95c321f1e4b5523a9e22dd1df/media/base/android/sdk_media_codec_bridge.cc
[modify] https://crrev.com/68736c79b4c85fc95c321f1e4b5523a9e22dd1df/media/base/android/video_decoder_job.cc
[modify] https://crrev.com/68736c79b4c85fc95c321f1e4b5523a9e22dd1df/media/base/android/video_decoder_job.h
[modify] https://crrev.com/68736c79b4c85fc95c321f1e4b5523a9e22dd1df/media/base/android/video_media_codec_decoder.cc
[modify] https://crrev.com/68736c79b4c85fc95c321f1e4b5523a9e22dd1df/media/base/android/video_media_codec_decoder.h

Comment 3 by ti...@chromium.org, May 12 2016

Labels: Merge-Request-51 M-51

Comment 4 by tin...@google.com, May 12 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 5 by sheriffbot@chromium.org, May 15 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, May 18 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, May 18 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1986ad6ff280f97d0965265156eb9c6731fa55f

commit b1986ad6ff280f97d0965265156eb9c6731fa55f
Author: Tima Vaisburd <timav@chromium.org>
Date: Wed May 18 18:21:11 2016

[merged] Report media error if PlayOutputBuffer failed

Replace CHECK_EQ with a proper error reporting in
MediaSourcePlayer and MediaCodecPlayer. This CL completes
https://codereview.chromium.org/1764813002.

For MediaSourcePlayer we report the error through the
status that is passed with DecoderCallback. For MediaCodecPlayer
the decoder's method Render() now returns bool.

BUG= 585978 ,  606061 
TBR=timav

> Review-Url: https://codereview.chromium.org/1963343002
> Cr-Commit-Position: refs/heads/master@{#393124}

Review URL: https://codereview.chromium.org/1992913002 .

Cr-Commit-Position: refs/branch-heads/2704@{#585}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/b1986ad6ff280f97d0965265156eb9c6731fa55f/media/base/android/audio_decoder_job.cc
[modify] https://crrev.com/b1986ad6ff280f97d0965265156eb9c6731fa55f/media/base/android/audio_decoder_job.h
[modify] https://crrev.com/b1986ad6ff280f97d0965265156eb9c6731fa55f/media/base/android/audio_media_codec_decoder.cc
[modify] https://crrev.com/b1986ad6ff280f97d0965265156eb9c6731fa55f/media/base/android/audio_media_codec_decoder.h
[modify] https://crrev.com/b1986ad6ff280f97d0965265156eb9c6731fa55f/media/base/android/media_codec_decoder.cc
[modify] https://crrev.com/b1986ad6ff280f97d0965265156eb9c6731fa55f/media/base/android/media_codec_decoder.h
[modify] https://crrev.com/b1986ad6ff280f97d0965265156eb9c6731fa55f/media/base/android/media_decoder_job.cc
[modify] https://crrev.com/b1986ad6ff280f97d0965265156eb9c6731fa55f/media/base/android/media_decoder_job.h
[modify] https://crrev.com/b1986ad6ff280f97d0965265156eb9c6731fa55f/media/base/android/sdk_media_codec_bridge.cc
[modify] https://crrev.com/b1986ad6ff280f97d0965265156eb9c6731fa55f/media/base/android/video_decoder_job.cc
[modify] https://crrev.com/b1986ad6ff280f97d0965265156eb9c6731fa55f/media/base/android/video_decoder_job.h
[modify] https://crrev.com/b1986ad6ff280f97d0965265156eb9c6731fa55f/media/base/android/video_media_codec_decoder.cc
[modify] https://crrev.com/b1986ad6ff280f97d0965265156eb9c6731fa55f/media/base/android/video_media_codec_decoder.h

Comment 8 by ti...@chromium.org, May 24 2016

Status: Fixed (was: Assigned)

Sign in to add a comment