New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 606055 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 613882
Owner:
Last visit > 30 days ago
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Move InspectorConsoleAgent related stuff to v8_inspector

Project Member Reported by kozyatinskiy@chromium.org, Apr 22 2016

Issue description

Move InspectorConsoleAgent related stuff to v8_inspector:
 - move InspectorConsoleAgent,
 - move ConsoleMessage,
 - move ConsoleMessageStorage.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6477e7c9a36b751f3a28aa985a9f01a771a4a35

commit d6477e7c9a36b751f3a28aa985a9f01a771a4a35
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Fri Apr 22 23:58:06 2016

[DevTools] Remove reference to DebuggerAgent from ConsoleAgent

BUG= 606055 
R=dgozman@chromium.org

Review URL: https://codereview.chromium.org/1913093003

Cr-Commit-Position: refs/heads/master@{#389312}

[modify] https://crrev.com/d6477e7c9a36b751f3a28aa985a9f01a771a4a35/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp
[modify] https://crrev.com/d6477e7c9a36b751f3a28aa985a9f01a771a4a35/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h
[modify] https://crrev.com/d6477e7c9a36b751f3a28aa985a9f01a771a4a35/third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp
[modify] https://crrev.com/d6477e7c9a36b751f3a28aa985a9f01a771a4a35/third_party/WebKit/Source/core/inspector/PageConsoleAgent.h
[modify] https://crrev.com/d6477e7c9a36b751f3a28aa985a9f01a771a4a35/third_party/WebKit/Source/core/inspector/WorkerConsoleAgent.cpp
[modify] https://crrev.com/d6477e7c9a36b751f3a28aa985a9f01a771a4a35/third_party/WebKit/Source/core/inspector/WorkerConsoleAgent.h
[modify] https://crrev.com/d6477e7c9a36b751f3a28aa985a9f01a771a4a35/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
[modify] https://crrev.com/d6477e7c9a36b751f3a28aa985a9f01a771a4a35/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp
[modify] https://crrev.com/d6477e7c9a36b751f3a28aa985a9f01a771a4a35/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 25 2016

Labels: merge-merged-2716
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6477e7c9a36b751f3a28aa985a9f01a771a4a35

commit d6477e7c9a36b751f3a28aa985a9f01a771a4a35
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Fri Apr 22 23:58:06 2016

[DevTools] Remove reference to DebuggerAgent from ConsoleAgent

BUG= 606055 
R=dgozman@chromium.org

Review URL: https://codereview.chromium.org/1913093003

Cr-Commit-Position: refs/heads/master@{#389312}

[modify] https://crrev.com/d6477e7c9a36b751f3a28aa985a9f01a771a4a35/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp
[modify] https://crrev.com/d6477e7c9a36b751f3a28aa985a9f01a771a4a35/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h
[modify] https://crrev.com/d6477e7c9a36b751f3a28aa985a9f01a771a4a35/third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp
[modify] https://crrev.com/d6477e7c9a36b751f3a28aa985a9f01a771a4a35/third_party/WebKit/Source/core/inspector/PageConsoleAgent.h
[modify] https://crrev.com/d6477e7c9a36b751f3a28aa985a9f01a771a4a35/third_party/WebKit/Source/core/inspector/WorkerConsoleAgent.cpp
[modify] https://crrev.com/d6477e7c9a36b751f3a28aa985a9f01a771a4a35/third_party/WebKit/Source/core/inspector/WorkerConsoleAgent.h
[modify] https://crrev.com/d6477e7c9a36b751f3a28aa985a9f01a771a4a35/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
[modify] https://crrev.com/d6477e7c9a36b751f3a28aa985a9f01a771a4a35/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp
[modify] https://crrev.com/d6477e7c9a36b751f3a28aa985a9f01a771a4a35/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4

commit 2cab1fca0201ab6d6b059bb0057e63973ebbb3c4
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Tue Apr 26 00:12:28 2016

[DevTools] Move part of CommandLineAPI to native

- ScopeExtension is stored by v8::Private instead v8::Symbol;
- part of CommandLineAPI methods are moved to native;

The benefits are:
- scopeExtension object can not be received in JS and stored somewhere;
- console related methods (dir, dirxml, ...) can't be overridden;
- removed InspectorConsoleAgent::clearAllMessages method;
- removed one more InjectedScriptSource.js part;

BUG= 606055 , 595206 
R=dgozman@chromium.org

Review URL: https://codereview.chromium.org/1917733002

Cr-Commit-Position: refs/heads/master@{#389628}

[modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/LayoutTests/inspector-protocol/console/console-let-const-with-api-expected.txt
[modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/LayoutTests/inspector/console/console-command-clear-expected.txt
[modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
[modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp
[modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h
[modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp
[modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/core/inspector/PageConsoleAgent.h
[modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
[modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp
[modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h
[modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.cpp
[modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.h
[modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js
[modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp
[modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp
[modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/V8Console.h
[modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
[modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h
[modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp
[modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h
[modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
[modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h
[modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/injected_script_externs.js
[modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h
[modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/platform/v8_inspector/public/V8RuntimeAgent.h
[modify] https://crrev.com/2cab1fca0201ab6d6b059bb0057e63973ebbb3c4/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Mergedinto: 613882
Status: Duplicate (was: Assigned)

Sign in to add a comment