Always increase one dimension when calculating natural size. |
|||||||||
Issue descriptionAccording to the spec related to video.videoWidth and video.videoHeight: If an anamorphic format does not define how to apply the aspect ratio to the video data's dimensions to obtain the "correct" dimensions, then the user agent must apply the ratio by increasing one dimension and leaving the other unchanged. Note that we should always "apply the ratio by INCREASING one dimension and leaving the other unchanged". Today in GetNaturalSize() we always keep the height unchanged and stretch/shrink the width, which seems wrong. We should update our unittests and layout tests to cover this as well.
,
Apr 22 2016
philipj: Please also help check whether I interpret the spec correctly. Thanks! :)
,
Apr 25 2016
That is the correct interpretation of the spec. It was changed in https://github.com/whatwg/html/commit/2e94aa64fcf9adbd2f70d8c2aecd192c8678e298 from previously always adjusting the width. There's no context given, but I know that I implemented what the spec now says in Presto and I think it makes sense, so I hope the change works out here. Have you tested what Edge, Firefox and Safari do? In the unlikely even that all implementations already do the same thing, then I think we should revert the spec change instead.
,
Nov 11 2016
,
Nov 11 2016
,
Nov 13 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 13 2017
It seems this is something we should at least take a look. If we need to update, it should be a simple change.
,
Nov 21 2017
,
Dec 11 2017
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e917df9e42072f9b20dc6eb8021c2b5f72014af1 commit e917df9e42072f9b20dc6eb8021c2b5f72014af1 Author: Ted Meyer <tmathmeyer@chromium.org> Date: Wed Dec 13 04:16:30 2017 Follow spec on generating video natural size Basically we always scale up, rather than scale width, which is what the spec was changed to require about a year ago. BUG= 606039 Change-Id: Iebfed41771a5b11bad6daf3655de750cce4c6cf8 Reviewed-on: https://chromium-review.googlesource.com/813201 Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#523683} [modify] https://crrev.com/e917df9e42072f9b20dc6eb8021c2b5f72014af1/media/base/video_decoder_config_unittest.cc [modify] https://crrev.com/e917df9e42072f9b20dc6eb8021c2b5f72014af1/media/base/video_util.cc [modify] https://crrev.com/e917df9e42072f9b20dc6eb8021c2b5f72014af1/media/base/video_util_unittest.cc [add] https://crrev.com/e917df9e42072f9b20dc6eb8021c2b5f72014af1/third_party/WebKit/LayoutTests/media/content/test-par-5-7.webm [add] https://crrev.com/e917df9e42072f9b20dc6eb8021c2b5f72014af1/third_party/WebKit/LayoutTests/media/video-display-always-increase-size.html [modify] https://crrev.com/e917df9e42072f9b20dc6eb8021c2b5f72014af1/third_party/WebKit/LayoutTests/media/video-display-aspect-ratio.html
,
Dec 13 2017
,
Dec 13 2017
One last thing, did you check how other browsers handle this? Thanks! |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by xhw...@chromium.org
, Apr 22 2016