New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 606024 link

Starred by 1 user
Status: WontFix
Owner:
█ joenotcharles@chromium.org
Last visit > 30 days ago
Closed: Nov 2016
Cc:
vakh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

UrlToFullHashes has too much overhead during resource load

Project Member Reported by joenotcharles@chromium.org, Apr 22 2016 
During resource load, safe_browsing::UrlToFullHashes is called three times in a row with the same input:

Once from OffDomainInclusionDetector::OnResourceRequest
Then twice from LocalSafeBrowsingDatabaseManager::CheckBrowseUrl

This should be optimized.

Comment 2 by phistuck@chromium.org, Nov 3 2016

Components: UI>Browser>SafeBrowsing
Status: Untriaged
Fixed the empty status.

Comment 3 by jialiul@chromium.org, Nov 3 2016

Components: -UI>Browser>SafeBrowsing Services>Safebrowsing

Comment 4 by nparker@chromium.org, Nov 4 2016

Labels: -Pri-2 Pri-3
Owner: joenotcharles@chromium.org
Status: (was: Untriaged)
joenotcharles -- Do you have numbers that indicate this is a performance problem?

Comment 5 by nparker@chromium.org, Nov 4 2016

Status: WontFix
OffDomainInclusionDetector is gone, and in Pver4 the urltofullhashes is only called once.
►

Sign in to add a comment